LukeParke/connexion
1
0
Fork 0
mirror of https://github.com/LukeHagar/connexion.git synced 2025-12-09 12:27:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

Case insensitive check for boolean validation

Browse Source
This commit is contained in:
cyprien-g
2015-12-28 16:18:49 +01:00
parent 7e67011fc5
commit 754c250f7e
2 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
connexion/utils.py
View File

@@ -131,9 +131,9 @@ def boolean(s):
>>> boolean('false') >>> boolean('false')
False False
''' '''
if s in ['true', 'True']: if s.lower() == 'true':
return True return True
elif s in ['false', 'False']: elif s.lower() == 'false':
return False return False
else: else:
raise ValueError('Invalid boolean value') raise ValueError('Invalid boolean value')

2
tests/test_utils.py
View File

@@ -34,8 +34,10 @@ def test_get_function_from_name_for_class_method():
def test_boolean(): def test_boolean():
assert utils.boolean('true') assert utils.boolean('true')
assert utils.boolean('True') assert utils.boolean('True')
assert utils.boolean('TRUE')
assert not utils.boolean('false') assert not utils.boolean('false')
assert not utils.boolean('False') assert not utils.boolean('False')
assert not utils.boolean('FALSE')
with pytest.raises(ValueError): with pytest.raises(ValueError):
utils.boolean('foo') utils.boolean('foo')