From 586195b5c868dea6ff34a63716cecbbdd4aafcbe Mon Sep 17 00:00:00 2001
From: Mauricio Siu <47042324+Siumauricio@users.noreply.github.com>
Date: Sun, 5 Oct 2025 00:47:50 -0600
Subject: [PATCH] refactor: enhance DockerTerminalModal component for better
 prop handling

- Removed unnecessary conditional check for containerId in the main dialog open handler.
- Updated Terminal component to ensure serverId and containerId have default values, improving robustness and user experience.
---
 .../settings/web-server/docker-terminal-modal.tsx      | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/apps/dokploy/components/dashboard/settings/web-server/docker-terminal-modal.tsx b/apps/dokploy/components/dashboard/settings/web-server/docker-terminal-modal.tsx
index 5f072131..30471bcb 100644
--- a/apps/dokploy/components/dashboard/settings/web-server/docker-terminal-modal.tsx
+++ b/apps/dokploy/components/dashboard/settings/web-server/docker-terminal-modal.tsx
@@ -64,10 +64,6 @@ export const DockerTerminalModal = ({
 	const [confirmDialogOpen, setConfirmDialogOpen] = useState(false);
 
 	const handleMainDialogOpenChange = (open: boolean) => {
-		if (!open && !containerId) {
-			setMainDialogOpen(false);
-			return;
-		}
 		if (!open) {
 			setConfirmDialogOpen(true);
 		} else {
@@ -131,7 +127,11 @@ export const DockerTerminalModal = ({
 						</SelectGroup>
 					</SelectContent>
 				</Select>
-				<Terminal serverId={serverId} id="terminal" containerId={containerId} />
+				<Terminal
+					serverId={serverId || ""}
+					id="terminal"
+					containerId={containerId || "select-a-container"}
+				/>
 				<Dialog open={confirmDialogOpen} onOpenChange={setConfirmDialogOpen}>
 					<DialogContent onEscapeKeyDown={(event) => event.preventDefault()}>
 						<DialogHeader>