99.9 % coverage & full OpenAPI v3 support

A single line that tries to read an HTTP response body and fails is very hard to test without mocking, and the mock does not add value to a single line of code to check for an error that can rarely ever be triggered. Going to settle for 99.9% for now.

resolver/resolver_test.go

@@ -41,6 +41,38 @@ func TestResolver_ResolveComponents_CircularSpec(t *testing.T) {
 	assert.NoError(t, err)
 }
 
+func TestResolver_CheckForCircularReferences(t *testing.T) {
+
+	circular, _ := ioutil.ReadFile("../test_specs/circular-tests.yaml")
+	var rootNode yaml.Node
+	yaml.Unmarshal(circular, &rootNode)
+
+	index := index.NewSpecIndex(&rootNode)
+
+	resolver := NewResolver(index)
+	assert.NotNil(t, resolver)
+
+	circ := resolver.CheckForCircularReferences()
+	assert.Len(t, circ, 3)
+	assert.Len(t, resolver.GetResolvingErrors(), 3)
+	assert.Len(t, resolver.GetCircularErrors(), 3)
+
+	_, err := yaml.Marshal(resolver.resolvedRoot)
+	assert.NoError(t, err)
+}
+
+func TestResolver_DeepJourney(t *testing.T) {
+
+	var journey []*index.Reference
+	for f := 0; f < 200; f++ {
+		journey = append(journey, nil)
+	}
+	index := index.NewSpecIndex(nil)
+	resolver := NewResolver(index)
+	assert.Nil(t, resolver.extractRelatives(nil, nil, journey, false))
+
+}
+
 func TestResolver_ResolveComponents_Stripe(t *testing.T) {
 
 	stripe, _ := ioutil.ReadFile("../test_specs/stripe.yaml")
@@ -60,6 +92,57 @@ func TestResolver_ResolveComponents_Stripe(t *testing.T) {
 
 }
 
+func TestResolver_ResolveComponents_BurgerShop(t *testing.T) {
+
+	mixedref, _ := ioutil.ReadFile("../test_specs/burgershop.openapi.yaml")
+	var rootNode yaml.Node
+	yaml.Unmarshal(mixedref, &rootNode)
+
+	index := index.NewSpecIndex(&rootNode)
+
+	resolver := NewResolver(index)
+	assert.NotNil(t, resolver)
+
+	circ := resolver.Resolve()
+	assert.Len(t, circ, 0)
+
+}
+
+func TestResolver_ResolveComponents_PolyNonCircRef(t *testing.T) {
+
+	yml := `paths:
+  /hey:
+    get:
+      responses:
+        "200":
+          $ref: '#/components/schemas/crackers'
+components:
+  schemas:
+    cheese:
+      description: cheese
+      anyOf:
+        items:
+          $ref: '#/components/schemas/crackers' 
+    crackers:
+      description: crackers
+      allOf:
+       - $ref: '#/components/schemas/tea'
+    tea:
+      description: tea`
+
+	var rootNode yaml.Node
+	yaml.Unmarshal([]byte(yml), &rootNode)
+
+	index := index.NewSpecIndex(&rootNode)
+
+	resolver := NewResolver(index)
+	assert.NotNil(t, resolver)
+
+	circ := resolver.CheckForCircularReferences()
+	assert.Len(t, circ, 0)
+
+}
+
 func TestResolver_ResolveComponents_MixedRef(t *testing.T) {
 
 	mixedref, _ := ioutil.ReadFile("../test_specs/mixedref-burgershop.openapi.yaml")