updated coverage for timeout path lookup

Signed-off-by: quobix <dave@quobix.com>

utils/utils.go

@@ -114,24 +114,17 @@ func FindNodesWithoutDeserializing(node *yaml.Node, jsonPath string) ([]*yaml.No
 
 	// this can spin out, to lets gatekeep it.
 	done := make(chan bool)
-	eChan := make(chan error)
 	var results []*yaml.Node
 	timeout, cancel := context.WithTimeout(context.Background(), 100*time.Millisecond)
 	defer cancel()
-	go func(d chan bool, e chan error) {
+	go func(d chan bool) {
-		var er error
+		results, _ = path.Find(node)
-		results, er = path.Find(node)
-		if er != nil {
-			e <- er
-		}
 		done <- true
-	}(done, eChan)
+	}(done)
 
 	select {
 	case <-done:
 		return results, nil
-	case er := <-eChan:
-		return nil, er
 	case <-timeout.Done():
 		return nil, fmt.Errorf("node lookup timeout exceeded")
 	}

utils/utils_test.go

@@ -913,3 +913,20 @@ func TestDetermineJSONWhitespaceLength_None(t *testing.T) {
 	someBytes := []byte(`{"hello": "world"}`)
 	assert.Equal(t, 0, DetermineWhitespaceLength(string(someBytes)))
 }
+
+func TestTimeoutFind(t *testing.T) {
+	a := &yaml.Node{
+		Value: "chicken",
+	}
+	b := &yaml.Node{
+		Value: "nuggets",
+	}
+
+	// loopy loop.
+	a.Content = append(a.Content, b)
+	b.Content = append(b.Content, a)
+
+	nodes, err := FindNodesWithoutDeserializing(a, "$..nuggets")
+	assert.Error(t, err)
+	assert.Nil(t, nodes)
+}