From 2ee3123bfe925ea0f73f7359c53b85bffa716f33 Mon Sep 17 00:00:00 2001 From: Dave Shanley Date: Sun, 20 Nov 2022 18:11:38 -0500 Subject: [PATCH] Fixed rendering bug with `.Schema()` being called again. Should have known better, almost there with accuracy now. Signed-off-by: Dave Shanley --- datamodel/low/v2/response.go | 2 +- what-changed/model/response.go | 4 +++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/datamodel/low/v2/response.go b/datamodel/low/v2/response.go index 76abd76..632d7d8 100644 --- a/datamodel/low/v2/response.go +++ b/datamodel/low/v2/response.go @@ -76,7 +76,7 @@ func (r *Response) Hash() [32]byte { f = append(f, r.Description.Value) } if !r.Schema.IsEmpty() { - f = append(f, low.GenerateHashString(r.Schema.Value.Schema())) + f = append(f, low.GenerateHashString(r.Schema.Value)) } if !r.Examples.IsEmpty() { for k := range r.Examples.Value.Values { diff --git a/what-changed/model/response.go b/what-changed/model/response.go index 728fb36..176fcc1 100644 --- a/what-changed/model/response.go +++ b/what-changed/model/response.go @@ -160,6 +160,8 @@ func CompareResponse(l, r any) *ResponseChanges { CheckProperties(props) rc.Changes = changes + if rc.TotalChanges() <= 0 { + return nil + } return rc - }