mirror of
https://github.com/LukeHagar/libopenapi.git
synced 2025-12-10 04:20:24 +00:00
Fixed up what-changed tests after model fix.
Now all tests are building the model correctly and everything is passing again, confidence up much higher now.
This commit is contained in:
@@ -4,16 +4,16 @@
|
||||
package model
|
||||
|
||||
import (
|
||||
"github.com/pb33f/libopenapi/datamodel/low"
|
||||
"github.com/pb33f/libopenapi/datamodel/low/v3"
|
||||
"github.com/stretchr/testify/assert"
|
||||
"gopkg.in/yaml.v3"
|
||||
"testing"
|
||||
"github.com/pb33f/libopenapi/datamodel/low"
|
||||
"github.com/pb33f/libopenapi/datamodel/low/v3"
|
||||
"github.com/stretchr/testify/assert"
|
||||
"gopkg.in/yaml.v3"
|
||||
"testing"
|
||||
)
|
||||
|
||||
func TestCompareLinks(t *testing.T) {
|
||||
|
||||
left := `operationId: someOperation
|
||||
left := `operationId: someOperation
|
||||
requestBody: expression-says-what
|
||||
description: a nice link
|
||||
server:
|
||||
@@ -21,29 +21,29 @@ server:
|
||||
parameters:
|
||||
nice: rice`
|
||||
|
||||
right := left
|
||||
right := left
|
||||
|
||||
var lNode, rNode yaml.Node
|
||||
_ = yaml.Unmarshal([]byte(left), &lNode)
|
||||
_ = yaml.Unmarshal([]byte(right), &rNode)
|
||||
var lNode, rNode yaml.Node
|
||||
_ = yaml.Unmarshal([]byte(left), &lNode)
|
||||
_ = yaml.Unmarshal([]byte(right), &rNode)
|
||||
|
||||
// create low level objects
|
||||
var lDoc v3.Link
|
||||
var rDoc v3.Link
|
||||
_ = low.BuildModel(&lNode, &lDoc)
|
||||
_ = low.BuildModel(&rNode, &rDoc)
|
||||
_ = lDoc.Build(lNode.Content[0], nil)
|
||||
_ = rDoc.Build(rNode.Content[0], nil)
|
||||
// create low level objects
|
||||
var lDoc v3.Link
|
||||
var rDoc v3.Link
|
||||
_ = low.BuildModel(lNode.Content[0], &lDoc)
|
||||
_ = low.BuildModel(rNode.Content[0], &rDoc)
|
||||
_ = lDoc.Build(lNode.Content[0], nil)
|
||||
_ = rDoc.Build(rNode.Content[0], nil)
|
||||
|
||||
// compare.
|
||||
extChanges := CompareLinks(&lDoc, &rDoc)
|
||||
assert.Nil(t, extChanges)
|
||||
// compare.
|
||||
extChanges := CompareLinks(&lDoc, &rDoc)
|
||||
assert.Nil(t, extChanges)
|
||||
|
||||
}
|
||||
|
||||
func TestCompareLinks_ModifyExtension(t *testing.T) {
|
||||
|
||||
left := `operationId: someOperation
|
||||
left := `operationId: someOperation
|
||||
requestBody: expression-says-what
|
||||
description: a nice link
|
||||
server:
|
||||
@@ -52,7 +52,7 @@ parameters:
|
||||
nice: rice
|
||||
x-cake: tasty`
|
||||
|
||||
right := `operationId: someOperation
|
||||
right := `operationId: someOperation
|
||||
requestBody: expression-says-what
|
||||
description: a nice link
|
||||
server:
|
||||
@@ -61,29 +61,29 @@ parameters:
|
||||
nice: rice
|
||||
x-cake: very tasty`
|
||||
|
||||
var lNode, rNode yaml.Node
|
||||
_ = yaml.Unmarshal([]byte(left), &lNode)
|
||||
_ = yaml.Unmarshal([]byte(right), &rNode)
|
||||
var lNode, rNode yaml.Node
|
||||
_ = yaml.Unmarshal([]byte(left), &lNode)
|
||||
_ = yaml.Unmarshal([]byte(right), &rNode)
|
||||
|
||||
// create low level objects
|
||||
var lDoc v3.Link
|
||||
var rDoc v3.Link
|
||||
_ = low.BuildModel(&lNode, &lDoc)
|
||||
_ = low.BuildModel(&rNode, &rDoc)
|
||||
_ = lDoc.Build(lNode.Content[0], nil)
|
||||
_ = rDoc.Build(rNode.Content[0], nil)
|
||||
// create low level objects
|
||||
var lDoc v3.Link
|
||||
var rDoc v3.Link
|
||||
_ = low.BuildModel(lNode.Content[0], &lDoc)
|
||||
_ = low.BuildModel(rNode.Content[0], &rDoc)
|
||||
_ = lDoc.Build(lNode.Content[0], nil)
|
||||
_ = rDoc.Build(rNode.Content[0], nil)
|
||||
|
||||
// compare.
|
||||
extChanges := CompareLinks(&lDoc, &rDoc)
|
||||
assert.Equal(t, 1, extChanges.TotalChanges())
|
||||
assert.Equal(t, 0, extChanges.TotalBreakingChanges())
|
||||
assert.Equal(t, Modified, extChanges.ExtensionChanges.Changes[0].ChangeType)
|
||||
// compare.
|
||||
extChanges := CompareLinks(&lDoc, &rDoc)
|
||||
assert.Equal(t, 1, extChanges.TotalChanges())
|
||||
assert.Equal(t, 0, extChanges.TotalBreakingChanges())
|
||||
assert.Equal(t, Modified, extChanges.ExtensionChanges.Changes[0].ChangeType)
|
||||
|
||||
}
|
||||
|
||||
func TestCompareLinks_ModifyServer(t *testing.T) {
|
||||
|
||||
left := `operationId: someOperation
|
||||
left := `operationId: someOperation
|
||||
requestBody: expression-says-what
|
||||
description: a nice link
|
||||
server:
|
||||
@@ -91,7 +91,7 @@ server:
|
||||
parameters:
|
||||
nice: rice`
|
||||
|
||||
right := `operationId: someOperation
|
||||
right := `operationId: someOperation
|
||||
requestBody: expression-says-what
|
||||
description: a nice link
|
||||
server:
|
||||
@@ -99,34 +99,34 @@ server:
|
||||
parameters:
|
||||
nice: rice`
|
||||
|
||||
var lNode, rNode yaml.Node
|
||||
_ = yaml.Unmarshal([]byte(left), &lNode)
|
||||
_ = yaml.Unmarshal([]byte(right), &rNode)
|
||||
var lNode, rNode yaml.Node
|
||||
_ = yaml.Unmarshal([]byte(left), &lNode)
|
||||
_ = yaml.Unmarshal([]byte(right), &rNode)
|
||||
|
||||
// create low level objects
|
||||
var lDoc v3.Link
|
||||
var rDoc v3.Link
|
||||
_ = low.BuildModel(&lNode, &lDoc)
|
||||
_ = low.BuildModel(&rNode, &rDoc)
|
||||
_ = lDoc.Build(lNode.Content[0], nil)
|
||||
_ = rDoc.Build(rNode.Content[0], nil)
|
||||
// create low level objects
|
||||
var lDoc v3.Link
|
||||
var rDoc v3.Link
|
||||
_ = low.BuildModel(lNode.Content[0], &lDoc)
|
||||
_ = low.BuildModel(rNode.Content[0], &rDoc)
|
||||
_ = lDoc.Build(lNode.Content[0], nil)
|
||||
_ = rDoc.Build(rNode.Content[0], nil)
|
||||
|
||||
// compare.
|
||||
extChanges := CompareLinks(&lDoc, &rDoc)
|
||||
assert.Equal(t, 1, extChanges.TotalChanges())
|
||||
assert.Equal(t, 1, extChanges.TotalBreakingChanges())
|
||||
assert.Equal(t, Modified, extChanges.ServerChanges.Changes[0].ChangeType)
|
||||
// compare.
|
||||
extChanges := CompareLinks(&lDoc, &rDoc)
|
||||
assert.Equal(t, 1, extChanges.TotalChanges())
|
||||
assert.Equal(t, 1, extChanges.TotalBreakingChanges())
|
||||
assert.Equal(t, Modified, extChanges.ServerChanges.Changes[0].ChangeType)
|
||||
}
|
||||
|
||||
func TestCompareLinks_AddServer(t *testing.T) {
|
||||
|
||||
left := `operationId: someOperation
|
||||
left := `operationId: someOperation
|
||||
requestBody: expression-says-what
|
||||
description: a nice link
|
||||
parameters:
|
||||
nice: rice`
|
||||
|
||||
right := `operationId: someOperation
|
||||
right := `operationId: someOperation
|
||||
requestBody: expression-says-what
|
||||
description: a nice link
|
||||
server:
|
||||
@@ -134,34 +134,34 @@ server:
|
||||
parameters:
|
||||
nice: rice`
|
||||
|
||||
var lNode, rNode yaml.Node
|
||||
_ = yaml.Unmarshal([]byte(left), &lNode)
|
||||
_ = yaml.Unmarshal([]byte(right), &rNode)
|
||||
var lNode, rNode yaml.Node
|
||||
_ = yaml.Unmarshal([]byte(left), &lNode)
|
||||
_ = yaml.Unmarshal([]byte(right), &rNode)
|
||||
|
||||
// create low level objects
|
||||
var lDoc v3.Link
|
||||
var rDoc v3.Link
|
||||
_ = low.BuildModel(&lNode, &lDoc)
|
||||
_ = low.BuildModel(&rNode, &rDoc)
|
||||
_ = lDoc.Build(lNode.Content[0], nil)
|
||||
_ = rDoc.Build(rNode.Content[0], nil)
|
||||
// create low level objects
|
||||
var lDoc v3.Link
|
||||
var rDoc v3.Link
|
||||
_ = low.BuildModel(lNode.Content[0], &lDoc)
|
||||
_ = low.BuildModel(rNode.Content[0], &rDoc)
|
||||
_ = lDoc.Build(lNode.Content[0], nil)
|
||||
_ = rDoc.Build(rNode.Content[0], nil)
|
||||
|
||||
// compare.
|
||||
extChanges := CompareLinks(&lDoc, &rDoc)
|
||||
assert.Equal(t, 1, extChanges.TotalChanges())
|
||||
assert.Equal(t, 1, extChanges.TotalBreakingChanges())
|
||||
assert.Equal(t, PropertyAdded, extChanges.Changes[0].ChangeType)
|
||||
// compare.
|
||||
extChanges := CompareLinks(&lDoc, &rDoc)
|
||||
assert.Equal(t, 1, extChanges.TotalChanges())
|
||||
assert.Equal(t, 1, extChanges.TotalBreakingChanges())
|
||||
assert.Equal(t, PropertyAdded, extChanges.Changes[0].ChangeType)
|
||||
}
|
||||
|
||||
func TestCompareLinks_RemoveServer(t *testing.T) {
|
||||
|
||||
left := `operationId: someOperation
|
||||
left := `operationId: someOperation
|
||||
requestBody: expression-says-what
|
||||
description: a nice link
|
||||
parameters:
|
||||
nice: rice`
|
||||
|
||||
right := `operationId: someOperation
|
||||
right := `operationId: someOperation
|
||||
requestBody: expression-says-what
|
||||
description: a nice link
|
||||
server:
|
||||
@@ -169,28 +169,28 @@ server:
|
||||
parameters:
|
||||
nice: rice`
|
||||
|
||||
var lNode, rNode yaml.Node
|
||||
_ = yaml.Unmarshal([]byte(left), &lNode)
|
||||
_ = yaml.Unmarshal([]byte(right), &rNode)
|
||||
var lNode, rNode yaml.Node
|
||||
_ = yaml.Unmarshal([]byte(left), &lNode)
|
||||
_ = yaml.Unmarshal([]byte(right), &rNode)
|
||||
|
||||
// create low level objects
|
||||
var lDoc v3.Link
|
||||
var rDoc v3.Link
|
||||
_ = low.BuildModel(&lNode, &lDoc)
|
||||
_ = low.BuildModel(&rNode, &rDoc)
|
||||
_ = lDoc.Build(lNode.Content[0], nil)
|
||||
_ = rDoc.Build(rNode.Content[0], nil)
|
||||
// create low level objects
|
||||
var lDoc v3.Link
|
||||
var rDoc v3.Link
|
||||
_ = low.BuildModel(lNode.Content[0], &lDoc)
|
||||
_ = low.BuildModel(rNode.Content[0], &rDoc)
|
||||
_ = lDoc.Build(lNode.Content[0], nil)
|
||||
_ = rDoc.Build(rNode.Content[0], nil)
|
||||
|
||||
// compare.
|
||||
extChanges := CompareLinks(&rDoc, &lDoc)
|
||||
assert.Equal(t, 1, extChanges.TotalChanges())
|
||||
assert.Equal(t, 1, extChanges.TotalBreakingChanges())
|
||||
assert.Equal(t, PropertyRemoved, extChanges.Changes[0].ChangeType)
|
||||
// compare.
|
||||
extChanges := CompareLinks(&rDoc, &lDoc)
|
||||
assert.Equal(t, 1, extChanges.TotalChanges())
|
||||
assert.Equal(t, 1, extChanges.TotalBreakingChanges())
|
||||
assert.Equal(t, PropertyRemoved, extChanges.Changes[0].ChangeType)
|
||||
}
|
||||
|
||||
func TestCompareLinks_ModifyParam(t *testing.T) {
|
||||
|
||||
left := `operationId: someOperation
|
||||
left := `operationId: someOperation
|
||||
requestBody: expression-says-what
|
||||
description: a nice link
|
||||
server:
|
||||
@@ -198,7 +198,7 @@ server:
|
||||
parameters:
|
||||
nice: cake`
|
||||
|
||||
right := `operationId: someOperation
|
||||
right := `operationId: someOperation
|
||||
requestBody: expression-says-what
|
||||
description: a nice link
|
||||
server:
|
||||
@@ -206,31 +206,31 @@ server:
|
||||
parameters:
|
||||
nice: rice`
|
||||
|
||||
var lNode, rNode yaml.Node
|
||||
_ = yaml.Unmarshal([]byte(left), &lNode)
|
||||
_ = yaml.Unmarshal([]byte(right), &rNode)
|
||||
var lNode, rNode yaml.Node
|
||||
_ = yaml.Unmarshal([]byte(left), &lNode)
|
||||
_ = yaml.Unmarshal([]byte(right), &rNode)
|
||||
|
||||
// create low level objects
|
||||
var lDoc v3.Link
|
||||
var rDoc v3.Link
|
||||
_ = low.BuildModel(&lNode, &lDoc)
|
||||
_ = low.BuildModel(&rNode, &rDoc)
|
||||
_ = lDoc.Build(lNode.Content[0], nil)
|
||||
_ = rDoc.Build(rNode.Content[0], nil)
|
||||
// create low level objects
|
||||
var lDoc v3.Link
|
||||
var rDoc v3.Link
|
||||
_ = low.BuildModel(lNode.Content[0], &lDoc)
|
||||
_ = low.BuildModel(rNode.Content[0], &rDoc)
|
||||
_ = lDoc.Build(lNode.Content[0], nil)
|
||||
_ = rDoc.Build(rNode.Content[0], nil)
|
||||
|
||||
// compare.
|
||||
extChanges := CompareLinks(&lDoc, &rDoc)
|
||||
assert.Equal(t, 1, extChanges.TotalChanges())
|
||||
assert.Equal(t, 1, extChanges.TotalBreakingChanges())
|
||||
assert.Equal(t, Modified, extChanges.Changes[0].ChangeType)
|
||||
assert.Equal(t, "nice", extChanges.Changes[0].NewObject)
|
||||
assert.Equal(t, "cake", extChanges.Changes[0].Original)
|
||||
assert.Equal(t, "rice", extChanges.Changes[0].New)
|
||||
// compare.
|
||||
extChanges := CompareLinks(&lDoc, &rDoc)
|
||||
assert.Equal(t, 1, extChanges.TotalChanges())
|
||||
assert.Equal(t, 1, extChanges.TotalBreakingChanges())
|
||||
assert.Equal(t, Modified, extChanges.Changes[0].ChangeType)
|
||||
assert.Equal(t, "nice", extChanges.Changes[0].NewObject)
|
||||
assert.Equal(t, "cake", extChanges.Changes[0].Original)
|
||||
assert.Equal(t, "rice", extChanges.Changes[0].New)
|
||||
}
|
||||
|
||||
func TestCompareLinks_AddParam(t *testing.T) {
|
||||
|
||||
left := `operationId: someOperation
|
||||
left := `operationId: someOperation
|
||||
requestBody: expression-says-what
|
||||
description: a nice link
|
||||
server:
|
||||
@@ -238,7 +238,7 @@ server:
|
||||
parameters:
|
||||
nice: cake`
|
||||
|
||||
right := `operationId: someOperation
|
||||
right := `operationId: someOperation
|
||||
requestBody: expression-says-what
|
||||
description: a nice link
|
||||
server:
|
||||
@@ -247,30 +247,30 @@ parameters:
|
||||
nice: cake
|
||||
hot: pizza`
|
||||
|
||||
var lNode, rNode yaml.Node
|
||||
_ = yaml.Unmarshal([]byte(left), &lNode)
|
||||
_ = yaml.Unmarshal([]byte(right), &rNode)
|
||||
var lNode, rNode yaml.Node
|
||||
_ = yaml.Unmarshal([]byte(left), &lNode)
|
||||
_ = yaml.Unmarshal([]byte(right), &rNode)
|
||||
|
||||
// create low level objects
|
||||
var lDoc v3.Link
|
||||
var rDoc v3.Link
|
||||
_ = low.BuildModel(&lNode, &lDoc)
|
||||
_ = low.BuildModel(&rNode, &rDoc)
|
||||
_ = lDoc.Build(lNode.Content[0], nil)
|
||||
_ = rDoc.Build(rNode.Content[0], nil)
|
||||
// create low level objects
|
||||
var lDoc v3.Link
|
||||
var rDoc v3.Link
|
||||
_ = low.BuildModel(lNode.Content[0], &lDoc)
|
||||
_ = low.BuildModel(rNode.Content[0], &rDoc)
|
||||
_ = lDoc.Build(lNode.Content[0], nil)
|
||||
_ = rDoc.Build(rNode.Content[0], nil)
|
||||
|
||||
// compare.
|
||||
extChanges := CompareLinks(&lDoc, &rDoc)
|
||||
assert.Equal(t, 1, extChanges.TotalChanges())
|
||||
assert.Equal(t, 1, extChanges.TotalBreakingChanges())
|
||||
assert.Equal(t, ObjectAdded, extChanges.Changes[0].ChangeType)
|
||||
assert.Equal(t, "hot", extChanges.Changes[0].NewObject)
|
||||
assert.Equal(t, "pizza", extChanges.Changes[0].New)
|
||||
// compare.
|
||||
extChanges := CompareLinks(&lDoc, &rDoc)
|
||||
assert.Equal(t, 1, extChanges.TotalChanges())
|
||||
assert.Equal(t, 1, extChanges.TotalBreakingChanges())
|
||||
assert.Equal(t, ObjectAdded, extChanges.Changes[0].ChangeType)
|
||||
assert.Equal(t, "hot", extChanges.Changes[0].NewObject)
|
||||
assert.Equal(t, "pizza", extChanges.Changes[0].New)
|
||||
}
|
||||
|
||||
func TestCompareLinks_RemoveParam(t *testing.T) {
|
||||
|
||||
left := `operationId: someOperation
|
||||
left := `operationId: someOperation
|
||||
requestBody: expression-says-what
|
||||
description: a nice link
|
||||
server:
|
||||
@@ -278,7 +278,7 @@ server:
|
||||
parameters:
|
||||
nice: cake`
|
||||
|
||||
right := `operationId: someOperation
|
||||
right := `operationId: someOperation
|
||||
requestBody: expression-says-what
|
||||
description: a nice link
|
||||
server:
|
||||
@@ -287,23 +287,23 @@ parameters:
|
||||
nice: cake
|
||||
hot: pizza`
|
||||
|
||||
var lNode, rNode yaml.Node
|
||||
_ = yaml.Unmarshal([]byte(left), &lNode)
|
||||
_ = yaml.Unmarshal([]byte(right), &rNode)
|
||||
var lNode, rNode yaml.Node
|
||||
_ = yaml.Unmarshal([]byte(left), &lNode)
|
||||
_ = yaml.Unmarshal([]byte(right), &rNode)
|
||||
|
||||
// create low level objects
|
||||
var lDoc v3.Link
|
||||
var rDoc v3.Link
|
||||
_ = low.BuildModel(&lNode, &lDoc)
|
||||
_ = low.BuildModel(&rNode, &rDoc)
|
||||
_ = lDoc.Build(lNode.Content[0], nil)
|
||||
_ = rDoc.Build(rNode.Content[0], nil)
|
||||
// create low level objects
|
||||
var lDoc v3.Link
|
||||
var rDoc v3.Link
|
||||
_ = low.BuildModel(lNode.Content[0], &lDoc)
|
||||
_ = low.BuildModel(rNode.Content[0], &rDoc)
|
||||
_ = lDoc.Build(lNode.Content[0], nil)
|
||||
_ = rDoc.Build(rNode.Content[0], nil)
|
||||
|
||||
// compare.
|
||||
extChanges := CompareLinks(&rDoc, &lDoc)
|
||||
assert.Equal(t, 1, extChanges.TotalChanges())
|
||||
assert.Equal(t, 1, extChanges.TotalBreakingChanges())
|
||||
assert.Equal(t, ObjectRemoved, extChanges.Changes[0].ChangeType)
|
||||
assert.Equal(t, "hot", extChanges.Changes[0].OriginalObject)
|
||||
// compare.
|
||||
extChanges := CompareLinks(&rDoc, &lDoc)
|
||||
assert.Equal(t, 1, extChanges.TotalChanges())
|
||||
assert.Equal(t, 1, extChanges.TotalBreakingChanges())
|
||||
assert.Equal(t, ObjectRemoved, extChanges.Changes[0].ChangeType)
|
||||
assert.Equal(t, "hot", extChanges.Changes[0].OriginalObject)
|
||||
assert.Equal(t, "pizza", extChanges.Changes[0].Original)
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user