LukeParke/libopenapi
1
0
Fork 0
mirror of https://github.com/LukeHagar/libopenapi.git synced 2025-12-06 20:47:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

Removed the ModifiedAndRemoved and Moved change types from the library.

Browse Source 
They are not useful and will create a lot of noise, The context will always be available, but changes in context will not result in a recorded change.

Signed-off-by: Dave Shanley <dave@quobix.com>
This commit is contained in:
Dave Shanley
2022-10-02 12:38:28 -04:00
parent 60da35e8b5
commit 9775c384f7
7 changed files with 116 additions and 219 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
what-changed/external_docs_test.go
View File

@@ -97,34 +97,24 @@ url: https://quobix.com`
// validate property changes
urlChange := extChanges.Changes[0]
assert.Equal(t, ModifiedAndMoved, urlChange.ChangeType)
assert.Equal(t, Modified, urlChange.ChangeType)
assert.True(t, urlChange.Context.HasChanged())
assert.Equal(t, "https://pb33f.io", urlChange.Original)
assert.Equal(t, "https://quobix.com", urlChange.New)
assert.Equal(t, 1, urlChange.Context.OriginalLine)
assert.Equal(t, 3, urlChange.Context.NewLine)
assert.Equal(t, lowv3.URLLabel, urlChange.Property)
descChange := extChanges.Changes[1]
assert.Equal(t, ModifiedAndMoved, descChange.ChangeType)
assert.Equal(t, Modified, descChange.ChangeType)
assert.True(t, descChange.Context.HasChanged())
assert.Equal(t, "this is another test", descChange.New)
assert.Equal(t, "this is a test", descChange.Original)
assert.Equal(t, 2, descChange.Context.OriginalLine)
assert.Equal(t, 14, descChange.Context.OriginalColumn)
assert.Equal(t, 1, descChange.Context.NewLine)
assert.Equal(t, 14, descChange.Context.NewColumn)
// validate extensions
extChange := extChanges.ExtensionChanges.Changes[0]
assert.Equal(t, ModifiedAndMoved, extChange.ChangeType)
assert.Equal(t, Modified, extChange.ChangeType)
assert.True(t, extChange.Context.HasChanged())
assert.Equal(t, "hiya!", extChange.New)
assert.Equal(t, "hello", extChange.Original)
assert.Equal(t, 3, extChange.Context.OriginalLine)
assert.Equal(t, 12, extChange.Context.OriginalColumn)
assert.Equal(t, 2, extChange.Context.NewLine)
assert.Equal(t, 12, extChange.Context.NewColumn)
}
func TestCompareExternalDocs_Identical(t *testing.T) {
@@ -177,7 +167,7 @@ x-testing: hello`
// compare.
extChanges := CompareExternalDocs(&lDoc, &rDoc)
assert.Equal(t, 2, extChanges.TotalChanges())
assert.Equal(t, 1, extChanges.TotalChanges())
assert.Equal(t, PropertyAdded, extChanges.Changes[0].ChangeType)
}