LukeParke/libopenapi
1
0
Fork 0
mirror of https://github.com/LukeHagar/libopenapi.git synced 2025-12-09 20:47:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

Added CreateChange generic method

Browse Source 
Works pretty well, cuts down on code.
This commit is contained in:
Dave Shanley
2022-09-29 10:09:47 -04:00
parent c47cc15cad
commit a9252c656d
6 changed files with 143 additions and 185 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
what-changed/external_docs.go
View File

@@ -10,7 +10,7 @@ import (
)
type ExternalDocChanges struct {
PropertyChanges
PropertyChanges[*lowbase.ExternalDoc]
ExtensionChanges *ExtensionChanges
}
@@ -23,7 +23,7 @@ func (e *ExternalDocChanges) TotalChanges() int {
}
func CompareExternalDocs(l, r *lowbase.ExternalDoc) *ExternalDocChanges {
var changes []*Change
var changes []*Change[*lowbase.ExternalDoc]
changeType := 0
if l != nil && r != nil && l.URL.Value != r.URL.Value {
changeType = Modified
@@ -31,13 +31,8 @@ func CompareExternalDocs(l, r *lowbase.ExternalDoc) *ExternalDocChanges {
if ctx.HasChanged() {
changeType = ModifiedAndMoved
}
changes = append(changes, &Change{
Context: ctx,
ChangeType: changeType,
Property: lowv3.URLLabel,
Original: l.URL.Value,
New: r.URL.Value,
})
CreateChange[*lowbase.ExternalDoc](&changes, changeType, lowv3.URLLabel, l.URL.ValueNode,
r.URL.ValueNode, false, l, r)
}
if l != nil && r != nil && l.Description.Value != r.Description.Value {
changeType = Modified
@@ -45,13 +40,8 @@ func CompareExternalDocs(l, r *lowbase.ExternalDoc) *ExternalDocChanges {
if ctx.HasChanged() {
changeType = ModifiedAndMoved
}
changes = append(changes, &Change{
Context: ctx,
ChangeType: changeType,
Property: lowv3.DescriptionLabel,
Original: l.Description.Value,
New: r.Description.Value,
})
CreateChange[*lowbase.ExternalDoc](&changes, changeType, lowv3.DescriptionLabel, l.Description.ValueNode,
r.Description.ValueNode, false, l, r)
}
if changeType == 0 {
// no change, return nothing.