cleaning up the last few stragglers

Signed-off-by: quobix <dave@quobix.com>
This commit is contained in:
quobix
2023-11-01 15:15:46 -04:00
parent cb5e498254
commit ce4a60baa8
3 changed files with 1 additions and 14 deletions

View File

@@ -530,10 +530,6 @@ func ExtractMapNoLookupExtensions[PT Buildable[N], N any](
} }
} }
} }
if foundIndex == nil {
foundIndex = idx
}
var n PT = new(N) var n PT = new(N)
err := BuildModel(node, n) err := BuildModel(node, n)
if err != nil { if err != nil {
@@ -553,7 +549,6 @@ func ExtractMapNoLookupExtensions[PT Buildable[N], N any](
}] = ValueReference[PT]{ }] = ValueReference[PT]{
Value: n, Value: n,
ValueNode: node, ValueNode: node,
//IsReference: isReference,
Reference: referenceValue, Reference: referenceValue,
} }
} }

View File

@@ -370,11 +370,7 @@ func CompareDocuments(original, updated Document) (*model.DocumentChanges, []err
if len(uErrs) > 0 { if len(uErrs) > 0 {
errs = append(errs, uErrs...) errs = append(errs, uErrs...)
} }
if v2ModelLeft != nil && v2ModelRight != nil {
return what_changed.CompareSwaggerDocuments(v2ModelLeft.Model.GoLow(), v2ModelRight.Model.GoLow()), errs return what_changed.CompareSwaggerDocuments(v2ModelLeft.Model.GoLow(), v2ModelRight.Model.GoLow()), errs
} else {
return nil, errs
}
} }
return nil, []error{fmt.Errorf("unable to compare documents, one or both documents are not of the same version")} return nil, []error{fmt.Errorf("unable to compare documents, one or both documents are not of the same version")}
} }

View File

@@ -335,10 +335,6 @@ func (resolver *Resolver) isInfiniteCircularDependency(ref *Reference, visitedDe
if initialRef != nil && initialRef.Definition == r.Definition { if initialRef != nil && initialRef.Definition == r.Definition {
return true, visitedDefinitions return true, visitedDefinitions
} }
if visitedDefinitions[r.Definition] {
continue
}
visitedDefinitions[r.Definition] = true visitedDefinitions[r.Definition] = true
ir := initialRef ir := initialRef