From a99a17f4c2c2564c80007d908bdc9e6e413c8731 Mon Sep 17 00:00:00 2001 From: Shivam Meena Date: Sun, 30 Oct 2022 01:23:14 +0530 Subject: [PATCH] Type Issue for Response --- README.md | 3 +-- package.json | 2 +- src/lib/index.ts | 8 ++++---- src/routes/+server.ts | 3 +-- src/routes/component-og/+server.ts | 3 +-- 5 files changed, 8 insertions(+), 11 deletions(-) diff --git a/README.md b/README.md index d414250..19bfed2 100644 --- a/README.md +++ b/README.md @@ -10,7 +10,6 @@ Install `@ethercorps/sveltekit-og`, then use it inside a server endpoint route ( ```typescript // /routes/og/+server.ts import { ImageResponse } from '@ethercorps/sveltekit-og'; -import type { RequestHandler } from './$types'; const template = `
@@ -33,7 +32,7 @@ const template = ` const fontFile = await fetch('https://og-playground.vercel.app/inter-latin-ext-400-normal.woff'); const fontData: ArrayBuffer = await fontFile.arrayBuffer(); -export const GET: RequestHandler = async () => { +export const GET: () => Promise = async () => { return new ImageResponse(template, { height: 250, width: 500, diff --git a/package.json b/package.json index c7eda13..8949e8f 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "@ethercorps/sveltekit-og", - "version": "0.1.3", + "version": "0.1.4", "private": false, "scripts": { "dev": "vite dev", diff --git a/src/lib/index.ts b/src/lib/index.ts index 7909139..65c9dc0 100644 --- a/src/lib/index.ts +++ b/src/lib/index.ts @@ -8,7 +8,7 @@ const resSvgWasm = initWasm(fetch('https://sveltekit-og.ethercorps.io/resvg.wasm const fontFile = await fetch('https://sveltekit-og.ethercorps.io/noto-sans.ttf'); const fontData: ArrayBuffer = await fontFile.arrayBuffer(); -export const ImageResponse = class { +export class ImageResponse { constructor(htmlTemplate: string, optionsByUser: ImageResponseOptions) { const options = Object.assign({ width: 1200, height: 630, debug: !1 }, optionsByUser); const png = new ReadableStream({ @@ -45,14 +45,14 @@ export const ImageResponse = class { statusText: options.statusText }); } -}; +} -export const componentToImageResponse = class { +export class componentToImageResponse { constructor(component: typeof SvelteComponent, props = {}, optionsByUser: ImageResponseOptions) { const htmlTemplate = componentToMarkup(component, props) return new ImageResponse(htmlTemplate, optionsByUser); } -}; +} const componentToMarkup = (component: typeof SvelteComponent, props={}) => { const SvelteRenderedMarkup = (component as any).render(props); diff --git a/src/routes/+server.ts b/src/routes/+server.ts index d39a76d..c5a09d0 100644 --- a/src/routes/+server.ts +++ b/src/routes/+server.ts @@ -1,5 +1,4 @@ import { ImageResponse } from '$lib'; -import type { RequestHandler } from './$types'; const template = `
@@ -24,7 +23,7 @@ const fontFile700 = await fetch('https://og-playground.vercel.app/inter-latin-ex const fontData400: ArrayBuffer = await fontFile400.arrayBuffer(); const fontData700: ArrayBuffer = await fontFile700.arrayBuffer(); -export const GET: RequestHandler = async () => { +export const GET: () => Promise = async () => { return new ImageResponse(template, { height: 250, width: 500, diff --git a/src/routes/component-og/+server.ts b/src/routes/component-og/+server.ts index 9533f6b..40eac01 100644 --- a/src/routes/component-og/+server.ts +++ b/src/routes/component-og/+server.ts @@ -1,12 +1,11 @@ import OG from "./OG.svelte"; import {componentToImageResponse} from "$lib"; -import type {RequestHandler} from "./$types"; const fontFile = await fetch('https://og-playground.vercel.app/inter-latin-ext-700-normal.woff'); const fontData: ArrayBuffer = await fontFile.arrayBuffer(); -export const GET: RequestHandler = async () => { +export const GET:() => Promise= async () => { return new componentToImageResponse(OG, {text: 'Ready to dive in?', spanText: 'Start your free trial today.'}, { height: 250, width: 500,