LukeParke/unicorn-utterances
1
0
Fork 0
mirror of https://github.com/LukeHagar/unicorn-utterances.git synced 2025-12-10 12:57:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

[UwU] Fix invalid <Select> popover IDs (#748)

Browse Source 
- Removes `id`, `aria-labelledby`, and `aria-describedby` attributes
from the props returned from `react-aria` within its `<Popover>`
component
  #741
This commit is contained in:
Corbin Crutchley
2023-10-01 23:29:05 -07:00
committed by GitHub
parent 40cef650ab 6f5f4eb931
commit 7f9d8afe9c
1 changed files with 10 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/components/select/select.tsx
View File

@@ -135,6 +135,11 @@ function ListBox(props: ListBoxProps) {
const { listBoxRef = ref, state } = props;
const { listBoxProps } = useListBox(props, state, listBoxRef);
// As this is inside a portal (within <Popover>), nothing from Preact's useId can be trusted
// ...but nothing should be using these IDs anyway.
listBoxProps["id"] = undefined;
listBoxProps["aria-labelledby"] = undefined;
return (
<ul {...listBoxProps} ref={listBoxRef} class={styles.optionsList}>
{[...state.collection].map((item) => (
@@ -159,6 +164,11 @@ export function Option({ item, state }: OptionProps) {
ref,
);
// As this is inside a portal (within <Popover>), nothing from Preact's useId can be trusted
// ...but nothing should be using these IDs anyway.
optionProps["aria-labelledby"] = undefined;
optionProps["aria-describedby"] = undefined;
return (
<li
{...optionProps}