LukeParke/vercel
1
0
Fork 0
mirror of https://github.com/LukeHagar/vercel.git synced 2025-12-10 12:57:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

[remix] Only add workspace check flag for Yarn v1 (#10364)

Browse Source 
Yarn v2/v3 do not require this flag.
This commit is contained in:
Nathan Rajlich
2023-08-17 12:17:28 -07:00
committed by GitHub
parent 6aa2dc6f51
commit 09174df6cf
2 changed files with 13 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
.changeset/stupid-pumpkins-crash.md Normal file
View File

@@ -0,0 +1,5 @@
---
'@vercel/remix-builder': patch
---
Only add workspace check flag for Yarn v1

9
packages/remix/src/utils.ts
View File

@@ -1,4 +1,5 @@
import semver from 'semver'; import semver from 'semver';
import { execSync } from 'child_process';
import { existsSync, promises as fs } from 'fs'; import { existsSync, promises as fs } from 'fs';
import { basename, dirname, join, relative, resolve, sep } from 'path'; import { basename, dirname, join, relative, resolve, sep } from 'path';
import { pathToRegexp, Key } from 'path-to-regexp'; import { pathToRegexp, Key } from 'path-to-regexp';
@@ -283,10 +284,16 @@ export function addDependencies(
} }
} else { } else {
// 'yarn' // 'yarn'
args.push('add', '--ignore-workspace-root-check'); args.push('add');
if (opts.saveDev) { if (opts.saveDev) {
args.push('--dev'); args.push('--dev');
} }
const yarnVersion = execSync('yarn -v', { encoding: 'utf8' }).trim();
const isYarnV1 = semver.satisfies(yarnVersion, '1');
if (isYarnV1) {
// Ignoring workspace check is only needed on Yarn v1
args.push('--ignore-workspace-root-check');
}
} }
// Don't fail if pnpm is being run at the workspace root // Don't fail if pnpm is being run at the workspace root