LukeParke/vercel
1
0
Fork 0
mirror of https://github.com/LukeHagar/vercel.git synced 2025-12-10 12:57:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

[ruby] fix: HEAD requests (#9436)

Browse Source 
When WEBrick receives `HEAD` requests it discards the body (i.e.
`req.body.nil? => true`), this causes Vercel to throw a
`BODY_NOT_A_STRING_FROM_FUNCTION` since it is expecting the serverless
function to respond with a string in the body.

---------

Co-authored-by: Nathan Rajlich <n@n8.io>
Co-authored-by: Steven <steven@ceriously.com>
This commit is contained in:
Marc Greenstock
2023-02-17 07:41:56 +10:00
committed by GitHub
parent d52d26eaac
commit 1c8b4717e3
3 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
packages/ruby/test/fixtures/01-cowsay/now.json vendored
View File

@@ -1,5 +1,8 @@
{ {
"version": 2, "version": 2,
"builds": [{ "src": "index.rb", "use": "@vercel/ruby" }], "builds": [{ "src": "index.rb", "use": "@vercel/ruby" }],
"probes": [{ "path": "/", "mustContain": "gem:RANDOMNESS_PLACEHOLDER" }] "probes": [
{ "path": "/", "mustContain": "gem:RANDOMNESS_PLACEHOLDER" },
{ "path": "/", "method": "HEAD", "status": 200 }
]
} }

2
packages/ruby/vc_init.rb
View File

@@ -73,7 +73,7 @@ def webrick_handler(httpMethod, path, body, headers)
{ {
:statusCode => res.code.to_i, :statusCode => res.code.to_i,
:headers => res_headers, :headers => res_headers,
:body => res.body, :body => res.body.nil? ? "" : res.body,
} }
end end

2
test/lib/deployment/test-deployment.js
View File

@@ -384,7 +384,7 @@ async function fetchDeploymentUrl(url, opts) {
for (let i = 0; i < 50; i += 1) { for (let i = 0; i < 50; i += 1) {
const resp = await fetch(url, opts); const resp = await fetch(url, opts);
const text = await resp.text(); const text = await resp.text();
if (text && !text.includes('Join Free')) { if (typeof text !== 'undefined' && !text.includes('Join Free')) {
return { resp, text }; return { resp, text };
} }