[tests] Revert "update CI to use node@14 and drop support for node@12 (#7819)" (#7853)

Revert "[tests] update CI to use node@14 and drop support for node@12 (#7819)"

This reverts commit 89b5aad367.

.github/workflows/test-integration-cli.yml

@@ -16,7 +16,7 @@ jobs:
       fail-fast: false
       matrix:
         os: [ubuntu-latest]
-        node: [14]
+        node: [12]
     runs-on: ${{ matrix.os }}
     env:
       TURBO_REMOTE_ONLY: true

api/tsconfig.json

@@ -1,6 +1,6 @@
 {
   "compilerOptions": {
-    "target": "ES2020",
+    "target": "esnext",
     "skipLibCheck": true,
     "strict": false,
     "forceConsistentCasingInFileNames": true,

packages/build-utils/tsconfig.json

@@ -2,7 +2,7 @@
   "compilerOptions": {
     "declaration": true,
     "esModuleInterop": true,
-    "lib": ["ES2020"],
+    "lib": ["esnext"],
     "module": "commonjs",
     "moduleResolution": "node",
     "noEmitOnError": true,
@@ -13,7 +13,7 @@
     "outDir": "./dist",
     "types": ["node", "jest"],
     "strict": true,
-    "target": "ES2020"
+    "target": "es2019"
   },
   "include": ["src/**/*"],
   "exclude": ["node_modules"]

packages/cli/package.json

@@ -40,7 +40,7 @@
     ]
   },
   "engines": {
-    "node": ">= 14"
+    "node": ">= 12"
   },
   "dependencies": {
     "@vercel/build-utils": "3.1.1-canary.0",

packages/cli/tsconfig.json

@@ -5,10 +5,10 @@
     "noFallthroughCasesInSwitch": true,
     "moduleResolution": "node",
     "module": "commonjs",
-    "target": "ES2020",
+    "target": "es2019",
     "esModuleInterop": true,
     "allowJs": true,
-    "lib": ["ES2020"],
+    "lib": ["esnext"],
     "resolveJsonModule": true,
     "sourceMap": true,
     "outDir": "./dist",

packages/client/package.json

@@ -20,7 +20,7 @@
     "test-unit": "yarn test tests/unit.*test.*"
   },
   "engines": {
-    "node": ">= 14"
+    "node": ">= 12"
   },
   "devDependencies": {
     "@types/async-retry": "1.4.1",

packages/client/tsconfig.json

@@ -2,7 +2,7 @@
   "compilerOptions": {
     "declaration": true,
     "esModuleInterop": true,
-    "lib": ["ES2020"],
+    "lib": ["esnext"],
     "module": "commonjs",
     "moduleResolution": "node",
     "outDir": "dist",
@@ -12,7 +12,7 @@
     "noUnusedLocals": true,
     "noUnusedParameters": true,
     "strict": true,
-    "target": "ES2020"
+    "target": "es2019"
   },
   "include": ["./src"]
 }

packages/frameworks/tsconfig.json

@@ -2,7 +2,7 @@
   "compilerOptions": {
     "declaration": true,
     "esModuleInterop": true,
-    "lib": ["ES2020"],
+    "lib": ["esnext"],
     "module": "commonjs",
     "moduleResolution": "node",
     "noEmitOnError": true,
@@ -13,7 +13,7 @@
     "outDir": "./dist",
     "types": ["node", "jest"],
     "strict": true,
-    "target": "ES2020"
+    "target": "esnext"
   },
   "include": ["src/*.ts"],
   "exclude": ["node_modules"]

packages/go/tsconfig.json

@@ -2,7 +2,7 @@
   "compilerOptions": {
     "declaration": false,
     "esModuleInterop": true,
-    "lib": ["ES2020"],
+    "lib": ["esnext"],
     "module": "commonjs",
     "moduleResolution": "node",
     "noEmitOnError": true,
@@ -13,6 +13,6 @@
     "noImplicitThis": false,
     "types": ["node"],
     "strict": true,
-    "target": "ES2020"
+    "target": "es2018"
   }
 }

packages/next/tsconfig.json

@@ -2,8 +2,8 @@
   "compilerOptions": {
     "strict": true,
     "esModuleInterop": true,
-    "lib": ["ES2020"],
+    "lib": ["esnext"],
-    "target": "ES2020",
+    "target": "es2018",
     "module": "commonjs",
     "outDir": "dist",
     "sourceMap": false,

packages/node-bridge/tsconfig.json

@@ -2,7 +2,7 @@
   "compilerOptions": {
     "allowJs": true,
     "checkJs": true,
-    "lib": ["ES2020"],
+    "lib": ["esnext"],
     "noEmit": true,
     "noImplicitReturns": true,
     "strict": true,

packages/node/src/typescript.ts

@@ -450,6 +450,7 @@ export function fixConfig(
   delete config.compilerOptions.tsBuildInfoFile;
   delete config.compilerOptions.incremental;
 
+  // Target esnext output by default (instead of ES3).
   // This will prevent TS from polyfill/downlevel emit.
   if (config.compilerOptions.target === undefined) {
     // See https://github.com/tsconfig/bases/tree/main/bases

packages/node/tsconfig.json

@@ -2,8 +2,8 @@
   "compilerOptions": {
     "strict": true,
     "esModuleInterop": true,
-    "lib": ["ES2020"],
+    "lib": ["esnext"],
-    "target": "ES2020",
+    "target": "es2018",
     "module": "commonjs",
     "outDir": "dist",
     "sourceMap": false,

packages/python/tsconfig.json

@@ -2,7 +2,7 @@
   "compilerOptions": {
     "declaration": true,
     "esModuleInterop": true,
-    "lib": ["ES2020"],
+    "lib": ["esnext"],
     "module": "commonjs",
     "moduleResolution": "node",
     "noEmitOnError": true,
@@ -13,7 +13,7 @@
     "outDir": "dist",
     "types": ["node", "jest"],
     "strict": true,
-    "target": "ES2020"
+    "target": "es2018"
   },
   "include": ["src/**/*"],
   "exclude": ["node_modules"]

packages/redwood/tsconfig.json

@@ -2,7 +2,7 @@
   "compilerOptions": {
     "declaration": false,
     "esModuleInterop": true,
-    "lib": ["ES2020"],
+    "lib": ["esnext"],
     "module": "commonjs",
     "moduleResolution": "node",
     "noEmitOnError": true,
@@ -13,6 +13,6 @@
     "outDir": "dist",
     "types": ["node"],
     "strict": true,
-    "target": "ES2020"
+    "target": "es2019"
   }
 }

packages/remix/tsconfig.json

@@ -2,7 +2,7 @@
   "compilerOptions": {
     "declaration": true,
     "esModuleInterop": true,
-    "lib": ["ES2020"],
+    "lib": ["esnext"],
     "module": "commonjs",
     "moduleResolution": "node",
     "noEmitOnError": true,
@@ -13,7 +13,7 @@
     "outDir": "./dist",
     "types": ["node", "jest"],
     "strict": true,
-    "target": "ES2020",
+    "target": "es2019",
     "sourceMap": true
   },
   "include": ["src/**/*"],

packages/routing-utils/tsconfig.json

@@ -2,8 +2,8 @@
   "compilerOptions": {
     "strict": true,
     "esModuleInterop": true,
-    "lib": ["ES2020"],
+    "lib": ["esnext"],
-    "target": "ES2020",
+    "target": "esnext",
     "module": "commonjs",
     "outDir": "dist",
     "sourceMap": false,

packages/ruby/tsconfig.json

@@ -2,7 +2,7 @@
   "compilerOptions": {
     "declaration": true,
     "esModuleInterop": true,
-    "lib": ["ES2020"],
+    "lib": ["esnext"],
     "module": "commonjs",
     "moduleResolution": "node",
     "noEmitOnError": true,
@@ -12,6 +12,6 @@
     "noUnusedParameters": true,
     "outDir": "dist",
     "strict": true,
-    "target": "ES2020"
+    "target": "esnext"
   }
 }

packages/static-build/tsconfig.json

@@ -2,7 +2,7 @@
   "compilerOptions": {
     "declaration": false,
     "esModuleInterop": true,
-    "lib": ["ES2020"],
+    "lib": ["esnext"],
     "module": "commonjs",
     "moduleResolution": "node",
     "noEmitOnError": true,
@@ -13,7 +13,7 @@
     "outDir": "dist",
     "types": ["node", "jest"],
     "strict": true,
-    "target": "ES2020"
+    "target": "es2018"
   },
   "include": ["src/**/*"],
   "exclude": ["test/fixtures"]

packages/static-config/tsconfig.json

@@ -2,8 +2,8 @@
   "compilerOptions": {
     "strict": true,
     "esModuleInterop": true,
-    "lib": ["ES2020"],
+    "lib": ["esnext"],
-    "target": "ES2020",
+    "target": "es2018",
     "module": "commonjs",
     "outDir": "dist",
     "sourceMap": true,

test/lib/deployment/now-deploy.js

@@ -72,15 +72,7 @@ async function nowDeploy(bodies, randomness, uploadNowJson) {
     if (json.error && json.error.code === 'missing_files')
       throw new Error('Missing files');
     deploymentId = json.id;
-    deploymentUrl = json.url || '';
+    deploymentUrl = json.url;
-
-    if (!deploymentUrl.startsWith('https')) {
-      // if it doesn't look like an absolute URL, fetch will not work
-      console.log(
-        `Warning: deployment (${deploymentId}) returned deployment url of "${deploymentUrl}", which is not absolute. Prepending "https://".`
-      );
-      deploymentUrl = 'https://' + deploymentUrl;
-    }
   }
 
   logWithinTest('id', deploymentId);
@@ -96,9 +88,7 @@ async function nowDeploy(bodies, randomness, uploadNowJson) {
     const { readyState } = deployment;
     if (readyState === 'ERROR') {
       logWithinTest('state is ERROR, throwing');
-      const error = new Error(
+      const error = new Error(`State of https://${deploymentUrl} is ERROR`);
-        `State of https://${deploymentUrl} is ERROR: ${deployment.errorMessage}`
-      );
       error.deployment = deployment;
       throw error;
     }