[now-node] Make "without helpers" config option work as expected in startDevServer() (#4208)

This commit is contained in:
Nathan Rajlich
2020-04-30 10:49:29 -07:00
committed by GitHub
parent 91b9b7f880
commit a1a5e0ef0d
4 changed files with 19 additions and 14 deletions

View File

@@ -39,27 +39,23 @@ function listen(
async function main() {
const entrypoint = process.env.NOW_DEV_ENTRYPOINT;
delete process.env.NOW_DEV_ENTRYPOINT;
if (!entrypoint) {
throw new Error('`NOW_DEV_ENTRYPOINT` must be defined');
}
//const shouldAddHelpers = true;
const config = JSON.parse(process.env.NOW_DEV_CONFIG || '{}');
delete process.env.NOW_DEV_CONFIG;
const shouldAddHelpers = config.helpers !== false;
const entrypointPath = path.join(process.cwd(), entrypoint);
const handler = await import(entrypointPath);
/*
const server = http.createServer((req, res) => {
Promise.resolve(true).then(() => handler.default(req, res)).catch(err => {
console.error('Caught error from HTTP handler:', err);
if (!res.headersSent) {
res.statusCode = 500;
res.end('Internal server error\n');
}
});
});
*/
const server = createServerWithHelpers(handler.default);
const server = shouldAddHelpers
? createServerWithHelpers(handler.default)
: http.createServer(handler.default);
await listen(server, 0, '127.0.0.1');