LukeParke/vercel
1
0
Fork 0
mirror of https://github.com/LukeHagar/vercel.git synced 2025-12-11 04:22:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

Revert "[now-routing-utils] Fix redirect // when cleanUrls and trailingSlash enabled" (#4232)

Browse Source 
Reverts zeit/now#4227

This somehow got merged even though the tests didn't pass. Reverting until it can be merged cleanly.
This commit is contained in:
Steven
2020-05-01 18:59:53 -04:00
committed by GitHub
parent 07c9c0bb6e
commit fe0d762aca
4 changed files with 38 additions and 43 deletions
Download Patch File Download Diff File Expand all files Collapse all files

51
packages/now-cli/test/dev/integration.js
View File

@@ -656,34 +656,29 @@ test(
test(
'[now dev] test cleanUrls and trailingSlash serve correct content',
testFixtureStdio(
'test-clean-urls-trailing-slash',
async testPath => {
await testPath(200, '/', 'Index Page');
await testPath(200, '/about/', 'About Page');
await testPath(200, '/sub/', 'Sub Index Page');
await testPath(200, '/sub/another/', 'Sub Another Page');
await testPath(200, '/style.css', 'body { color: green }');
await testPath(308, '/index.html', 'Redirecting to / (308)', {
Location: '/',
});
await testPath(308, '/about.html', 'Redirecting to /about/ (308)', {
Location: '/about/',
});
await testPath(308, '/sub/index.html', 'Redirecting to /sub/ (308)', {
Location: '/sub/',
});
await testPath(
308,
'/sub/another.html',
'Redirecting to /sub/another/ (308)',
{
Location: '/sub/another/',
}
);
},
{ skipDeploy: true } /* TODO: remove after update routing-utils in prod */
)
testFixtureStdio('test-clean-urls-trailing-slash', async testPath => {
await testPath(200, '/', 'Index Page');
await testPath(200, '/about/', 'About Page');
await testPath(200, '/sub/', 'Sub Index Page');
await testPath(200, '/sub/another/', 'Sub Another Page');
await testPath(200, '/style.css', 'body { color: green }');
//TODO: fix this test so that location is `/` instead of `//`
//await testPath(308, '/index.html', 'Redirecting to / (308)', { Location: '/' });
await testPath(308, '/about.html', 'Redirecting to /about/ (308)', {
Location: '/about/',
});
await testPath(308, '/sub/index.html', 'Redirecting to /sub/ (308)', {
Location: '/sub/',
});
await testPath(
308,
'/sub/another.html',
'Redirecting to /sub/another/ (308)',
{
Location: '/sub/another/',
}
);
})
);
test(