vercel

mirror of https://github.com/LukeHagar/vercel.git synced 2025-12-06 21:07:47 +00:00

Author SHA1 Message Date

Author	SHA1	Message	Date
Ethan Arrowood	253b4fd1d2	[cli][client][error-utils][frameworks][fs-detectors][hydrogen][next][node-bridge][node][redwood][remix][routing-utils][static-config] update @types/node to v14 across repo (#8842 ) ### Related Issues Updates @types/node to the latest version within the v14 major (based on `npm view @types/node`) ``` ❯ npm view @types/node@'>=14.0.0 <15.0.0' version \| tail -1 @types/node@14.18.33 '14.18.33' ``` This PR also fixes the various necessary type changes ### 📋 Checklist <!-- Please keep your PR as a Draft until the checklist is complete --> #### Tests - [ ] The code changed/added as part of this PR has been covered with tests - [ ] All tests pass locally with `yarn test-unit` #### Code Review - [ ] This PR has a concise title and thorough description useful to a reviewer - [ ] Issue from task tracker has a link to this PR	2022-11-04 20:21:13 +00:00
Steven	6e1ee7a7d6	[cli] Fix dev query string merging (#8183 ) Since `vercel dev` performs query string merging with `vercel.json` routes and the requested url, there is sometimes a slight difference between the request that the browser sends and the request that the upstream dev server receives. Most servers treat the query string key with "empty" value the same as undefined value. Meaning, these two URLs should be equivalent because each has empty values: - `http://example.com/src/App.vue?vue&type=style&index=0&lang.css` - `http://example.com/src/App.vue?vue=&type=style&index=0&lang.css=` However, `vite dev` handles these two URLs differently because of [string comparisons](`2289d04af5/packages/plugin-vue/src/handleHotUpdate.ts (L98-L99)`) instead of URL parsing, which causes requests from `vercel dev` to fail. Thus, this PR changes from Node.js native URL parsing to a custom implementation in order to handle this corner case and preserve the difference between `?a=` and `?a`. Ideally this would be [fixed in vite](https://github.com/vitejs/vite/pull/9589), however we might run into other dev servers that also fail in the same way in the future. - Fixes https://github.com/vercel/vercel/issues/7283 - Closes https://github.com/vitejs/vite/pull/9589 - Related to https://github.com/nodejs/node/issues/9500	2022-08-10 11:34:29 -04:00

Ethan Arrowood

253b4fd1d2

[cli][client][error-utils][frameworks][fs-detectors][hydrogen][next][node-bridge][node][redwood][remix][routing-utils][static-config] update @types/node to v14 across repo (#8842 )

### Related Issues

Updates @types/node to the latest version within the v14 major (based on `npm view @types/node`)

```
❯ npm view @types/node@'>=14.0.0 <15.0.0' version | tail -1
@types/node@14.18.33 '14.18.33'
```

This PR also fixes the various necessary type changes

### 📋 Checklist

<!--
  Please keep your PR as a Draft until the checklist is complete
-->

#### Tests

- [ ] The code changed/added as part of this PR has been covered with tests
- [ ] All tests pass locally with `yarn test-unit`

#### Code Review

- [ ] This PR has a concise title and thorough description useful to a reviewer
- [ ] Issue from task tracker has a link to this PR

2022-11-04 20:21:13 +00:00

Steven

6e1ee7a7d6

[cli] Fix dev query string merging (#8183 )

Since `vercel dev` performs query string merging with `vercel.json` routes and the requested url, there is sometimes a slight difference between the request that the browser sends and the request that the upstream dev server receives.

Most servers treat the query string key with "empty" value the same as undefined value. Meaning, these two URLs should be equivalent because each has empty values:

- `http://example.com/src/App.vue?vue&type=style&index=0&lang.css`
- `http://example.com/src/App.vue?vue=&type=style&index=0&lang.css=`

However, `vite dev` handles these two URLs differently because of [string comparisons](2289d04af5/packages/plugin-vue/src/handleHotUpdate.ts (L98-L99)) instead of URL parsing, which causes requests from `vercel dev` to fail. Thus, this PR changes from Node.js native URL parsing to a custom implementation in order to handle this corner case and preserve the difference between `?a=` and `?a`.

Ideally this would be [fixed in vite](https://github.com/vitejs/vite/pull/9589), however we might run into other dev servers that also fail in the same way in the future.

- Fixes https://github.com/vercel/vercel/issues/7283
- Closes https://github.com/vitejs/vite/pull/9589
- Related to https://github.com/nodejs/node/issues/9500

2022-08-10 11:34:29 -04:00

2 Commits