refactor: enhance DockerTerminalModal component for better prop handling

- Removed unnecessary conditional check for containerId in the main dialog open handler.
- Updated Terminal component to ensure serverId and containerId have default values, improving robustness and user experience.
This commit is contained in:
Mauricio Siu
2025-10-05 00:47:50 -06:00
parent c8320da716
commit 586195b5c8

View File

@@ -64,10 +64,6 @@ export const DockerTerminalModal = ({
const [confirmDialogOpen, setConfirmDialogOpen] = useState(false);
const handleMainDialogOpenChange = (open: boolean) => {
if (!open && !containerId) {
setMainDialogOpen(false);
return;
}
if (!open) {
setConfirmDialogOpen(true);
} else {
@@ -131,7 +127,11 @@ export const DockerTerminalModal = ({
</SelectGroup>
</SelectContent>
</Select>
<Terminal serverId={serverId} id="terminal" containerId={containerId} />
<Terminal
serverId={serverId || ""}
id="terminal"
containerId={containerId || "select-a-container"}
/>
<Dialog open={confirmDialogOpen} onOpenChange={setConfirmDialogOpen}>
<DialogContent onEscapeKeyDown={(event) => event.preventDefault()}>
<DialogHeader>