PLTCONN-4069: Refactoring

cmd/connector/conn.go

@@ -7,12 +7,13 @@ import (
 	"log"
 	"os"
 
-	"github.com/sailpoint-oss/sailpoint-cli/internal/client"
-	"github.com/sailpoint-oss/sailpoint-cli/internal/config"
-	"github.com/sailpoint-oss/sailpoint-cli/internal/terminal"
 	"github.com/spf13/cobra"
 	"github.com/spf13/pflag"
 	"gopkg.in/yaml.v2"
+
+	"github.com/sailpoint-oss/sailpoint-cli/internal/client"
+	"github.com/sailpoint-oss/sailpoint-cli/internal/config"
+	"github.com/sailpoint-oss/sailpoint-cli/internal/terminal"
 )
 
 const (
@@ -40,6 +41,7 @@ func NewConnCmd(term terminal.Terminal) *cobra.Command {
 	Client := client.NewSpClient(Config)
 
 	conn.PersistentFlags().StringP("conn-endpoint", "e", connectorsEndpoint, "Override connectors endpoint")
+	conn.PersistentFlags().Int64("read-limit", accountReadLimit, "Set read limit for accounts and entitlements read")
 
 	conn.AddCommand(
 		newConnInitCommand(),

cmd/connector/validate/account_read.go

@@ -27,7 +27,7 @@ var accountReadChecks = []Check{
 				return
 			}
 			if len(accounts) == 0 {
-				res.warnf("no entitlements")
+				res.warnf("no accounts")
 				return
 			}
 
@@ -36,7 +36,7 @@ var accountReadChecks = []Check{
 			})
 			count := int64(0)
 			for _, account := range accounts {
-				if count > readLimit {
+				if count == readLimit {
 					break
 				}
 				acct, _, err := cc.AccountRead(ctx, account.ID(), account.UniqueID(), nil)

cmd/connector/validate/entitlement_read.go

@@ -51,7 +51,7 @@ var entitlementReadChecks = []Check{
 
 			count := int64(0)
 			for _, e := range entitlements {
-				if count > readLimit {
+				if count == readLimit {
 					break
 				}
 				eRead, _, err := cc.EntitlementRead(ctx, e.ID(), e.UniqueID(), "group", nil)