LukeParke/slinky
1
0
Fork 0
mirror of https://github.com/LukeHagar/slinky.git synced 2025-12-06 04:21:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

Refactor argument handling in entrypoint.sh for improved clarity and robustness

Browse Source 
This commit modifies the argument construction in entrypoint.sh to use 'set --' for better handling of optional flags and targets. This change ensures that arguments are properly quoted, accommodating spaces and enhancing overall script reliability. Additionally, debug output is updated to display the constructed command more clearly.
This commit is contained in:
Luke Hagar
2025-11-14 21:00:34 +00:00
parent 241246499d
commit 14b02cbc45
1 changed files with 20 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

34
entrypoint.sh
View File

@@ -13,37 +13,43 @@ elif [ -n "${GITHUB_REPOSITORY:-}" ]; then
[ -n "$COMMIT_SHA" ] && export SLINKY_REPO_BLOB_BASE_URL="https://github.com/${GITHUB_REPOSITORY}/blob/${COMMIT_SHA}"
fi
# Build slinky command arguments
ARGS="check"
# Build slinky command arguments using set -- for proper argument handling
set -- check
# Optional flags
[ -n "${INPUT_CONCURRENCY:-}" ] && ARGS="$ARGS --concurrency ${INPUT_CONCURRENCY}"
[ -n "${INPUT_TIMEOUT:-}" ] && ARGS="$ARGS --timeout ${INPUT_TIMEOUT}"
[ -n "${INPUT_JSON_OUT:-}" ] && ARGS="$ARGS --json-out ${INPUT_JSON_OUT}"
[ -n "${INPUT_MD_OUT:-}" ] && ARGS="$ARGS --md-out ${INPUT_MD_OUT}"
[ -n "${INPUT_REPO_BLOB_BASE:-}" ] && ARGS="$ARGS --repo-blob-base ${INPUT_REPO_BLOB_BASE}"
# Optional flags (properly quoted to handle spaces)
[ -n "${INPUT_CONCURRENCY:-}" ] && set -- "$@" --concurrency "${INPUT_CONCURRENCY}"
[ -n "${INPUT_TIMEOUT:-}" ] && set -- "$@" --timeout "${INPUT_TIMEOUT}"
[ -n "${INPUT_JSON_OUT:-}" ] && set -- "$@" --json-out "${INPUT_JSON_OUT}"
[ -n "${INPUT_MD_OUT:-}" ] && set -- "$@" --md-out "${INPUT_MD_OUT}"
[ -n "${INPUT_REPO_BLOB_BASE:-}" ] && set -- "$@" --repo-blob-base "${INPUT_REPO_BLOB_BASE}"
# Boolean flags with defaults
[ "${INPUT_FAIL_ON_FAILURES:-true}" = "true" ] && ARGS="$ARGS --fail-on-failures=true" || ARGS="$ARGS --fail-on-failures=false"
[ "${INPUT_RESPECT_GITIGNORE:-true}" = "true" ] && ARGS="$ARGS --respect-gitignore=true" || ARGS="$ARGS --respect-gitignore=false"
[ "${INPUT_FAIL_ON_FAILURES:-true}" = "true" ] && set -- "$@" --fail-on-failures=true || set -- "$@" --fail-on-failures=false
[ "${INPUT_RESPECT_GITIGNORE:-true}" = "true" ] && set -- "$@" --respect-gitignore=true || set -- "$@" --respect-gitignore=false
# Add targets (comma-separated glob patterns)
if [ -n "${INPUT_TARGETS:-}" ]; then
IFS=','
for target in $INPUT_TARGETS; do
target=$(echo "$target" | xargs)
[ -n "$target" ] && ARGS="$ARGS $target"
[ -n "$target" ] && set -- "$@" "$target"
done
unset IFS
else
ARGS="$ARGS **/*"
set -- "$@" "**/*"
fi
# Debug output
[ "${ACTIONS_STEP_DEBUG:-}" = "true" ] && printf "::debug:: Running: slinky %s\n" "$ARGS"
if [ "${ACTIONS_STEP_DEBUG:-}" = "true" ]; then
printf "::debug:: Running: slinky"
for arg in "$@"; do
printf " %s" "$arg"
done
printf "\n"
fi
# Execute slinky (crawl repo with glob input, filter via .slinkignore)
slinky $ARGS
slinky "$@"
EXIT_CODE=$?
# Expose outputs