Publish

- @now/bash@0.0.3
 - @now/build-utils@0.4.31
 - @now/cgi@0.0.14
 - @now/go@0.2.11
 - @now/lambda@0.4.8
 - @now/md@0.4.8
 - @now/mdx-deck@0.4.17
 - @now/next@0.0.81
 - @now/node-server@0.4.25
 - @now/node@0.4.27
 - @now/php@0.4.12
 - @now/static-build@0.4.16

.circleci/config.yml

@@ -4,6 +4,8 @@ jobs:
     docker:
       - image: circleci/node:10
     working_directory: ~/repo
+    environment:
+      GOPATH: $HOME/go
     steps:
       - checkout
       - run:
@@ -24,65 +26,17 @@ jobs:
       - run:
           name: Tests
           command: yarn test
-  # publish-canary:
-  #   docker:
-  #     - image: circleci/node:10
-  #   working_directory: ~/repo
-  #   steps:
-  #     - checkout
-  #     - run:
-  #         name: Updating apt-get list
-  #         command: sudo apt-get update
-  #     - run:
-  #         name: Installing the latest version of Go
-  #         command: sudo apt-get install golang-go
-  #     - run: yarn install
-  #     - run: yarn bootstrap
-  #     - run:
-  #         name: Saving Authentication Information
-  #         command: echo "//registry.npmjs.org/:_authToken=$NPM_TOKEN" >> ~/.npmrc
-  #     - run:
-  #         name: Publishing to Canary Channel
-  #         command: yarn run lerna publish from-git --npm-tag canary --yes
-  publish-stable:
-    docker:
-      - image: circleci/node:10
-    working_directory: ~/repo
-    steps:
-      - checkout
       - run:
-          name: Updating apt-get list
-          command: sudo apt-get update
+          name: Potentially save npm token
+          command: "([[ ! -z $NPM_TOKEN ]] && echo \"//registry.npmjs.org/:_authToken=$NPM_TOKEN\" >> ~/.npmrc) || echo \"Did not write npm token\""
       - run:
-          name: Installing the latest version of Go
-          command: sudo apt-get install golang-go
-      - run: yarn install
-      - run: yarn bootstrap
+          name: Potentially publish canary release
+          command: "if ls ~/.npmrc >/dev/null 2>&1 && [[ $(git describe --exact-match 2> /dev/null || :) =~ -canary ]]; then yarn run lerna publish from-git --npm-tag canary --yes; else  echo \"Did not publish\"; fi"
       - run:
-          name: Saving Authentication Information
-          command: echo "//registry.npmjs.org/:_authToken=$NPM_TOKEN" >> ~/.npmrc
-      - run:
-          name: Publishing to Stable Channel
-          command: yarn run lerna publish from-git --yes
+          name: Potentially publish stable release
+          command: "if ls ~/.npmrc >/dev/null 2>&1 && [[ ! $(git describe --exact-match 2> /dev/null || :) =~ -canary ]]; then yarn run lerna publish from-git --yes; else  echo \"Did not publish\"; fi"
 workflows:
   version: 2
-  unscheduled:
+  build-and-deploy:
     jobs:
-      - build:
-          filters:
-            tags:
-              only: /.*/
-      - publish-stable:
-          requires:
-            - build
-          filters:
-            tags:
-              only: /^.*(\d+\.)(\d+\.)(\*|\d+)$/
-            branches:
-              ignore: /.*/
-      # - publish-canary:
-      #     requires:
-      #       - build
-      #     filters:
-      #       tags:
-      #         only: /^.*canary.*($|\b)/
+      - build

README.md

@@ -19,3 +19,9 @@ For the canary channel use:
 ```
 yarn publish-canary
 ```
+
+CircleCI will take care of publishing the updated packages to npm from there.
+
+If for some reason CircleCI fails to publish the npm package, you may do so
+manually by running `npm publish` from the package directory. Make sure to
+include the `--tag canary` parameter if you are publishing a canary release!

jest.config.js

@@ -1,5 +1,4 @@
 module.exports = {
   testEnvironment: 'node',
-  rootDir: 'test',
   collectCoverageFrom: ['packages/**/*.{js,jsx}', '!**/node_modules/**'],
 };

package.json

@@ -1,5 +1,6 @@
 {
   "name": "now-builders",
+  "version": "0.0.0",
   "private": true,
   "license": "MIT",
   "dependencies": {
@@ -30,12 +31,16 @@
     "@types/glob": "^7.1.1",
     "@types/multistream": "^2.1.1",
     "@types/node": "^10.12.8",
+    "buffer-replace": "^1.0.0",
     "eslint": "^5.9.0",
     "eslint-config-airbnb-base": "^13.1.0",
     "eslint-config-prettier": "^3.1.0",
     "eslint-plugin-import": "^2.14.0",
+    "fs-extra": "^7.0.1",
+    "glob": "^7.1.3",
     "jest": "^23.6.0",
     "lint-staged": "^8.0.4",
+    "node-fetch": "^2.3.0",
     "pre-commit": "^1.2.2",
     "prettier": "^1.15.2",
     "typescript": "^3.1.6"

packages/now-bash/.gitignore

@@ -0,0 +1,2 @@
+node_modules
+handler

packages/now-bash/bootstrap

@@ -0,0 +1,14 @@
+#!/bin/bash
+set -euo pipefail
+cd "$LAMBDA_TASK_ROOT"
+
+# Configure `import`
+export IMPORT_CACHE="$LAMBDA_TASK_ROOT/.import-cache"
+export PATH="$IMPORT_CACHE/bin:$PATH"
+
+# Load `import` and runtime
+. "$(which import)"
+. "$IMPORT_CACHE/runtime.sh"
+
+# Load user code and process events in a loop forever
+_lambda_runtime_init

packages/now-bash/builder.sh

@@ -0,0 +1,49 @@
+#!/bin/bash
+set -euo pipefail
+
+# `import` debug logs are always enabled during build
+export IMPORT_DEBUG=1
+
+# Install `import`
+IMPORT_BIN="$IMPORT_CACHE/bin/import"
+mkdir -p "$(dirname "$IMPORT_BIN")"
+curl -sfLS https://import.pw > "$IMPORT_BIN"
+chmod +x "$IMPORT_BIN"
+
+# For now only the entrypoint file is copied into the lambda
+mkdir -p "$(dirname "$ENTRYPOINT")"
+cp "$SRC/$ENTRYPOINT" "$ENTRYPOINT"
+
+# Copy in the runtime
+cp "$BUILDER/runtime.sh" "$IMPORT_CACHE"
+cp "$BUILDER/bootstrap" .
+
+# Load `import`
+. "$(which import)"
+
+# Cache runtime and user dependencies
+echo "Caching imports in \"$ENTRYPOINT\"…"
+. "$IMPORT_CACHE/runtime.sh"
+. "$ENTRYPOINT"
+echo "Done caching imports"
+
+# Run user build script
+if declare -f build > /dev/null; then
+	echo "Running \`build\` function in \"$ENTRYPOINT\"…"
+	build "$@"
+fi
+
+# Ensure the entrypoint defined a `serve` function
+if ! declare -f serve > /dev/null; then
+	echo "ERROR: A \`serve\` function must be defined in \"$ENTRYPOINT\"!" >&2
+	exit 1
+fi
+
+# Show a tree of the final lambda build
+show_tree() {
+	import "static-binaries@0.0.6"
+	static_binaries tree
+	echo "Final lambda file tree:"
+	tree -a .
+}
+IMPORT_DEBUG= IMPORT_CACHE="$(mktemp -d)" show_tree

packages/now-bash/index.js

@@ -0,0 +1,55 @@
+const execa = require('execa');
+const { join } = require('path');
+const snakeCase = require('snake-case');
+const glob = require('@now/build-utils/fs/glob');
+const download = require('@now/build-utils/fs/download');
+const { createLambda } = require('@now/build-utils/lambda');
+const getWritableDirectory = require('@now/build-utils/fs/get-writable-directory');
+
+exports.config = {
+  maxLambdaSize: '10mb',
+};
+
+exports.analyze = ({ files, entrypoint }) => files[entrypoint].digest;
+
+exports.build = async ({ files, entrypoint, config }) => {
+  const srcDir = await getWritableDirectory();
+  const workDir = await getWritableDirectory();
+
+  console.log('downloading files...');
+  await download(files, srcDir);
+
+  const configEnv = Object.keys(config).reduce((o, v) => {
+    o[`IMPORT_${snakeCase(v).toUpperCase()}`] = config[v]; // eslint-disable-line no-param-reassign
+    return o;
+  }, {});
+
+  const IMPORT_CACHE = `${workDir}/.import-cache`;
+  const env = Object.assign({}, process.env, configEnv, {
+    PATH: `${IMPORT_CACHE}/bin:${process.env.PATH}`,
+    IMPORT_CACHE,
+    SRC: srcDir,
+    BUILDER: __dirname,
+    ENTRYPOINT: entrypoint,
+  });
+
+  const builderPath = join(__dirname, 'builder.sh');
+
+  await execa(builderPath, [entrypoint], {
+    env,
+    cwd: workDir,
+  });
+
+  const lambda = await createLambda({
+    files: await glob('**', workDir),
+    handler: entrypoint, // not actually used in `bootstrap`
+    runtime: 'provided',
+    environment: Object.assign({}, configEnv, {
+      SCRIPT_FILENAME: entrypoint,
+    }),
+  });
+
+  return {
+    [entrypoint]: lambda,
+  };
+};

packages/now-bash/package.json

@@ -0,0 +1,22 @@
+{
+  "name": "@now/bash",
+  "version": "0.0.3",
+  "description": "Now 2.0 builder for HTTP endpoints written in Bash",
+  "main": "index.js",
+  "author": "Nathan Rajlich <nate@zeit.co>",
+  "license": "MIT",
+  "files": [
+    "builder.sh",
+    "runtime.sh",
+    "bootstrap",
+    "index.js",
+    "package.json"
+  ],
+  "dependencies": {
+    "execa": "^1.0.0",
+    "snake-case": "^2.1.0"
+  },
+  "peerDependencies": {
+    "@now/build-utils": ">=0.0.1"
+  }
+}

packages/now-bash/runtime.sh

@@ -0,0 +1,115 @@
+import "static-binaries@0.0.6"
+static_binaries jq
+
+# These get reset upon each request
+_STATUS_CODE="$(mktemp)"
+_HEADERS="$(mktemp)"
+
+_lambda_runtime_api() {
+	local endpoint="$1"
+	shift
+	curl -sfLS "http://$AWS_LAMBDA_RUNTIME_API/2018-06-01/runtime/$endpoint" "$@"
+}
+
+_lambda_runtime_init() {
+	# Initialize user code
+	. "$SCRIPT_FILENAME" || {
+		local exit_code="$?"
+		local error
+		error='{"exitCode":'"$exit_code"'}'
+		_lambda_runtime_api "init/error" -X POST -d "$error"
+		exit "$EXIT_CODE"
+	}
+
+	# Process events
+	while true; do _lambda_runtime_next; done
+}
+
+_lambda_runtime_next() {
+	echo 200 > "$_STATUS_CODE"
+	echo '{"content-type":"text/plain; charset=utf8"}' > "$_HEADERS"
+
+	local headers
+	headers="$(mktemp)"
+
+	# Get an event
+	local event
+	event="$(mktemp)"
+	_lambda_runtime_api invocation/next -D "$headers" | jq -r '.body' > "$event"
+
+	local request_id
+	request_id="$(grep -Fi Lambda-Runtime-Aws-Request-Id "$headers" | tr -d '[:space:]' | cut -d: -f2)"
+	echo "Request-Id: $request_id" >&2
+	rm -f "$headers"
+
+	# Execute the handler function from the script
+	local body
+	body="$(mktemp)"
+
+	local exit_code=0
+	REQUEST="$event"
+
+	# Stdin of the `serve` function is the HTTP request body.
+	# Need to use a fifo here instead of bash <() because Lambda
+	# errors with "/dev/fd/63 not found" for some reason :/
+	local stdin
+	stdin="$(mktemp --dry-run)"
+	mkfifo "$stdin"
+	_lambda_runtime_body "$event" > "$stdin" &
+
+	serve "$event" < "$stdin" > "$body" || exit_code="$?"
+	rm -f "$event" "$stdin"
+
+	if [ "$exit_code" -eq 0 ]; then
+		# Send the response
+		local response
+		response="$(jq -cnMr \
+			--arg statusCode "$(cat "$_STATUS_CODE")" \
+			--argjson headers "$(cat "$_HEADERS")" \
+			--arg body "$(base64 --wrap=0 < "$body")" \
+			'{statusCode:$statusCode|tonumber, headers:$headers, encoding:"base64", body:$body}')"
+		rm -f "$body" "$_HEADERS"
+		_lambda_runtime_api "invocation/$request_id/response" -X POST -d "$response"
+	else
+		local error
+		error='{"exitCode":'"$exit_code"'}'
+		_lambda_runtime_api "invocation/$request_id/error" -X POST -d "$error"
+	fi
+}
+
+_lambda_runtime_body() {
+	if [ "$(jq -r '.body | type' < "$1")" = "string" ]; then
+		if [ "$(jq -r '.encoding' < "$1")" = "base64" ]; then
+			jq -r '.body' < "$1" | base64 -d
+		else
+			# assume plain-text body
+			jq -r '.body' < "$1"
+		fi
+	fi
+}
+
+
+# Set the response status code.
+http_response_code() {
+	echo "$1" > "$_STATUS_CODE"
+}
+
+# Sets a response header.
+# Overrides existing header if it has already been set.
+http_response_header() {
+	local name="$1"
+	local value="$2"
+	local tmp
+	tmp="$(mktemp)"
+	jq --arg name "$name" --arg value "$value" '.[$name] = $value' < "$_HEADERS" > "$tmp"
+	mv -f "$tmp" "$_HEADERS"
+}
+
+http_response_redirect() {
+	http_response_code "${2:-302}"
+	http_response_header "location" "$1"
+}
+
+http_response_json() {
+	http_response_header "content-type" "application/json; charset=utf8"
+}

packages/now-bash/yarn.lock

@@ -0,0 +1,146 @@
+# THIS IS AN AUTOGENERATED FILE. DO NOT EDIT THIS FILE DIRECTLY.
+# yarn lockfile v1
+
+
+cross-spawn@^6.0.0:
+  version "6.0.5"
+  resolved "https://registry.yarnpkg.com/cross-spawn/-/cross-spawn-6.0.5.tgz#4a5ec7c64dfae22c3a14124dbacdee846d80cbc4"
+  integrity sha512-eTVLrBSt7fjbDygz805pMnstIs2VTBNkRm0qxZd+M7A5XDdxVRWO5MxGBXZhjY4cqLYLdtrGqRf8mBPmzwSpWQ==
+  dependencies:
+    nice-try "^1.0.4"
+    path-key "^2.0.1"
+    semver "^5.5.0"
+    shebang-command "^1.2.0"
+    which "^1.2.9"
+
+end-of-stream@^1.1.0:
+  version "1.4.1"
+  resolved "https://registry.yarnpkg.com/end-of-stream/-/end-of-stream-1.4.1.tgz#ed29634d19baba463b6ce6b80a37213eab71ec43"
+  integrity sha512-1MkrZNvWTKCaigbn+W15elq2BB/L22nqrSY5DKlo3X6+vclJm8Bb5djXJBmEX6fS3+zCh/F4VBK5Z2KxJt4s2Q==
+  dependencies:
+    once "^1.4.0"
+
+execa@^1.0.0:
+  version "1.0.0"
+  resolved "https://registry.yarnpkg.com/execa/-/execa-1.0.0.tgz#c6236a5bb4df6d6f15e88e7f017798216749ddd8"
+  integrity sha512-adbxcyWV46qiHyvSp50TKt05tB4tK3HcmF7/nxfAdhnox83seTDbwnaqKO4sXRy7roHAIFqJP/Rw/AuEbX61LA==
+  dependencies:
+    cross-spawn "^6.0.0"
+    get-stream "^4.0.0"
+    is-stream "^1.1.0"
+    npm-run-path "^2.0.0"
+    p-finally "^1.0.0"
+    signal-exit "^3.0.0"
+    strip-eof "^1.0.0"
+
+get-stream@^4.0.0:
+  version "4.1.0"
+  resolved "https://registry.yarnpkg.com/get-stream/-/get-stream-4.1.0.tgz#c1b255575f3dc21d59bfc79cd3d2b46b1c3a54b5"
+  integrity sha512-GMat4EJ5161kIy2HevLlr4luNjBgvmj413KaQA7jt4V8B4RDsfpHk7WQ9GVqfYyyx8OS/L66Kox+rJRNklLK7w==
+  dependencies:
+    pump "^3.0.0"
+
+is-stream@^1.1.0:
+  version "1.1.0"
+  resolved "https://registry.yarnpkg.com/is-stream/-/is-stream-1.1.0.tgz#12d4a3dd4e68e0b79ceb8dbc84173ae80d91ca44"
+  integrity sha1-EtSj3U5o4Lec6428hBc66A2RykQ=
+
+isexe@^2.0.0:
+  version "2.0.0"
+  resolved "https://registry.yarnpkg.com/isexe/-/isexe-2.0.0.tgz#e8fbf374dc556ff8947a10dcb0572d633f2cfa10"
+  integrity sha1-6PvzdNxVb/iUehDcsFctYz8s+hA=
+
+lower-case@^1.1.1:
+  version "1.1.4"
+  resolved "https://registry.yarnpkg.com/lower-case/-/lower-case-1.1.4.tgz#9a2cabd1b9e8e0ae993a4bf7d5875c39c42e8eac"
+  integrity sha1-miyr0bno4K6ZOkv31YdcOcQujqw=
+
+nice-try@^1.0.4:
+  version "1.0.5"
+  resolved "https://registry.yarnpkg.com/nice-try/-/nice-try-1.0.5.tgz#a3378a7696ce7d223e88fc9b764bd7ef1089e366"
+  integrity sha512-1nh45deeb5olNY7eX82BkPO7SSxR5SSYJiPTrTdFUVYwAl8CKMA5N9PjTYkHiRjisVcxcQ1HXdLhx2qxxJzLNQ==
+
+no-case@^2.2.0:
+  version "2.3.2"
+  resolved "https://registry.yarnpkg.com/no-case/-/no-case-2.3.2.tgz#60b813396be39b3f1288a4c1ed5d1e7d28b464ac"
+  integrity sha512-rmTZ9kz+f3rCvK2TD1Ue/oZlns7OGoIWP4fc3llxxRXlOkHKoWPPWJOfFYpITabSow43QJbRIoHQXtt10VldyQ==
+  dependencies:
+    lower-case "^1.1.1"
+
+npm-run-path@^2.0.0:
+  version "2.0.2"
+  resolved "https://registry.yarnpkg.com/npm-run-path/-/npm-run-path-2.0.2.tgz#35a9232dfa35d7067b4cb2ddf2357b1871536c5f"
+  integrity sha1-NakjLfo11wZ7TLLd8jV7GHFTbF8=
+  dependencies:
+    path-key "^2.0.0"
+
+once@^1.3.1, once@^1.4.0:
+  version "1.4.0"
+  resolved "https://registry.yarnpkg.com/once/-/once-1.4.0.tgz#583b1aa775961d4b113ac17d9c50baef9dd76bd1"
+  integrity sha1-WDsap3WWHUsROsF9nFC6753Xa9E=
+  dependencies:
+    wrappy "1"
+
+p-finally@^1.0.0:
+  version "1.0.0"
+  resolved "https://registry.yarnpkg.com/p-finally/-/p-finally-1.0.0.tgz#3fbcfb15b899a44123b34b6dcc18b724336a2cae"
+  integrity sha1-P7z7FbiZpEEjs0ttzBi3JDNqLK4=
+
+path-key@^2.0.0, path-key@^2.0.1:
+  version "2.0.1"
+  resolved "https://registry.yarnpkg.com/path-key/-/path-key-2.0.1.tgz#411cadb574c5a140d3a4b1910d40d80cc9f40b40"
+  integrity sha1-QRyttXTFoUDTpLGRDUDYDMn0C0A=
+
+pump@^3.0.0:
+  version "3.0.0"
+  resolved "https://registry.yarnpkg.com/pump/-/pump-3.0.0.tgz#b4a2116815bde2f4e1ea602354e8c75565107a64"
+  integrity sha512-LwZy+p3SFs1Pytd/jYct4wpv49HiYCqd9Rlc5ZVdk0V+8Yzv6jR5Blk3TRmPL1ft69TxP0IMZGJ+WPFU2BFhww==
+  dependencies:
+    end-of-stream "^1.1.0"
+    once "^1.3.1"
+
+semver@^5.5.0:
+  version "5.6.0"
+  resolved "https://registry.yarnpkg.com/semver/-/semver-5.6.0.tgz#7e74256fbaa49c75aa7c7a205cc22799cac80004"
+  integrity sha512-RS9R6R35NYgQn++fkDWaOmqGoj4Ek9gGs+DPxNUZKuwE183xjJroKvyo1IzVFeXvUrvmALy6FWD5xrdJT25gMg==
+
+shebang-command@^1.2.0:
+  version "1.2.0"
+  resolved "https://registry.yarnpkg.com/shebang-command/-/shebang-command-1.2.0.tgz#44aac65b695b03398968c39f363fee5deafdf1ea"
+  integrity sha1-RKrGW2lbAzmJaMOfNj/uXer98eo=
+  dependencies:
+    shebang-regex "^1.0.0"
+
+shebang-regex@^1.0.0:
+  version "1.0.0"
+  resolved "https://registry.yarnpkg.com/shebang-regex/-/shebang-regex-1.0.0.tgz#da42f49740c0b42db2ca9728571cb190c98efea3"
+  integrity sha1-2kL0l0DAtC2yypcoVxyxkMmO/qM=
+
+signal-exit@^3.0.0:
+  version "3.0.2"
+  resolved "https://registry.yarnpkg.com/signal-exit/-/signal-exit-3.0.2.tgz#b5fdc08f1287ea1178628e415e25132b73646c6d"
+  integrity sha1-tf3AjxKH6hF4Yo5BXiUTK3NkbG0=
+
+snake-case@^2.1.0:
+  version "2.1.0"
+  resolved "https://registry.yarnpkg.com/snake-case/-/snake-case-2.1.0.tgz#41bdb1b73f30ec66a04d4e2cad1b76387d4d6d9f"
+  integrity sha1-Qb2xtz8w7GagTU4srRt2OH1NbZ8=
+  dependencies:
+    no-case "^2.2.0"
+
+strip-eof@^1.0.0:
+  version "1.0.0"
+  resolved "https://registry.yarnpkg.com/strip-eof/-/strip-eof-1.0.0.tgz#bb43ff5598a6eb05d89b59fcd129c983313606bf"
+  integrity sha1-u0P/VZim6wXYm1n80SnJgzE2Br8=
+
+which@^1.2.9:
+  version "1.3.1"
+  resolved "https://registry.yarnpkg.com/which/-/which-1.3.1.tgz#a45043d54f5805316da8d62f9f50918d3da70b0a"
+  integrity sha512-HxJdYWq1MTIQbJ3nw0cqssHoTNU267KlrDuGZ1WYlxDStUtKUhOaJmh112/TZmHxxUfuJqPXSOm7tDyas0OSIQ==
+  dependencies:
+    isexe "^2.0.0"
+
+wrappy@1:
+  version "1.0.2"
+  resolved "https://registry.yarnpkg.com/wrappy/-/wrappy-1.0.2.tgz#b5243d8f3ec1aa35f1364605bc0d1036e30ab69f"
+  integrity sha1-tSQ9jz7BqjXxNkYFvA0QNuMKtp8=

packages/now-build-utils/.npmignore

@@ -0,0 +1 @@
+/test

packages/now-build-utils/fs/bootstrap-yarn.js

@@ -0,0 +1,83 @@
+const MemoryFileSystem = require('memory-fs');
+const fs = require('fs');
+const path = require('path');
+const { spawnSync } = require('child_process');
+
+const yarnPath = spawnSync('which', ['yarn'])
+  .stdout.toString()
+  .trim();
+
+const cachePath = spawnSync(yarnPath, ['cache', 'dir'])
+  .stdout.toString()
+  .trim();
+
+spawnSync(yarnPath, ['cache', 'clean']);
+const vfs = new MemoryFileSystem();
+
+function isOutsideCachePath(filename) {
+  const relative = path.relative(cachePath, filename);
+  return relative.startsWith('..');
+}
+
+const saveCreateWriteStream = fs.createWriteStream;
+fs.createWriteStream = (...args) => {
+  const filename = args[0];
+  if (isOutsideCachePath(filename)) {
+    return saveCreateWriteStream.call(fs, ...args);
+  }
+
+  vfs.mkdirpSync(path.dirname(filename));
+  fs.writeFileSync(filename, Buffer.alloc(0));
+  const stream = vfs.createWriteStream(...args);
+
+  stream.on('finish', () => {
+    setTimeout(() => {
+      stream.emit('close');
+    });
+  });
+
+  return stream;
+};
+
+const saveReadFile = fs.readFile;
+fs.readFile = (...args) => {
+  const filename = args[0];
+  if (isOutsideCachePath(filename)) {
+    return saveReadFile.call(fs, ...args);
+  }
+
+  const callback = args[args.length - 1];
+  return vfs.readFile(...args.slice(0, -1), (error, result) => {
+    if (error) {
+      saveReadFile.call(fs, ...args);
+      return;
+    }
+
+    callback(error, result);
+  });
+};
+
+const saveCopyFile = fs.copyFile;
+fs.copyFile = (...args) => {
+  const src = args[0];
+  if (isOutsideCachePath(src)) {
+    return saveCopyFile.call(fs, ...args);
+  }
+
+  const dest = args[1];
+  const callback = args[args.length - 1];
+  const buffer = vfs.readFileSync(src);
+  return fs.writeFile(dest, buffer, callback);
+};
+
+const saveWriteFile = fs.writeFile;
+fs.writeFile = (...args) => {
+  const filename = args[0];
+  if (isOutsideCachePath(filename)) {
+    return saveWriteFile.call(fs, ...args);
+  }
+
+  return vfs.writeFile(...args);
+};
+
+require(yarnPath);

packages/now-build-utils/fs/run-user-scripts.js

@@ -1,3 +1,4 @@
+const assert = require('assert');
 const fs = require('fs-extra');
 const path = require('path');
 const { spawn } = require('child_process');
@@ -13,22 +14,34 @@ function spawnAsync(command, args, cwd) {
 }
 
 async function runShellScript(fsPath) {
+  assert(path.isAbsolute(fsPath));
   const destPath = path.dirname(fsPath);
   await spawnAsync(`./${path.basename(fsPath)}`, [], destPath);
   return true;
 }
 
-async function shouldUseNpm(destPath) {
+async function scanParentDirs(destPath, scriptName) {
+  assert(path.isAbsolute(destPath));
+
+  let hasScript = false;
+  let hasPackageLockJson = false;
   let currentDestPath = destPath;
+
   // eslint-disable-next-line no-constant-condition
   while (true) {
+    const packageJsonPath = path.join(currentDestPath, 'package.json');
     // eslint-disable-next-line no-await-in-loop
-    if (await fs.exists(path.join(currentDestPath, 'package.json'))) {
+    if (await fs.exists(packageJsonPath)) {
       // eslint-disable-next-line no-await-in-loop
-      if (await fs.exists(path.join(currentDestPath, 'package-lock.json'))) {
-        return true;
-      }
-      return false;
+      const packageJson = JSON.parse(await fs.readFile(packageJsonPath));
+      hasScript = Boolean(
+        packageJson.scripts && packageJson.scripts[scriptName],
+      );
+      // eslint-disable-next-line no-await-in-loop
+      hasPackageLockJson = await fs.exists(
+        path.join(currentDestPath, 'package-lock.json'),
+      );
+      break;
     }
 
     const newDestPath = path.dirname(currentDestPath);
@@ -36,16 +49,29 @@ async function shouldUseNpm(destPath) {
     currentDestPath = newDestPath;
   }
 
-  return false;
+  return { hasScript, hasPackageLockJson };
 }
 
 async function runNpmInstall(destPath, args = []) {
+  assert(path.isAbsolute(destPath));
+
   let commandArgs = args;
   console.log(`installing to ${destPath}`);
-  if (await shouldUseNpm(destPath)) {
+  const { hasPackageLockJson } = await scanParentDirs(destPath);
+
+  if (hasPackageLockJson) {
     commandArgs = args.filter(a => a !== '--prefer-offline');
     await spawnAsync('npm', ['install'].concat(commandArgs), destPath);
     await spawnAsync('npm', ['cache', 'clean', '--force'], destPath);
+  } else if (process.env.AWS_EXECUTION_ENV) {
+    console.log('using memory-fs for yarn cache');
+    await spawnAsync(
+      'node',
+      [path.join(__dirname, 'bootstrap-yarn.js'), '--cwd', destPath].concat(
+        commandArgs,
+      ),
+      destPath,
+    );
   } else {
     await spawnAsync('yarn', ['--cwd', destPath].concat(commandArgs), destPath);
     await spawnAsync('yarn', ['cache', 'clean'], destPath);
@@ -53,21 +79,19 @@ async function runNpmInstall(destPath, args = []) {
 }
 
 async function runPackageJsonScript(destPath, scriptName) {
-  try {
-    if (await shouldUseNpm(destPath)) {
-      console.log(`running "npm run ${scriptName}"`);
-      await spawnAsync('npm', ['run', scriptName], destPath);
-    } else {
-      console.log(`running "yarn run ${scriptName}"`);
-      await spawnAsync(
-        'yarn',
-        ['--cwd', destPath, 'run', scriptName],
-        destPath,
-      );
-    }
-  } catch (error) {
-    console.log(error.message);
-    return false;
+  assert(path.isAbsolute(destPath));
+  const { hasScript, hasPackageLockJson } = await scanParentDirs(
+    destPath,
+    scriptName,
+  );
+  if (!hasScript) return false;
+
+  if (hasPackageLockJson) {
+    console.log(`running "npm run ${scriptName}"`);
+    await spawnAsync('npm', ['run', scriptName], destPath);
+  } else {
+    console.log(`running "yarn run ${scriptName}"`);
+    await spawnAsync('yarn', ['--cwd', destPath, 'run', scriptName], destPath);
   }
 
   return true;

packages/now-build-utils/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@now/build-utils",
-  "version": "0.4.29",
+  "version": "0.4.31",
   "dependencies": {
     "async-retry": "1.2.3",
     "async-sema": "2.1.4",
@@ -8,8 +8,12 @@
     "fs-extra": "7.0.0",
     "glob": "7.1.3",
     "into-stream": "4.0.0",
+    "memory-fs": "0.4.1",
     "multistream": "2.1.1",
     "node-fetch": "2.2.0",
     "yazl": "2.4.3"
+  },
+  "scripts": {
+    "test": "jest"
   }
 }

packages/now-build-utils/test/fixtures/08-yarn-npm/now.json

@@ -0,0 +1,11 @@
+{
+  "version": 2,
+  "builds": [
+    { "src": "with-npm/index.js", "use": "@now/node" },
+    { "src": "with-yarn/index.js", "use": "@now/node" }
+  ],
+  "probes": [
+    { "path": "/with-npm", "mustContain": "npm:RANDOMNESS_PLACEHOLDER" },
+    { "path": "/with-yarn", "mustContain": "yarn:RANDOMNESS_PLACEHOLDER" }
+  ]
+}

packages/now-build-utils/test/fixtures/08-yarn-npm/with-npm/must-be-npm.js

@@ -0,0 +1,14 @@
+const fs = require('fs');
+const path = require('path');
+
+const execpath = path.basename(process.env.npm_execpath);
+console.log('execpath', execpath);
+
+if (execpath === 'npm-cli.js') {
+  fs.writeFileSync(
+    'index.js',
+    'module.exports = (_, resp) => resp.end("npm:RANDOMNESS_PLACEHOLDER");',
+  );
+} else {
+  throw new Error('npm is expected');
+}

packages/now-build-utils/test/fixtures/08-yarn-npm/with-npm/package-lock.json

@@ -0,0 +1,3 @@
+{
+  "lockfileVersion": 1
+}

packages/now-build-utils/test/fixtures/08-yarn-npm/with-npm/package.json

@@ -0,0 +1,5 @@
+{
+  "scripts": {
+    "now-build": "node must-be-npm.js"
+  }
+}

packages/now-build-utils/test/fixtures/08-yarn-npm/with-yarn/must-be-yarn.js

@@ -0,0 +1,14 @@
+const fs = require('fs');
+const path = require('path');
+
+const execpath = path.basename(process.env.npm_execpath);
+console.log('execpath', execpath);
+
+if (execpath === 'yarn.js' || execpath === 'yarn') {
+  fs.writeFileSync(
+    'index.js',
+    'module.exports = (_, resp) => resp.end("yarn:RANDOMNESS_PLACEHOLDER");',
+  );
+} else {
+  throw new Error('yarn is expected');
+}

packages/now-build-utils/test/fixtures/08-yarn-npm/with-yarn/package.json

@@ -0,0 +1,5 @@
+{
+  "scripts": {
+    "now-build": "node must-be-yarn.js"
+  }
+}

packages/now-build-utils/test/test.js

@@ -0,0 +1,63 @@
+/* global beforeAll, expect, it, jest */
+const fs = require('fs');
+const path = require('path');
+
+const {
+  packAndDeploy,
+  testDeployment,
+} = require('../../../test/lib/deployment/test-deployment.js');
+
+jest.setTimeout(2 * 60 * 1000);
+const builderUrl = '@canary';
+let buildUtilsUrl;
+
+beforeAll(async () => {
+  const buildUtilsPath = path.resolve(__dirname, '..');
+  buildUtilsUrl = await packAndDeploy(buildUtilsPath);
+  console.log('buildUtilsUrl', buildUtilsUrl);
+});
+
+// own fixtures
+
+const fixturesPath = path.resolve(__dirname, 'fixtures');
+
+// eslint-disable-next-line no-restricted-syntax
+for (const fixture of fs.readdirSync(fixturesPath)) {
+  // eslint-disable-next-line no-loop-func
+  it(`should build ${fixture}`, async () => {
+    await expect(
+      testDeployment(
+        { builderUrl, buildUtilsUrl },
+        path.join(fixturesPath, fixture),
+      ),
+    ).resolves.toBeDefined();
+  });
+}
+
+// few foreign tests
+
+const buildersToTestWith = ['now-node-server', 'now-static-build'];
+
+// eslint-disable-next-line no-restricted-syntax
+for (const builder of buildersToTestWith) {
+  const fixturesPath2 = path.resolve(
+    __dirname,
+    `../../${builder}/test/fixtures`,
+  );
+
+  // eslint-disable-next-line no-restricted-syntax
+  for (const fixture of fs.readdirSync(fixturesPath2)) {
+    // don't run all foreign fixtures, just some
+    if (['01-cowsay', '03-env-vars'].includes(fixture)) {
+      // eslint-disable-next-line no-loop-func
+      it(`should build ${builder}/${fixture}`, async () => {
+        await expect(
+          testDeployment(
+            { builderUrl, buildUtilsUrl },
+            path.join(fixturesPath2, fixture),
+          ),
+        ).resolves.toBeDefined();
+      });
+    }
+  }
+}

packages/now-cgi/build.sh

@@ -1,4 +1,7 @@
 #!/usr/bin/env bash
 export GOOS=linux
 export GOARCH=amd64
+export GOPATH=$HOME/go
+go get github.com/aws/aws-lambda-go/events
+go get github.com/aws/aws-lambda-go/lambda
 go build -o handler main.go

packages/now-cgi/main.go

@@ -1,152 +1,36 @@
 package main
 
 import (
-	"os"
-	"fmt"
-	"net"
-	"strings"
-	"io/ioutil"
+	now "../../utils/go/bridge"
 	"net/http"
 	"net/http/cgi"
+	"os"
 	"path/filepath"
-	"encoding/json"
-	b64 "encoding/base64"
-	"github.com/aws/aws-lambda-go/events"
-	"github.com/aws/aws-lambda-go/lambda"
 )
 
-type Request struct {
-	Host     string            `json:"host"`
-	Path     string            `json:"path"`
-	Method   string            `json:"method"`
-	Headers  map[string]string `json:"headers"`
-	Encoding string            `json:"encoding,omitempty"`
-	Body     string            `json:"body"`
-}
-
-type Response struct {
-	StatusCode int               `json:"statusCode"`
-	Headers    map[string]string `json:"headers"`
-	Encoding   string            `json:"encoding,omitemtpy"`
-	Body       string            `json:"body"`
-}
-
-type ResponseError struct {
-	Code    string `json:"code"`
-	Message string `json:"message"`
-}
-
-type ResponseErrorWrapper struct {
-	Error ResponseError `json:"error"`
-}
-
 type CgiHandler struct {
 	http.Handler
 	Dir    string
 	Script string
 }
 
-func createErrorResponse(message string, code string, statusCode int) (Response, error) {
-	obj := ResponseErrorWrapper{
-		Error: ResponseError{
-			Code:    code,
-			Message: message,
-		},
-	}
-
-	body, _ := json.Marshal(obj)
-
-	return Response{
-		StatusCode: statusCode,
-		Headers: map[string]string{
-			"Content-Type": "application/json",
-		},
-		Body: string(body),
-	}, nil
-}
-
 func (h *CgiHandler) ServeHTTP(w http.ResponseWriter, r *http.Request) {
-	cgih := cgi.Handler{
+	handler := cgi.Handler{
 		Path: h.Script,
 		Root: "/" + h.Script,
-		Dir: h.Dir,
-		Env: []string{"SERVER_PORT=443"},
+		Dir:  h.Dir,
+		Env: []string{
+			"HTTPS=on",
+			"SERVER_PORT=443",
+			"SERVER_SOFTWARE=@now/cgi",
+		},
 	}
-	cgih.ServeHTTP(w, r)
+	handler.ServeHTTP(w, r)
 }
 
 func main() {
-	l, err := net.Listen("tcp", ":0")
-	if err != nil {
-		panic(err)
-	}
-
 	workdir, _ := filepath.Abs(".")
 	script := os.Getenv("SCRIPT_FILENAME")
-	h := &CgiHandler{nil, workdir, script}
-
-	http.Handle("/", h)
-	go http.Serve(l, nil)
-
-	handler := func(_req events.APIGatewayProxyRequest) (Response, error) {
-		var req Request
-
-		err := json.Unmarshal([]byte(_req.Body), &req)
-
-		if err != nil {
-			fmt.Println(err)
-			return createErrorResponse("Invalid payload", "bad_request", 400)
-		}
-
-		if req.Encoding == "base64" {
-			decoded, _ := b64.StdEncoding.DecodeString(req.Body)
-			req.Body = string(decoded)
-		}
-
-		url := "http://" + l.Addr().String() + req.Path
-
-		internalReq, err := http.NewRequest(req.Method, url, strings.NewReader(req.Body))
-		if err != nil {
-			fmt.Println(err)
-			return createErrorResponse("Bad gateway internal req failed", "bad_gateway", 502)
-		}
-
-		for k, v := range req.Headers {
-			internalReq.Header.Add(k, v)
-			if strings.ToLower(k) == "host" {
-				internalReq.Host = v
-			}
-		}
-
-		client := &http.Client{}
-		internalRes, err := client.Do(internalReq)
-		if err != nil {
-			fmt.Println(err)
-			return createErrorResponse("Bad gateway internal req Do failed", "bad_gateway", 502)
-		}
-		defer internalRes.Body.Close()
-
-		resHeaders := make(map[string]string, len(internalRes.Header))
-		for k, v := range internalRes.Header {
-			// FIXME: support multiple values via concatenating with ','
-			// see RFC 7230, section 3.2.2
-			resHeaders[k] = v[0]
-		}
-
-		bodyBytes, err := ioutil.ReadAll(internalRes.Body)
-		if err != nil {
-			return createErrorResponse("Bad gateway ReadAll bytes from response failed", "bad_gateway", 502)
-		}
-
-		resBody := b64.StdEncoding.EncodeToString(bodyBytes)
-
-		return Response{
-			StatusCode: internalRes.StatusCode,
-			Headers:    resHeaders,
-			Encoding:   "base64",
-			Body:       resBody,
-		}, nil
-	}
-
-	lambda.Start(handler)
+	handler := &CgiHandler{nil, workdir, script}
+	now.Start(handler)
 }

packages/now-cgi/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@now/cgi",
-  "version": "0.0.12",
+  "version": "0.0.14",
   "scripts": {
     "test": "best -I test/*.js",
     "prepublish": "./build.sh"

packages/now-go/.gitignore

@@ -1,3 +1,4 @@
 node_modules
 *.log
+launcher
 bin

packages/now-go/index.js

@@ -9,7 +9,7 @@ const downloadGit = require('lambda-git');
 const glob = require('@now/build-utils/fs/glob.js');
 const downloadGoBin = require('./download-go-bin');
 
-// creates a `$GOPATH` direcotry tree, as per
+// creates a `$GOPATH` directory tree, as per
 // `go help gopath`'s instructions.
 // without this, Go won't recognize the `$GOPATH`
 async function createGoPathTree(goPath) {

packages/now-go/main.go

@@ -1,140 +1,10 @@
 package main
 
 import (
-	b64 "encoding/base64"
-	"encoding/json"
-	"fmt"
-	"github.com/aws/aws-lambda-go/events"
-	"github.com/aws/aws-lambda-go/lambda"
-	"io/ioutil"
-	"net"
+	now "../../utils/go/bridge"
 	"net/http"
-	"strings"
 )
 
-type Request struct {
-	Host     string            `json:"host"`
-	Path     string            `json:"path"`
-	Method   string            `json`
-	Headers  map[string]string `json:"headers"`
-	Encoding string            `json"encoding,omitempty"`
-	Body     string            `json:"body"`
-}
-
-type Response struct {
-	StatusCode int               `json:"statusCode"`
-	Headers    map[string]string `json:"headers"`
-	Encoding   string            `json:"encoding,omitemtpy"`
-	Body       string            `json:"body"`
-}
-
-type ResponseError struct {
-	Code    string `json:"code"`
-	Message string `json:"message"`
-}
-
-type ResponseErrorWrapper struct {
-	Error ResponseError `json:"error"`
-}
-
-func createErrorResponse(message string, code string, statusCode int) (Response, error) {
-	obj := ResponseErrorWrapper{
-		Error: ResponseError{
-			Code:    code,
-			Message: message,
-		},
-	}
-
-	body, _ := json.Marshal(obj)
-
-	return Response{
-		StatusCode: statusCode,
-		Headers: map[string]string{
-			"Content-Type": "application/json",
-		},
-		Body: string(body),
-	}, nil
-}
-
 func main() {
-	l, err := net.Listen("tcp", ":0")
-	if err != nil {
-		panic(err)
-	}
-
-	http.HandleFunc("/", __NOW_HANDLER_FUNC_NAME)
-	go http.Serve(l, nil)
-
-	handler := func(_req events.APIGatewayProxyRequest) (Response, error) {
-		var req Request
-
-		err := json.Unmarshal([]byte(_req.Body), &req)
-
-		if err != nil {
-			fmt.Println(err)
-			return createErrorResponse("Invalid payload", "bad_request", 400)
-		}
-
-		if req.Encoding == "base64" {
-			decoded, _ := b64.StdEncoding.DecodeString(req.Body)
-			req.Body = string(decoded)
-		}
-
-		url := "http://" + l.Addr().String() + req.Path
-
-		internalReq, err := http.NewRequest(req.Method, url, strings.NewReader(req.Body))
-		if err != nil {
-			fmt.Println(err)
-			return createErrorResponse("Bad gateway", "bad_gateway", 502)
-		}
-
-		for k, v := range req.Headers {
-			internalReq.Header.Add(k, v)
-			if strings.ToLower(k) == "host" {
-				req.Host = v
-			}
-		}
-
-		client := &http.Client{}
-		internalRes, err := client.Do(internalReq)
-		if err != nil {
-			fmt.Println(err)
-			return createErrorResponse("Bad gateway", "bad_gateway", 502)
-		}
-		defer internalRes.Body.Close()
-
-		resHeaders := make(map[string]string, len(internalRes.Header))
-		var resEncoding string
-		for k, v := range internalRes.Header {
-			// FIXME: support multiple values via concatenating with ','
-			// see RFC 7230, section 3.2.2
-			if strings.ToLower(k) == "x-now-response-encoding" {
-				// we don't want to send this header down
-				resEncoding = v[0]
-			} else {
-				resHeaders[k] = v[0]
-			}
-		}
-
-		bodyBytes, err := ioutil.ReadAll(internalRes.Body)
-		if err != nil {
-			return createErrorResponse("Bad gateway", "bad_gateway", 502)
-		}
-
-		var resBody string
-		if resEncoding == "base64" {
-			resBody = b64.StdEncoding.EncodeToString(bodyBytes)
-		} else {
-			resBody = string(bodyBytes)
-		}
-
-		return Response{
-			StatusCode: internalRes.StatusCode,
-			Headers:    resHeaders,
-			Encoding:   resEncoding,
-			Body:       resBody,
-		}, nil
-	}
-
-	lambda.Start(handler)
+	now.Start(http.HandlerFunc(__NOW_HANDLER_FUNC_NAME))
 }

packages/now-go/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@now/go",
-  "version": "0.2.9",
+  "version": "0.2.11",
   "scripts": {
     "test": "best -I test/*.js",
     "prepublish": "./build.sh"

packages/now-html-minifier/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@now/html-minifier",
-  "version": "1.0.5",
+  "version": "1.0.6",
   "dependencies": {
     "html-minifier": "3.5.21"
   },

packages/now-lambda/.npmignore

@@ -0,0 +1 @@
+/test

packages/now-lambda/package.json

@@ -1,7 +1,10 @@
 {
   "name": "@now/lambda",
-  "version": "0.4.6",
+  "version": "0.4.8",
   "peerDependencies": {
     "@now/build-utils": ">=0.0.1"
+  },
+  "scripts": {
+    "test": "jest"
   }
 }

packages/now-lambda/test/fixtures/01-cowsay/now.json

@@ -0,0 +1,11 @@
+{
+  "version": 2,
+  "builds": [
+    { "src": "index.zip", "use": "@now/lambda", "config": { "handler": "index.handler", "runtime": "nodejs8.10" } },
+    { "src": "subdirectory/index.zip", "use": "@now/lambda", "config": { "handler": "index.handler", "runtime": "nodejs8.10" } }
+  ],
+  "probes": [
+    { "path": "/", "mustContain": "cow:NO_REPLACE_TO_AVOID_CRC_MISMATCH" },
+    { "path": "/subdirectory/", "mustContain": "yoda:NO_REPLACE_TO_AVOID_CRC_MISMATCH" }
+  ]
+}

packages/now-lambda/test/test.js

@@ -0,0 +1,33 @@
+/* global beforeAll, expect, it, jest */
+const fs = require('fs');
+const path = require('path');
+
+const {
+  packAndDeploy,
+  testDeployment,
+} = require('../../../test/lib/deployment/test-deployment.js');
+
+jest.setTimeout(2 * 60 * 1000);
+const buildUtilsUrl = '@canary';
+let builderUrl;
+
+beforeAll(async () => {
+  const builderPath = path.resolve(__dirname, '..');
+  builderUrl = await packAndDeploy(builderPath);
+  console.log('builderUrl', builderUrl);
+});
+
+const fixturesPath = path.resolve(__dirname, 'fixtures');
+
+// eslint-disable-next-line no-restricted-syntax
+for (const fixture of fs.readdirSync(fixturesPath)) {
+  // eslint-disable-next-line no-loop-func
+  it(`should build ${fixture}`, async () => {
+    await expect(
+      testDeployment(
+        { builderUrl, buildUtilsUrl },
+        path.join(fixturesPath, fixture),
+      ),
+    ).resolves.toBeDefined();
+  });
+}

packages/now-md/.npmignore

@@ -0,0 +1 @@
+/test

packages/now-md/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@now/md",
-  "version": "0.4.6",
+  "version": "0.4.8",
   "dependencies": {
     "rehype-document": "^2.2.0",
     "rehype-format": "^2.3.0",
@@ -12,5 +12,8 @@
   },
   "peerDependencies": {
     "@now/build-utils": ">=0.0.1"
+  },
+  "scripts": {
+    "test": "jest"
   }
 }

packages/now-md/test/fixtures/01-cowsay/index.md

@@ -0,0 +1,5 @@
+# Testing Markdown
+
+cow:RANDOMNESS_PLACEHOLDER
+
+[Wow a link!](https://zeit.co)

packages/now-md/test/fixtures/01-cowsay/now.json

@@ -0,0 +1,11 @@
+{
+  "version": 2,
+  "builds": [
+    { "src": "index.md", "use": "@now/md" },
+    { "src": "subdirectory/index.md", "use": "@now/md" }
+  ],
+  "probes": [
+    { "path": "/", "mustContain": "cow:RANDOMNESS_PLACEHOLDER" },
+    { "path": "/subdirectory/", "mustContain": "yoda:RANDOMNESS_PLACEHOLDER" }
+  ]
+}

packages/now-md/test/fixtures/01-cowsay/subdirectory/index.md

@@ -0,0 +1,5 @@
+# Testing Markdown
+
+yoda:RANDOMNESS_PLACEHOLDER
+
+[Wow a link!](https://zeit.co)

packages/now-md/test/test.js

@@ -0,0 +1,33 @@
+/* global beforeAll, expect, it, jest */
+const fs = require('fs');
+const path = require('path');
+
+const {
+  packAndDeploy,
+  testDeployment,
+} = require('../../../test/lib/deployment/test-deployment.js');
+
+jest.setTimeout(2 * 60 * 1000);
+const buildUtilsUrl = '@canary';
+let builderUrl;
+
+beforeAll(async () => {
+  const builderPath = path.resolve(__dirname, '..');
+  builderUrl = await packAndDeploy(builderPath);
+  console.log('builderUrl', builderUrl);
+});
+
+const fixturesPath = path.resolve(__dirname, 'fixtures');
+
+// eslint-disable-next-line no-restricted-syntax
+for (const fixture of fs.readdirSync(fixturesPath)) {
+  // eslint-disable-next-line no-loop-func
+  it(`should build ${fixture}`, async () => {
+    await expect(
+      testDeployment(
+        { builderUrl, buildUtilsUrl },
+        path.join(fixturesPath, fixture),
+      ),
+    ).resolves.toBeDefined();
+  });
+}

packages/now-mdx-deck/.npmignore

@@ -0,0 +1 @@
+/test

packages/now-mdx-deck/index.js

@@ -14,7 +14,7 @@ exports.build = async ({ files, entrypoint, workPath }) => {
   console.log('downloading user files...');
   const downloadedFiles = await download(files, workPath);
   console.log('writing package.json...');
-  const packageJson = { dependencies: { 'mdx-deck': '1.7.7' } };
+  const packageJson = { dependencies: { 'mdx-deck': '1.7.15' } };
   const packageJsonPath = path.join(workPath, 'package.json');
   await writeFile(packageJsonPath, JSON.stringify(packageJson));
   console.log('running npm install...');
@@ -47,7 +47,7 @@ exports.build = async ({ files, entrypoint, workPath }) => {
 
 exports.prepareCache = async ({ cachePath }) => {
   console.log('writing package.json...');
-  const packageJson = { dependencies: { 'mdx-deck': '1.7.7' } };
+  const packageJson = { dependencies: { 'mdx-deck': '1.7.15' } };
   const packageJsonPath = path.join(cachePath, 'package.json');
   await writeFile(packageJsonPath, JSON.stringify(packageJson));
   console.log('running npm install...');

packages/now-mdx-deck/package.json

@@ -1,7 +1,10 @@
 {
   "name": "@now/mdx-deck",
-  "version": "0.4.15",
+  "version": "0.4.17",
   "peerDependencies": {
     "@now/build-utils": ">=0.0.1"
+  },
+  "scripts": {
+    "test": "jest"
   }
 }

packages/now-mdx-deck/test/fixtures/01-cowsay/index.mdx

@@ -0,0 +1,5 @@
+# Testing Markdown
+---
+cow:RANDOMNESS_PLACEHOLDER
+---
+[Wow a link!](https://zeit.co)

packages/now-mdx-deck/test/fixtures/01-cowsay/now.json

@@ -0,0 +1,11 @@
+{
+  "version": 2,
+  "builds": [
+    { "src": "index.mdx", "use": "@now/mdx-deck" },
+    { "src": "subdirectory/index.mdx", "use": "@now/mdx-deck" }
+  ],
+  "probes": [
+    { "path": "/", "mustContain": "cow:RANDOMNESS_PLACEHOLDER" },
+    { "path": "/subdirectory/", "mustContain": "yoda:RANDOMNESS_PLACEHOLDER" }
+  ]
+}

packages/now-mdx-deck/test/fixtures/01-cowsay/subdirectory/index.mdx

@@ -0,0 +1,5 @@
+# Testing Markdown
+---
+yoda:RANDOMNESS_PLACEHOLDER
+---
+[Wow a link!](https://zeit.co)

packages/now-mdx-deck/test/test.js

@@ -0,0 +1,33 @@
+/* global beforeAll, expect, it, jest */
+const fs = require('fs');
+const path = require('path');
+
+const {
+  packAndDeploy,
+  testDeployment,
+} = require('../../../test/lib/deployment/test-deployment.js');
+
+jest.setTimeout(2 * 60 * 1000);
+const buildUtilsUrl = '@canary';
+let builderUrl;
+
+beforeAll(async () => {
+  const builderPath = path.resolve(__dirname, '..');
+  builderUrl = await packAndDeploy(builderPath);
+  console.log('builderUrl', builderUrl);
+});
+
+const fixturesPath = path.resolve(__dirname, 'fixtures');
+
+// eslint-disable-next-line no-restricted-syntax
+for (const fixture of fs.readdirSync(fixturesPath)) {
+  // eslint-disable-next-line no-loop-func
+  it(`should build ${fixture}`, async () => {
+    await expect(
+      testDeployment(
+        { builderUrl, buildUtilsUrl },
+        path.join(fixturesPath, fixture),
+      ),
+    ).resolves.toBeDefined();
+  });
+}

packages/now-next/index.js

@@ -17,6 +17,7 @@ const {
   excludeLockFiles,
   normalizePackageJson,
   excludeStaticDirectory,
+  onlyStaticDirectory,
 } = require('./utils');
 
 /** @typedef { import('@now/build-utils/file-ref').Files } Files */
@@ -66,6 +67,10 @@ async function writeNpmRc(workPath, token) {
   );
 }
 
+exports.config = {
+  maxLambdaSize: '5mb',
+};
+
 /**
  * @param {BuildParamsType} buildParams
  * @returns {Promise<Files>}
@@ -87,10 +92,13 @@ exports.build = async ({ files, workPath, entrypoint }) => {
   const filesWithoutStaticDirectory = excludeStaticDirectory(
     filesWithoutLockfiles,
   );
-  let downloadedFiles = await download(filesWithoutStaticDirectory, workPath);
+  const downloadedFiles = await download(filesWithoutStaticDirectory, workPath);
 
   console.log('normalizing package.json');
-  const packageJson = normalizePackageJson(readPackageJson(downloadedFiles));
+  const packageJson = normalizePackageJson(
+    await readPackageJson(downloadedFiles),
+  );
+  console.log('normalized package.json result: ', packageJson);
   await writePackageJson(workPath, packageJson);
 
   if (process.env.NPM_AUTH_TOKEN) {
@@ -98,8 +106,6 @@ exports.build = async ({ files, workPath, entrypoint }) => {
     await writeNpmRc(workPath, process.env.NPM_AUTH_TOKEN);
   }
 
-  downloadedFiles = await glob('**', workPath);
-
   console.log('running npm install...');
   await runNpmInstall(workPath, ['--prefer-offline']);
   console.log('running user script...');
@@ -110,7 +116,7 @@ exports.build = async ({ files, workPath, entrypoint }) => {
     await unlink(path.join(workPath, '.npmrc'));
   }
 
-  downloadedFiles = await glob('**', workPath);
+  const filesAfterBuild = await glob('**', workPath);
 
   console.log('preparing lambda files...');
   let buildId;
@@ -137,8 +143,8 @@ exports.build = async ({ files, workPath, entrypoint }) => {
     ...dotNextServerRootFiles,
     ...launcherFiles,
   };
-  if (downloadedFiles['next.config.js']) {
-    nextFiles['next.config.js'] = downloadedFiles['next.config.js'];
+  if (filesAfterBuild['next.config.js']) {
+    nextFiles['next.config.js'] = filesAfterBuild['next.config.js'];
   }
   const pages = await glob(
     '**/*.js',
@@ -162,16 +168,16 @@ exports.build = async ({ files, workPath, entrypoint }) => {
       );
 
       const pageFiles = {
-        [`.next/server/static/${buildId}/pages/_document.js`]: downloadedFiles[
+        [`.next/server/static/${buildId}/pages/_document.js`]: filesAfterBuild[
           `.next/server/static/${buildId}/pages/_document.js`
         ],
-        [`.next/server/static/${buildId}/pages/_app.js`]: downloadedFiles[
+        [`.next/server/static/${buildId}/pages/_app.js`]: filesAfterBuild[
           `.next/server/static/${buildId}/pages/_app.js`
         ],
-        [`.next/server/static/${buildId}/pages/_error.js`]: downloadedFiles[
+        [`.next/server/static/${buildId}/pages/_error.js`]: filesAfterBuild[
           `.next/server/static/${buildId}/pages/_error.js`
         ],
-        [`.next/server/static/${buildId}/pages/${page}`]: downloadedFiles[
+        [`.next/server/static/${buildId}/pages/${page}`]: filesAfterBuild[
           `.next/server/static/${buildId}/pages/${page}`
         ],
       };
@@ -202,12 +208,36 @@ exports.build = async ({ files, workPath, entrypoint }) => {
     {},
   );
 
-  return { ...lambdas, ...staticFiles };
+  const nextStaticDirectory = onlyStaticDirectory(filesWithoutLockfiles);
+  const staticDirectoryFiles = Object.keys(nextStaticDirectory).reduce(
+    (mappedFiles, file) => ({
+      ...mappedFiles,
+      [path.join(entryDirectory, file)]: nextStaticDirectory[file],
+    }),
+    {},
+  );
+
+  return { ...lambdas, ...staticFiles, ...staticDirectoryFiles };
 };
 
-exports.prepareCache = async ({ files, cachePath, workPath }) => {
+exports.prepareCache = async ({
+  files, entrypoint, cachePath, workPath,
+}) => {
   console.log('downloading user files...');
-  await download(files, cachePath);
+  const entryDirectory = path.dirname(entrypoint);
+  const filesOnlyEntryDirectory = includeOnlyEntryDirectory(
+    files,
+    entryDirectory,
+  );
+  const filesWithEntryDirectoryRoot = moveEntryDirectoryToRoot(
+    filesOnlyEntryDirectory,
+    entryDirectory,
+  );
+  const filesWithoutLockfiles = excludeLockFiles(filesWithEntryDirectoryRoot);
+  const filesWithoutStaticDirectory = excludeStaticDirectory(
+    filesWithoutLockfiles,
+  );
+  await download(filesWithoutStaticDirectory, workPath);
   await download(await glob('.next/**', workPath), cachePath);
   await download(await glob('node_modules/**', workPath), cachePath);
 

packages/now-next/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@now/next",
-  "version": "0.0.78",
+  "version": "0.0.81",
   "dependencies": {
     "@now/node-bridge": "0.1.4",
     "execa": "^1.0.0",

packages/now-next/utils.js

@@ -111,31 +111,60 @@ function excludeStaticDirectory(files) {
   return excludeFiles(files, matcher);
 }
 
+/**
+ * Exclude the static directory from files
+ * @param {Files} files
+ * @returns {Files}
+ */
+function onlyStaticDirectory(files) {
+  function matcher(filePath) {
+    return !filePath.startsWith('static');
+  }
+
+  return excludeFiles(files, matcher);
+}
+
 /**
  * Enforce specific package.json configuration for smallest possible lambda
- * @param {Object} defaultPackageJson
+ * @param {{dependencies?: any, devDependencies?: any, scripts?: any}} defaultPackageJson
  */
 function normalizePackageJson(defaultPackageJson = {}) {
+  const dependencies = {};
+  const devDependencies = {
+    ...defaultPackageJson.dependencies,
+    ...defaultPackageJson.devDependencies,
+  };
+
+  if (devDependencies.react) {
+    dependencies.react = devDependencies.react;
+    delete devDependencies.react;
+  }
+
+  if (devDependencies['react-dom']) {
+    dependencies['react-dom'] = devDependencies['react-dom'];
+    delete devDependencies['react-dom'];
+  }
+
   return {
     ...defaultPackageJson,
     dependencies: {
       // react and react-dom can be overwritten
       react: 'latest',
       'react-dom': 'latest',
-      ...defaultPackageJson.dependencies,
+      ...dependencies, // override react if user provided it
       // next-server is forced to canary
       'next-server': 'canary',
-      next: undefined,
     },
     devDependencies: {
-      ...defaultPackageJson.devDependencies,
+      ...devDependencies,
       // next is forced to canary
       next: 'canary',
+      // next-server is a dependency here
       'next-server': undefined,
     },
     scripts: {
       ...defaultPackageJson.scripts,
-      'now-build': 'next build',
+      'now-build': 'next build --lambdas',
     },
   };
 }
@@ -148,4 +177,5 @@ module.exports = {
   excludeLockFiles,
   normalizePackageJson,
   excludeStaticDirectory,
+  onlyStaticDirectory,
 };

packages/now-node-bridge/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@now/node-bridge",
-  "version": "0.1.8",
+  "version": "0.1.9",
   "peerDependencies": {
     "@now/build-utils": ">=0.0.1"
   }

packages/now-node-server/.npmignore

@@ -0,0 +1 @@
+/test

packages/now-node-server/index.js

@@ -5,31 +5,41 @@ const FileFsRef = require('@now/build-utils/file-fs-ref.js');
 const fs = require('fs-extra');
 const glob = require('@now/build-utils/fs/glob.js');
 const path = require('path');
-const { promisify } = require('util');
+const rename = require('@now/build-utils/fs/rename.js');
 const {
   runNpmInstall,
   runPackageJsonScript,
 } = require('@now/build-utils/fs/run-user-scripts.js');
 
-const fsp = {
-  readFile: promisify(fs.readFile),
-};
+/** @typedef { import('@now/build-utils/file-ref') } FileRef */
+/** @typedef {{[filePath: string]: FileRef}} Files */
 
-async function commonForTwo({
-  files, entrypoint, workPath, cachePath,
-}) {
-  const xPath = workPath || cachePath;
-  const preferOfflineArgument = workPath ? ['--prefer-offline'] : [];
+/**
+ * @typedef {Object} BuildParamsType
+ * @property {Files} files - Files object
+ * @property {string} entrypoint - Entrypoint specified for the builder
+ * @property {Object} config - User-passed config from now.json
+ * @property {string} workPath - Working directory for this build
+ */
 
-  const xUserPath = path.join(xPath, 'user');
-  const xNccPath = path.join(xPath, 'ncc');
+/**
+ * @param {BuildParamsType} buildParams
+ * @param {Object} [options]
+ * @param {string[]} [options.npmArguments]
+ */
+async function downloadInstallAndBundle(
+  { files, entrypoint, workPath },
+  { npmArguments = [] } = {},
+) {
+  const userPath = path.join(workPath, 'user');
+  const nccPath = path.join(workPath, 'ncc');
 
   console.log('downloading user files...');
-  const filesOnDisk = await download(files, xUserPath);
+  const downloadedFiles = await download(files, userPath);
 
   console.log('running npm install for user...');
-  const entrypointFsDirname = path.join(xUserPath, path.dirname(entrypoint));
-  await runNpmInstall(entrypointFsDirname, preferOfflineArgument);
+  const entrypointFsDirname = path.join(userPath, path.dirname(entrypoint));
+  await runNpmInstall(entrypointFsDirname, npmArguments);
 
   console.log('writing ncc package.json...');
   await download(
@@ -37,48 +47,77 @@ async function commonForTwo({
       'package.json': new FileBlob({
         data: JSON.stringify({
           dependencies: {
-            '@zeit/ncc': '0.1.4-webpack',
+            '@zeit/ncc': '0.4.1',
           },
         }),
       }),
     },
-    xNccPath,
+    nccPath,
   );
 
   console.log('running npm install for ncc...');
-  await runNpmInstall(xNccPath, preferOfflineArgument);
-  return [filesOnDisk, xNccPath, entrypointFsDirname];
+  await runNpmInstall(nccPath, npmArguments);
+  return [downloadedFiles, userPath, nccPath, entrypointFsDirname];
 }
 
-async function compile(workNccPath, input) {
+async function compile(workNccPath, downloadedFiles, entrypoint) {
+  const input = downloadedFiles[entrypoint].fsPath;
   const ncc = require(path.join(workNccPath, 'node_modules/@zeit/ncc'));
-  return ncc(input);
+  const { code, assets } = await ncc(input);
+
+  const preparedFiles = {};
+  const blob = new FileBlob({ data: code });
+  // move all user code to 'user' subdirectory
+  preparedFiles[path.join('user', entrypoint)] = blob;
+  // eslint-disable-next-line no-restricted-syntax
+  for (const assetName of Object.keys(assets)) {
+    const blob2 = new FileBlob({ data: assets[assetName] });
+    preparedFiles[
+      path.join('user', path.dirname(entrypoint), assetName)
+    ] = blob2;
+  }
+
+  return preparedFiles;
 }
 
 exports.config = {
   maxLambdaSize: '15mb',
 };
 
-exports.build = async ({ files, entrypoint, workPath }) => {
-  const [filesOnDisk, workNccPath, entrypointFsDirname] = await commonForTwo({
-    files,
-    entrypoint,
-    workPath,
-  });
+/**
+ * @param {BuildParamsType} buildParams
+ * @returns {Promise<Files>}
+ */
+exports.build = async ({
+  files, entrypoint, config, workPath,
+}) => {
+  const [
+    downloadedFiles,
+    workUserPath,
+    workNccPath,
+    entrypointFsDirname,
+  ] = await downloadInstallAndBundle(
+    { files, entrypoint, workPath },
+    { npmArguments: ['--prefer-offline'] },
+  );
 
   console.log('running user script...');
   await runPackageJsonScript(entrypointFsDirname, 'now-build');
 
-  console.log('compiling entrypoint with ncc...');
-  const data = await compile(workNccPath, filesOnDisk[entrypoint].fsPath);
-  const blob = new FileBlob({ data });
-
   console.log('preparing lambda files...');
-  // move all user code to 'user' subdirectory
-  const compiledFiles = { [path.join('user', entrypoint)]: blob };
-  const launcherPath = path.join(__dirname, 'launcher.js');
-  let launcherData = await fsp.readFile(launcherPath, 'utf8');
+  let preparedFiles;
 
+  if (config && config.bundle === false) {
+    // move all user code to 'user' subdirectory
+    preparedFiles = await glob('**', workUserPath);
+    preparedFiles = rename(preparedFiles, name => path.join('user', name));
+  } else {
+    console.log('compiling entrypoint with ncc...');
+    preparedFiles = await compile(workNccPath, downloadedFiles, entrypoint);
+  }
+
+  const launcherPath = path.join(__dirname, 'launcher.js');
+  let launcherData = await fs.readFile(launcherPath, 'utf8');
   launcherData = launcherData.replace(
     '// PLACEHOLDER',
     [
@@ -93,7 +132,7 @@ exports.build = async ({ files, entrypoint, workPath }) => {
   };
 
   const lambda = await createLambda({
-    files: { ...compiledFiles, ...launcherFiles },
+    files: { ...preparedFiles, ...launcherFiles },
     handler: 'launcher.launcher',
     runtime: 'nodejs8.10',
   });
@@ -105,7 +144,7 @@ exports.prepareCache = async ({
   files, entrypoint, workPath, cachePath,
 }) => {
   await fs.remove(workPath);
-  await commonForTwo({ files, entrypoint, cachePath });
+  await downloadInstallAndBundle({ files, entrypoint, workPath: cachePath });
 
   return {
     ...(await glob('user/node_modules/**', cachePath)),

packages/now-node-server/package.json

@@ -1,11 +1,14 @@
 {
   "name": "@now/node-server",
-  "version": "0.4.23",
+  "version": "0.4.25",
   "dependencies": {
-    "@now/node-bridge": "^0.1.8",
+    "@now/node-bridge": "^0.1.9",
     "fs-extra": "7.0.1"
   },
   "peerDependencies": {
     "@now/build-utils": ">=0.0.1"
+  },
+  "scripts": {
+    "test": "jest"
   }
 }

packages/now-node-server/test/fixtures/01-cowsay/index.js

@@ -0,0 +1,11 @@
+const cowsay = require('cowsay/build/cowsay.umd.js').say;
+const http = require('http');
+
+// test that process.env is not replaced by webpack
+process.env.NODE_ENV = 'development';
+
+const server = http.createServer((req, resp) => {
+  resp.end(cowsay({ text: 'cow:RANDOMNESS_PLACEHOLDER' }));
+});
+
+server.listen();

packages/now-node-server/test/fixtures/01-cowsay/now.json

@@ -0,0 +1,11 @@
+{
+  "version": 2,
+  "builds": [
+    { "src": "index.js", "use": "@now/node-server" },
+    { "src": "subdirectory/index.js", "use": "@now/node-server" }
+  ],
+  "probes": [
+    { "path": "/", "mustContain": "cow:RANDOMNESS_PLACEHOLDER" },
+    { "path": "/subdirectory/", "mustContain": "yoda:RANDOMNESS_PLACEHOLDER" }
+  ]
+}

packages/now-node-server/test/fixtures/01-cowsay/package.json

@@ -0,0 +1,5 @@
+{
+  "dependencies": {
+    "cowsay": "^1.3.1"
+  }
+}

packages/now-node-server/test/fixtures/01-cowsay/subdirectory/index.js

@@ -0,0 +1,11 @@
+const yodasay = require('yodasay/build/yodasay.umd.js').say;
+const http = require('http');
+
+// test that process.env is not replaced by webpack
+process.env.NODE_ENV = 'development';
+
+const server = http.createServer((req, resp) => {
+  resp.end(yodasay({ text: 'yoda:RANDOMNESS_PLACEHOLDER' }));
+});
+
+server.listen();

packages/now-node-server/test/fixtures/01-cowsay/subdirectory/package.json

@@ -0,0 +1,5 @@
+{
+  "dependencies": {
+    "yodasay": "^1.1.6"
+  }
+}

packages/now-node-server/test/fixtures/03-env-vars/build-env/index.js

@@ -0,0 +1,10 @@
+const assert = require('assert');
+const http = require('http');
+
+const server = http.createServer((req, resp) => {
+  assert(!process.env.RANDOMNESS_BUILD_ENV_VAR);
+  assert(process.env.RANDOMNESS_ENV_VAR);
+  resp.end('BUILD_TIME_PLACEHOLDER:build-env');
+});
+
+server.listen();

packages/now-node-server/test/fixtures/03-env-vars/build-env/now-build.js

@@ -0,0 +1,12 @@
+const assert = require('assert');
+const fs = require('fs');
+
+assert(process.env.RANDOMNESS_BUILD_ENV_VAR);
+assert(!process.env.RANDOMNESS_ENV_VAR);
+
+fs.writeFileSync(
+  'index.js',
+  fs
+    .readFileSync('index.js', 'utf8')
+    .replace('BUILD_TIME_PLACEHOLDER', process.env.RANDOMNESS_BUILD_ENV_VAR),
+);

packages/now-node-server/test/fixtures/03-env-vars/build-env/package.json

@@ -0,0 +1,5 @@
+{
+  "scripts": {
+    "now-build": "node now-build.js"
+  }
+}

packages/now-node-server/test/fixtures/03-env-vars/env/index.js

@@ -0,0 +1,10 @@
+const assert = require('assert');
+const http = require('http');
+
+const server = http.createServer((req, resp) => {
+  assert(!process.env.RANDOMNESS_BUILD_ENV_VAR);
+  assert(process.env.RANDOMNESS_ENV_VAR);
+  resp.end(`${process.env.RANDOMNESS_ENV_VAR}:env`);
+});
+
+server.listen();

packages/now-node-server/test/fixtures/03-env-vars/now.json

@@ -0,0 +1,11 @@
+{
+  "version": 2,
+  "builds": [
+    { "src": "build-env/index.js", "use": "@now/node-server" },
+    { "src": "env/index.js", "use": "@now/node-server" }
+  ],
+  "probes": [
+    { "path": "/build-env", "mustContain": "RANDOMNESS_PLACEHOLDER:build-env" },
+    { "path": "/env", "mustContain": "RANDOMNESS_PLACEHOLDER:env" }
+  ]
+}

packages/now-node-server/test/fixtures/08-assets/index.js

@@ -0,0 +1,15 @@
+const fs = require('fs');
+const http = require('http');
+const path = require('path');
+
+const server = http.createServer((req, resp) => {
+  const asset1 = fs.readFileSync(
+    path.join(__dirname, 'subdirectory1/asset.txt'),
+  );
+  const asset2 = fs.readFileSync(
+    path.join(__dirname, 'subdirectory2/asset.txt'),
+  );
+  resp.end(`${asset1},${asset2}`);
+});
+
+server.listen();

packages/now-node-server/test/fixtures/08-assets/now.json

@@ -0,0 +1,9 @@
+{
+  "version": 2,
+  "builds": [
+    { "src": "index.js", "use": "@now/node-server" }
+  ],
+  "probes": [
+    { "path": "/", "mustContain": "asset1:RANDOMNESS_PLACEHOLDER,asset2:RANDOMNESS_PLACEHOLDER" }
+  ]
+}

packages/now-node-server/test/fixtures/08-assets/subdirectory1/asset.txt

@@ -0,0 +1 @@
+asset1:RANDOMNESS_PLACEHOLDER

packages/now-node-server/test/fixtures/08-assets/subdirectory2/asset.txt

@@ -0,0 +1 @@
+asset2:RANDOMNESS_PLACEHOLDER

packages/now-node-server/test/fixtures/09-no-bundle/now.json

@@ -0,0 +1,11 @@
+{
+  "version": 2,
+  "builds": [
+    { "src": "with-bundle/index.js", "use": "@now/node-server" },
+    { "src": "without-bundle/index.js", "use": "@now/node-server", "config": { "bundle": false } }
+  ],
+  "probes": [
+    { "path": "/with-bundle", "mustContain": "RANDOMNESS_PLACEHOLDER" },
+    { "path": "/without-bundle", "mustContain": "RANDOMNESS_PLACEHOLDER" }
+  ]
+}

packages/now-node-server/test/fixtures/09-no-bundle/with-bundle/index.js

@@ -0,0 +1,8 @@
+const http = require('http');
+const isBundled = require('./is-bundled.js');
+
+const server = http.createServer((req, resp) => {
+  resp.end(isBundled() ? 'RANDOMNESS_PLACEHOLDER' : '');
+});
+
+server.listen();

packages/now-node-server/test/fixtures/09-no-bundle/with-bundle/is-bundled.js

@@ -0,0 +1,3 @@
+const path = require('path');
+
+module.exports = () => path.basename(__filename) === 'index.js';

packages/now-node-server/test/fixtures/09-no-bundle/without-bundle/index.js

@@ -0,0 +1,8 @@
+const http = require('http');
+const isBundled = require('./is-bundled.js');
+
+const server = http.createServer((req, resp) => {
+  resp.end(isBundled() ? '' : 'RANDOMNESS_PLACEHOLDER');
+});
+
+server.listen();

packages/now-node-server/test/fixtures/09-no-bundle/without-bundle/is-bundled.js

@@ -0,0 +1,3 @@
+const path = require('path');
+
+module.exports = () => path.basename(__filename) === 'index.js';

packages/now-node-server/test/fixtures/10-others/apollo/index.js

@@ -0,0 +1,24 @@
+const express = require('express');
+const { ApolloServer, gql } = require('apollo-server-express');
+
+const typeDefs = gql`
+  type Query {
+    hello: String
+  }
+`;
+
+const resolvers = {
+  Query: {
+    hello: () => 'apollo:RANDOMNESS_PLACEHOLDER',
+  },
+};
+
+const server = new ApolloServer({ typeDefs, resolvers, introspection: true });
+
+const app = express();
+server.applyMiddleware({ app });
+app.get('/', (req, resp) => {
+  resp.redirect('/graphql');
+});
+
+app.listen({ port: 4000 });

packages/now-node-server/test/fixtures/10-others/apollo/package.json

@@ -0,0 +1,7 @@
+{
+  "dependencies": {
+    "apollo-server-express": "^2.2.2",
+    "express": "^4.16.4",
+    "graphql": "^14.0.2"
+  }
+}

packages/now-node-server/test/fixtures/10-others/now.json

@@ -0,0 +1,12 @@
+{
+  "version": 2,
+  "builds": [
+    { "src": "apollo/index.js", "use": "@now/node-server" }
+  ],
+  "routes": [
+    { "src": "/.*", "dest": "apollo/index.js" }
+  ],
+  "probes": [
+    { "path": "/graphql", "method": "POST", "body": { "query": "{hello}" }, "mustContain": "apollo:RANDOMNESS_PLACEHOLDER" }
+  ]
+}

packages/now-node-server/test/test.js

@@ -0,0 +1,33 @@
+/* global beforeAll, expect, it, jest */
+const fs = require('fs');
+const path = require('path');
+
+const {
+  packAndDeploy,
+  testDeployment,
+} = require('../../../test/lib/deployment/test-deployment.js');
+
+jest.setTimeout(2 * 60 * 1000);
+const buildUtilsUrl = '@canary';
+let builderUrl;
+
+beforeAll(async () => {
+  const builderPath = path.resolve(__dirname, '..');
+  builderUrl = await packAndDeploy(builderPath);
+  console.log('builderUrl', builderUrl);
+});
+
+const fixturesPath = path.resolve(__dirname, 'fixtures');
+
+// eslint-disable-next-line no-restricted-syntax
+for (const fixture of fs.readdirSync(fixturesPath)) {
+  // eslint-disable-next-line no-loop-func
+  it(`should build ${fixture}`, async () => {
+    await expect(
+      testDeployment(
+        { builderUrl, buildUtilsUrl },
+        path.join(fixturesPath, fixture),
+      ),
+    ).resolves.toBeDefined();
+  });
+}

packages/now-node/.npmignore

@@ -0,0 +1 @@
+/test

packages/now-node/index.js

@@ -2,18 +2,14 @@ const { createLambda } = require('@now/build-utils/lambda.js');
 const download = require('@now/build-utils/fs/download.js');
 const FileBlob = require('@now/build-utils/file-blob.js');
 const FileFsRef = require('@now/build-utils/file-fs-ref.js');
-const fsExtra = require('fs-extra');
-const fs = require('fs');
+const fs = require('fs-extra');
 const glob = require('@now/build-utils/fs/glob.js');
 const path = require('path');
-const { promisify } = require('util');
 const {
   runNpmInstall,
   runPackageJsonScript,
 } = require('@now/build-utils/fs/run-user-scripts.js');
 
-const readFile = promisify(fs.readFile);
-
 /** @typedef { import('@now/build-utils/file-ref') } FileRef */
 /** @typedef {{[filePath: string]: FileRef}} Files */
 
@@ -37,7 +33,7 @@ async function downloadInstallAndBundle(
   const nccPath = path.join(workPath, 'ncc');
 
   console.log('downloading user files...');
-  const filesOnDisk = await download(files, userPath);
+  const downloadedFiles = await download(files, userPath);
 
   console.log('running npm install for user...');
   const entrypointFsDirname = path.join(userPath, path.dirname(entrypoint));
@@ -49,7 +45,7 @@ async function downloadInstallAndBundle(
       'package.json': new FileBlob({
         data: JSON.stringify({
           dependencies: {
-            '@zeit/ncc': '0.1.4-webpack',
+            '@zeit/ncc': '0.4.1',
           },
         }),
       }),
@@ -59,12 +55,27 @@ async function downloadInstallAndBundle(
 
   console.log('running npm install for ncc...');
   await runNpmInstall(nccPath, npmArguments);
-  return [filesOnDisk, nccPath, entrypointFsDirname];
+  return [downloadedFiles, nccPath, entrypointFsDirname];
 }
 
-async function compile(workNccPath, input) {
+async function compile(workNccPath, downloadedFiles, entrypoint) {
+  const input = downloadedFiles[entrypoint].fsPath;
   const ncc = require(path.join(workNccPath, 'node_modules/@zeit/ncc'));
-  return ncc(input);
+  const { code, assets } = await ncc(input);
+
+  const preparedFiles = {};
+  const blob = new FileBlob({ data: code });
+  // move all user code to 'user' subdirectory
+  preparedFiles[path.join('user', entrypoint)] = blob;
+  // eslint-disable-next-line no-restricted-syntax
+  for (const assetName of Object.keys(assets)) {
+    const blob2 = new FileBlob({ data: assets[assetName] });
+    preparedFiles[
+      path.join('user', path.dirname(entrypoint), assetName)
+    ] = blob2;
+  }
+
+  return preparedFiles;
 }
 
 exports.config = {
@@ -77,7 +88,7 @@ exports.config = {
  */
 exports.build = async ({ files, entrypoint, workPath }) => {
   const [
-    filesOnDisk,
+    downloadedFiles,
     workNccPath,
     entrypointFsDirname,
   ] = await downloadInstallAndBundle(
@@ -89,20 +100,16 @@ exports.build = async ({ files, entrypoint, workPath }) => {
   await runPackageJsonScript(entrypointFsDirname, 'now-build');
 
   console.log('compiling entrypoint with ncc...');
-  const data = await compile(workNccPath, filesOnDisk[entrypoint].fsPath);
-  const blob = new FileBlob({ data });
-
-  console.log('preparing lambda files...');
-  // move all user code to 'user' subdirectory
-  const compiledFiles = { [path.join('user', entrypoint)]: blob };
+  const preparedFiles = await compile(workNccPath, downloadedFiles, entrypoint);
   const launcherPath = path.join(__dirname, 'launcher.js');
-  let launcherData = await readFile(launcherPath, 'utf8');
+  let launcherData = await fs.readFile(launcherPath, 'utf8');
 
   launcherData = launcherData.replace(
     '// PLACEHOLDER',
     [
       'process.chdir("./user");',
       `listener = require("./${path.join('user', entrypoint)}");`,
+      'if (listener.default) listener = listener.default;',
     ].join(' '),
   );
 
@@ -112,7 +119,7 @@ exports.build = async ({ files, entrypoint, workPath }) => {
   };
 
   const lambda = await createLambda({
-    files: { ...compiledFiles, ...launcherFiles },
+    files: { ...preparedFiles, ...launcherFiles },
     handler: 'launcher.launcher',
     runtime: 'nodejs8.10',
   });
@@ -123,7 +130,7 @@ exports.build = async ({ files, entrypoint, workPath }) => {
 exports.prepareCache = async ({
   files, entrypoint, workPath, cachePath,
 }) => {
-  await fsExtra.remove(workPath);
+  await fs.remove(workPath);
   await downloadInstallAndBundle({ files, entrypoint, workPath: cachePath });
 
   return {

packages/now-node/package.json

@@ -1,11 +1,14 @@
 {
   "name": "@now/node",
-  "version": "0.4.25",
+  "version": "0.4.27",
   "dependencies": {
-    "@now/node-bridge": "^0.1.8",
+    "@now/node-bridge": "^0.1.9",
     "fs-extra": "7.0.1"
   },
   "peerDependencies": {
     "@now/build-utils": ">=0.0.1"
+  },
+  "scripts": {
+    "test": "jest"
   }
 }

packages/now-node/test/fixtures/01-cowsay/index.js

@@ -0,0 +1,8 @@
+const cowsay = require('cowsay/build/cowsay.umd.js').say;
+
+// test that process.env is not replaced by webpack
+process.env.NODE_ENV = 'development';
+
+module.exports = (req, resp) => {
+  resp.end(cowsay({ text: 'cow:RANDOMNESS_PLACEHOLDER' }));
+};

packages/now-node/test/fixtures/01-cowsay/now.json

@@ -0,0 +1,11 @@
+{
+  "version": 2,
+  "builds": [
+    { "src": "index.js", "use": "@now/node" },
+    { "src": "subdirectory/index.js", "use": "@now/node" }
+  ],
+  "probes": [
+    { "path": "/", "mustContain": "cow:RANDOMNESS_PLACEHOLDER" },
+    { "path": "/subdirectory/", "mustContain": "yoda:RANDOMNESS_PLACEHOLDER" }
+  ]
+}

packages/now-node/test/fixtures/01-cowsay/package.json

@@ -0,0 +1,5 @@
+{
+  "dependencies": {
+    "cowsay": "^1.3.1"
+  }
+}

packages/now-node/test/fixtures/01-cowsay/subdirectory/index.js

@@ -0,0 +1,8 @@
+const yodasay = require('yodasay/build/yodasay.umd.js').say;
+
+// test that process.env is not replaced by webpack
+process.env.NODE_ENV = 'development';
+
+module.exports = (req, resp) => {
+  resp.end(yodasay({ text: 'yoda:RANDOMNESS_PLACEHOLDER' }));
+};

packages/now-node/test/fixtures/01-cowsay/subdirectory/package.json

@@ -0,0 +1,5 @@
+{
+  "dependencies": {
+    "yodasay": "^1.1.6"
+  }
+}

packages/now-node/test/fixtures/03-env-vars/build-env/index.js

@@ -0,0 +1,7 @@
+const assert = require('assert');
+
+module.exports = (req, resp) => {
+  assert(!process.env.RANDOMNESS_BUILD_ENV_VAR);
+  assert(process.env.RANDOMNESS_ENV_VAR);
+  resp.end('BUILD_TIME_PLACEHOLDER:build-env');
+};

packages/now-node/test/fixtures/03-env-vars/build-env/now-build.js

@@ -0,0 +1,12 @@
+const assert = require('assert');
+const fs = require('fs');
+
+assert(process.env.RANDOMNESS_BUILD_ENV_VAR);
+assert(!process.env.RANDOMNESS_ENV_VAR);
+
+fs.writeFileSync(
+  'index.js',
+  fs
+    .readFileSync('index.js', 'utf8')
+    .replace('BUILD_TIME_PLACEHOLDER', process.env.RANDOMNESS_BUILD_ENV_VAR),
+);

packages/now-node/test/fixtures/03-env-vars/build-env/package.json

@@ -0,0 +1,5 @@
+{
+  "scripts": {
+    "now-build": "node now-build.js"
+  }
+}

packages/now-node/test/fixtures/03-env-vars/env/index.js

@@ -0,0 +1,7 @@
+const assert = require('assert');
+
+module.exports = (req, resp) => {
+  assert(!process.env.RANDOMNESS_BUILD_ENV_VAR);
+  assert(process.env.RANDOMNESS_ENV_VAR);
+  resp.end(`${process.env.RANDOMNESS_ENV_VAR}:env`);
+};

packages/now-node/test/fixtures/03-env-vars/now.json

@@ -0,0 +1,11 @@
+{
+  "version": 2,
+  "builds": [
+    { "src": "build-env/index.js", "use": "@now/node" },
+    { "src": "env/index.js", "use": "@now/node" }
+  ],
+  "probes": [
+    { "path": "/build-env", "mustContain": "RANDOMNESS_PLACEHOLDER:build-env" },
+    { "path": "/env", "mustContain": "RANDOMNESS_PLACEHOLDER:env" }
+  ]
+}

packages/now-node/test/fixtures/08-assets/index.js

@@ -0,0 +1,12 @@
+const fs = require('fs');
+const path = require('path');
+
+module.exports = (req, resp) => {
+  const asset1 = fs.readFileSync(
+    path.join(__dirname, 'subdirectory1/asset.txt'),
+  );
+  const asset2 = fs.readFileSync(
+    path.join(__dirname, 'subdirectory2/asset.txt'),
+  );
+  resp.end(`${asset1},${asset2}`);
+};

packages/now-node/test/fixtures/08-assets/now.json

@@ -0,0 +1,9 @@
+{
+  "version": 2,
+  "builds": [
+    { "src": "index.js", "use": "@now/node" }
+  ],
+  "probes": [
+    { "path": "/", "mustContain": "asset1:RANDOMNESS_PLACEHOLDER,asset2:RANDOMNESS_PLACEHOLDER" }
+  ]
+}

packages/now-node/test/fixtures/08-assets/subdirectory1/asset.txt

@@ -0,0 +1 @@
+asset1:RANDOMNESS_PLACEHOLDER

packages/now-node/test/fixtures/08-assets/subdirectory2/asset.txt

@@ -0,0 +1 @@
+asset2:RANDOMNESS_PLACEHOLDER

packages/now-node/test/test.js

@@ -0,0 +1,33 @@
+/* global beforeAll, expect, it, jest */
+const fs = require('fs');
+const path = require('path');
+
+const {
+  packAndDeploy,
+  testDeployment,
+} = require('../../../test/lib/deployment/test-deployment.js');
+
+jest.setTimeout(2 * 60 * 1000);
+const buildUtilsUrl = '@canary';
+let builderUrl;
+
+beforeAll(async () => {
+  const builderPath = path.resolve(__dirname, '..');
+  builderUrl = await packAndDeploy(builderPath);
+  console.log('builderUrl', builderUrl);
+});
+
+const fixturesPath = path.resolve(__dirname, 'fixtures');
+
+// eslint-disable-next-line no-restricted-syntax
+for (const fixture of fs.readdirSync(fixturesPath)) {
+  // eslint-disable-next-line no-loop-func
+  it(`should build ${fixture}`, async () => {
+    await expect(
+      testDeployment(
+        { builderUrl, buildUtilsUrl },
+        path.join(fixturesPath, fixture),
+      ),
+    ).resolves.toBeDefined();
+  });
+}

packages/now-optipng/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@now/optipng",
-  "version": "0.4.6",
+  "version": "0.4.7",
   "dependencies": {
     "multipipe": "2.0.3",
     "optipng": "1.1.0"