Publish Stable

- @now/next@2.3.3
Revert "[now-next] Implement handle: miss for custom-routes (#3456 )" (#3488 )
2025-12-26 03:39:11 +00:00 · 2020-01-02 13:18:38 -06:00 · 2020-01-02 13:15:16 -06:00 · 2020-01-02 12:42:36 -05:00 · 2020-01-02 17:34:31 +00:00 · 2019-12-31 15:56:54 -06:00
10 changed files with 43 additions and 22 deletions
--- a/packages/now-build-utils/package.json
+++ b/packages/now-build-utils/package.json
@@ -1,6 +1,6 @@
 {
  "name": "@now/build-utils",
-  "version": "1.2.1-canary.5",
+  "version": "1.2.1-canary.6",
  "license": "MIT",
  "main": "./dist/index.js",
  "types": "./dist/index.d.js",
--- a/packages/now-build-utils/src/fs/node-version.ts
+++ b/packages/now-build-utils/src/fs/node-version.ts
@@ -16,17 +16,19 @@ const allOptions: NodeVersion[] = [

 const supportedOptions = allOptions.filter(o => !isDiscontinued(o));

-// This version should match Fargate's default in the PATH
-// Today that is Node 8
-export const defaultSelection = supportedOptions.find(
-  o => o.major === 8
-) as NodeVersion;
+export function getOldestNodeVersion(): NodeVersion {
+  return allOptions[allOptions.length - 1];
+}
+
+export function getLatestNodeVersion(): NodeVersion {
+  return allOptions[0];
+}

 export async function getSupportedNodeVersion(
  engineRange?: string,
  silent?: boolean
 ): Promise<NodeVersion> {
-  let selection = defaultSelection;
+  let selection = getOldestNodeVersion();

  if (!engineRange) {
    if (!silent) {
--- a/packages/now-build-utils/src/fs/run-user-scripts.ts
+++ b/packages/now-build-utils/src/fs/run-user-scripts.ts
@@ -150,8 +150,10 @@ export async function getNodeVersion(
  } else if (minNodeVersion) {
    range = minNodeVersion;
    silent = true;
+  } else if (config && config.nodeVersion) {
+    range = config.nodeVersion;
+    silent = true;
  } else if (config && config.zeroConfig) {
-    // Use latest node version zero config detected
    range = '10.x';
    silent = true;
  }
--- a/packages/now-build-utils/src/index.ts
+++ b/packages/now-build-utils/src/index.ts
@@ -21,6 +21,7 @@ import {
  getNodeVersion,
  getSpawnOptions,
 } from './fs/run-user-scripts';
+import { getLatestNodeVersion } from './fs/node-version';
 import streamToBuffer from './fs/stream-to-buffer';
 import shouldServe from './should-serve';
 import debug from './debug';
@@ -48,6 +49,7 @@ export {
  runPipInstall,
  runShellScript,
  getNodeVersion,
+  getLatestNodeVersion,
  getSpawnOptions,
  streamToBuffer,
  shouldServe,
--- a/packages/now-build-utils/src/types.ts
+++ b/packages/now-build-utils/src/types.ts
@@ -43,6 +43,7 @@ export interface Config {
  buildCommand?: string;
  devCommand?: string;
  framework?: string;
+  nodeVersion?: string;
 }

 export interface Meta {
--- a/packages/now-build-utils/test/unit.test.js
+++ b/packages/now-build-utils/test/unit.test.js
@@ -3,10 +3,8 @@ const fs = require('fs-extra');
 const assert = require('assert');
 const { createZip } = require('../dist/lambda');
 const { glob, spawnAsync, download } = require('../');
-const {
-  getSupportedNodeVersion,
-  defaultSelection,
-} = require('../dist/fs/node-version');
+const { getSupportedNodeVersion } = require('../dist/fs/node-version');
+const { getNodeVersion, getLatestNodeVersion } = require('../dist');

 it('should re-create symlinks properly', async () => {
  const files = await glob('**', path.join(__dirname, 'symlinks'));
@@ -50,14 +48,11 @@ it('should create zip files with symlinks properly', async () => {

 it('should only match supported node versions', async () => {
  expect(await getSupportedNodeVersion('10.x')).toHaveProperty('major', 10);
-  expect(await getSupportedNodeVersion('8.10.x')).toHaveProperty('major', 8);
+  expect(await getSupportedNodeVersion('12.x')).toHaveProperty('major', 12);
  expect(getSupportedNodeVersion('8.11.x')).rejects.toThrow();
  expect(getSupportedNodeVersion('6.x')).rejects.toThrow();
  expect(getSupportedNodeVersion('999.x')).rejects.toThrow();
  expect(getSupportedNodeVersion('foo')).rejects.toThrow();
-  expect(await getSupportedNodeVersion('')).toBe(defaultSelection);
-  expect(await getSupportedNodeVersion(null)).toBe(defaultSelection);
-  expect(await getSupportedNodeVersion(undefined)).toBe(defaultSelection);
 });

 it('should match all semver ranges', async () => {
@@ -78,6 +73,22 @@ it('should match all semver ranges', async () => {
  expect(await getSupportedNodeVersion('^10.5.0')).toHaveProperty('major', 10);
 });

+it('should select correct node version in getNodeVersion()', async () => {
+  expect(
+    await getNodeVersion('/tmp', undefined, { nodeVersion: '12.x' })
+  ).toHaveProperty('major', 12);
+  expect(
+    await getNodeVersion('/tmp', undefined, { nodeVersion: '10.x' })
+  ).toHaveProperty('major', 10);
+  expect(
+    await getNodeVersion('/tmp', '10.x', { nodeVersion: '12.x' })
+  ).toHaveProperty('major', 10);
+});
+
+it('should get latest node version', async () => {
+  expect(await getLatestNodeVersion()).toHaveProperty('major', 12);
+});
+
 it('should support require by path for legacy builders', () => {
  const index = require('@now/build-utils');

--- a/packages/now-next/package.json
+++ b/packages/now-next/package.json
@@ -1,6 +1,6 @@
 {
  "name": "@now/next",
-  "version": "2.3.2-canary.0",
+  "version": "2.3.3",
  "license": "MIT",
  "main": "./dist/index",
  "homepage": "https://zeit.co/docs/runtimes#official-runtimes/next-js",
--- a/packages/now-node/package.json
+++ b/packages/now-node/package.json
@@ -1,6 +1,6 @@
 {
  "name": "@now/node",
-  "version": "1.3.1-canary.0",
+  "version": "1.3.1-canary.1",
  "license": "MIT",
  "main": "./dist/index",
  "homepage": "https://zeit.co/docs/runtimes#official-runtimes/node-js",
--- a/packages/now-node/test/fixtures/35-puppeteer/package.json
+++ b/packages/now-node/test/fixtures/35-puppeteer/package.json
@@ -1,7 +1,10 @@
 {
+  "engines": {
+    "node": "10.x"
+  },
  "dependencies": {
-    "chrome-aws-lambda": "1.11.1",
-    "lighthouse": "4.3.1",
-    "puppeteer-core": "1.11.0"
+    "chrome-aws-lambda": "1.20.4",
+    "lighthouse": "5.6.0",
+    "puppeteer-core": "1.20.0"
  }
 }
--- a/packages/now-static-build/package.json
+++ b/packages/now-static-build/package.json
@@ -1,6 +1,6 @@
 {
  "name": "@now/static-build",
-  "version": "0.14.1-canary.6",
+  "version": "0.14.1-canary.7",
  "license": "MIT",
  "main": "./dist/index",
  "homepage": "https://zeit.co/docs/runtimes#official-runtimes/static-builds",
Author	SHA1	Message	Date
JJ Kasper	4f0f44e746	Publish Stable - @now/next@2.3.3	2020-01-02 13:18:38 -06:00
JJ Kasper	0da98a7f5d	Revert "[now-next] Implement handle: miss for custom-routes (#3456 )" (#3488 ) This reverts commit `40bbff9bee`.	2020-01-02 13:15:16 -06:00
Steven	685989ae57	Publish Canary - @now/build-utils@1.2.1-canary.6 - @now/next@2.3.3-canary.0 - @now/node@1.3.1-canary.1 - @now/static-build@0.14.1-canary.7	2020-01-02 12:42:36 -05:00
Steven	6bc121e7b1	[now-build-utils] Add support for `getLatestNodeVersion()` and `config.nodeVersion` (#3483 ) This PR does a few things: 1. Add functions `getLatestNodeVersion()` and `getOldestNodeVersion()` for use in api-project. 2. Add property `config.nodeVersion` which has precedence over default Node 8. We want new projects to use the latest node version without setting any configuration but we don't want to break old projects. So during project creation, the value of `getLatestNodeVersion()` will be saved and then each deployment of that project will assign that value to `config.nodeVersion`. Implements [PRODUCT-837] [PRODUCT-837]: https://zeit.atlassian.net/browse/PRODUCT-837	2020-01-02 17:34:31 +00:00
JJ Kasper	56d3fed954	Publish Stable - @now/next@2.3.2	2019-12-31 15:56:54 -06:00
JJ Kasper	40bbff9bee	[now-next] Implement handle: miss for custom-routes (#3456 ) This implements `{ handle: 'miss' }` which will allow more efficiently checking dynamic routes after a matching rewrite. This is not fully available in production yet and the tests will fail for this PR until it is ready in Now x-ref: https://github.com/zeit/next.js/pull/9568	2019-12-31 19:36:50 +00:00