Publish

- @now/bash@0.2.0
 - @now/build-utils@0.5.0
 - @now/cgi@0.1.0
 - @now/go@0.4.0
 - @now/html-minifier@1.1.0
 - @now/lambda@0.5.0
 - @now/md@0.5.0
 - @now/mdx-deck@0.5.0
 - @now/next@0.2.0
 - @now/node-bridge@1.1.0
 - @now/node-server@0.6.0
 - @now/node@0.6.0
 - @now/optipng@0.5.0
 - @now/php-bridge@0.5.0
 - @now/php@0.5.0
 - @now/python@0.1.0
 - @now/rust@0.2.0
 - @now/static-build@0.5.0
 - @now/wordpress@0.5.0

.circleci/build.sh

@@ -0,0 +1,12 @@
+#!/bin/bash
+set -euo pipefail
+
+circleci_dir="$( cd "$( dirname "${BASH_SOURCE[0]}" )" >/dev/null 2>&1 && pwd )"
+needs_build="$(grep -rn '"build"' packages/*/package.json | cut -d: -f1)"
+
+for pkg in $needs_build; do
+  dir="$(dirname "$pkg")"
+  cd "$circleci_dir/../$dir"
+  echo "Building \`$dir\`"
+  yarn build
+done

.circleci/config.yml

@@ -20,21 +20,21 @@ jobs:
       - run:
           name: Bootstrapping
           command: yarn bootstrap
+      - run:
+          name: Building
+          command: ./.circleci/build.sh
       - run:
           name: Linting
           command: yarn lint
       - run:
-          name: Tests
-          command: yarn test
+          name: Tests and Coverage
+          command: yarn test-coverage
       - run:
           name: Potentially save npm token
           command: "([[ ! -z $NPM_TOKEN ]] && echo \"//registry.npmjs.org/:_authToken=$NPM_TOKEN\" >> ~/.npmrc) || echo \"Did not write npm token\""
       - run:
-          name: Potentially publish canary release
-          command: "if ls ~/.npmrc >/dev/null 2>&1 && [[ $(git describe --exact-match 2> /dev/null || :) =~ -canary ]]; then yarn run lerna publish from-git --npm-tag canary --yes; else  echo \"Did not publish\"; fi"
-      - run:
-          name: Potentially publish stable release
-          command: "if ls ~/.npmrc >/dev/null 2>&1 && [[ ! $(git describe --exact-match 2> /dev/null || :) =~ -canary ]]; then yarn run lerna publish from-git --yes; else  echo \"Did not publish\"; fi"
+          name: Potentially publish releases to npm
+          command: ./.circleci/publish.sh
 workflows:
   version: 2
   build-and-deploy:

.circleci/publish.sh

@@ -0,0 +1,24 @@
+#!/bin/bash
+set -euo pipefail
+
+if [ ! -e ~/.npmrc ]; then
+  echo "~/.npmrc file does not exist, skipping publish"
+  exit 0
+fi
+
+npm_tag=""
+tag="$(git describe --tags --exact-match 2> /dev/null || :)"
+
+if [ -z "$tag" ]; then
+  echo "Not a tagged commit, skipping publish"
+  exit 0
+fi
+
+if [[ "$tag" =~ -canary ]]; then
+  echo "Publishing canary release"
+  npm_tag="--npm-tag canary"
+else
+  echo "Publishing stable release"
+fi
+
+yarn run lerna publish from-git $npm_tag --yes

.eslintignore

@@ -2,3 +2,9 @@
 /node_modules/*
 /**/node_modules/*
 /packages/now-go/go/*
+/packages/now-build-utils/dist/*
+/packages/now-node/dist/*
+/packages/now-next/dist/*
+/packages/now-node-bridge/*
+/packages/now-python/*
+/packages/now-optipng/dist/*

.eslintrc

@@ -8,7 +8,7 @@
   },
   "overrides": [
     {
-      "files": ["test/**"],
+      "files": ["**/test/**"],
       "rules": {
         "import/no-extraneous-dependencies": 0
       },

.prettierrc.json

@@ -0,0 +1,4 @@
+{
+  "singleQuote": true,
+  "trailingComma": "es5"
+}

.vscode/settings.json

@@ -0,0 +1,3 @@
+{
+  "eslint.enable": false
+}

errors/now-next-no-serverless-pages-built.md

@@ -29,11 +29,13 @@ npm install next --save
 ```js
 module.exports = {
   target: 'serverless'
-  // Other options are still valid
+  // Other options
 }
 ```
 
-4. Optionally make sure the `"src"` in `"builds"` points to your application `package.json`
+4. Remove `distDir` from `next.config.js` as `@now/next` can't parse this file and expects your build output at `/.next`
+
+5. Optionally make sure the `"src"` in `"builds"` points to your application `package.json`
 
 ```js
 {

jest.config.js

@@ -1,4 +1,8 @@
 module.exports = {
   testEnvironment: 'node',
-  collectCoverageFrom: ['packages/**/*.{js,jsx}', '!**/node_modules/**'],
+  collectCoverageFrom: [
+    'packages/(!test)/**/*.{js,jsx}',
+    '!**/node_modules/**',
+    '!**/test/**',
+  ],
 };

package.json

@@ -14,16 +14,23 @@
     "bootstrap": "lerna bootstrap",
     "publish-stable": "lerna version",
     "publish-canary": "lerna version prerelease --preid canary",
-    "lint": "tsc && eslint .",
+    "build": "./.circleci/build.sh",
+    "lint": "eslint .",
+    "codecov": "codecov",
     "test": "jest --runInBand --verbose",
+    "test-coverage": "jest --runInBand --verbose --coverage --globals \"{\\\"coverage\\\":true}\" && codecov",
     "lint-staged": "lint-staged"
   },
   "pre-commit": "lint-staged",
   "lint-staged": {
     "*.js": [
-      "prettier --write --single-quote",
+      "prettier --write",
       "eslint --fix",
       "git add"
+    ],
+    "*.ts": [
+      "prettier --write",
+      "git add"
     ]
   },
   "devDependencies": {
@@ -33,6 +40,7 @@
     "@types/node": "^10.12.8",
     "async-retry": "1.2.3",
     "buffer-replace": "^1.0.0",
+    "codecov": "^3.2.0",
     "eslint": "^5.9.0",
     "eslint-config-airbnb-base": "^13.1.0",
     "eslint-config-prettier": "^3.1.0",
@@ -43,7 +51,6 @@
     "lint-staged": "^8.0.4",
     "node-fetch": "^2.3.0",
     "pre-commit": "^1.2.2",
-    "prettier": "^1.15.2",
-    "typescript": "^3.1.6"
+    "prettier": "^1.15.2"
   }
 }

packages/now-bash/bootstrap

@@ -7,7 +7,9 @@ export IMPORT_CACHE="$LAMBDA_TASK_ROOT/.import-cache"
 export PATH="$IMPORT_CACHE/bin:$PATH"
 
 # Load `import` and runtime
+# shellcheck disable=SC1090
 . "$(which import)"
+# shellcheck disable=SC1090
 . "$IMPORT_CACHE/runtime.sh"
 
 # Load user code and process events in a loop forever

packages/now-bash/index.js

@@ -12,9 +12,10 @@ exports.config = {
 
 exports.analyze = ({ files, entrypoint }) => files[entrypoint].digest;
 
-exports.build = async ({ files, entrypoint, config }) => {
+exports.build = async ({
+  workPath, files, entrypoint, config,
+}) => {
   const srcDir = await getWritableDirectory();
-  const workDir = await getWritableDirectory();
 
   console.log('downloading files...');
   await download(files, srcDir);
@@ -24,7 +25,7 @@ exports.build = async ({ files, entrypoint, config }) => {
     return o;
   }, {});
 
-  const IMPORT_CACHE = `${workDir}/.import-cache`;
+  const IMPORT_CACHE = `${workPath}/.import-cache`;
   const env = Object.assign({}, process.env, configEnv, {
     PATH: `${IMPORT_CACHE}/bin:${process.env.PATH}`,
     IMPORT_CACHE,
@@ -37,12 +38,12 @@ exports.build = async ({ files, entrypoint, config }) => {
 
   await execa(builderPath, [entrypoint], {
     env,
-    cwd: workDir,
+    cwd: workPath,
     stdio: 'inherit',
   });
 
   const lambda = await createLambda({
-    files: await glob('**', workDir),
+    files: await glob('**', workPath),
     handler: entrypoint, // not actually used in `bootstrap`
     runtime: 'provided',
     environment: Object.assign({}, configEnv, {

packages/now-bash/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@now/bash",
-  "version": "0.1.2",
+  "version": "0.2.0",
   "description": "Now 2.0 builder for HTTP endpoints written in Bash",
   "main": "index.js",
   "author": "Nathan Rajlich <nate@zeit.co>",

packages/now-bash/runtime.sh

@@ -1,3 +1,4 @@
+#!/bin/bash
 import "static-binaries@1.0.0"
 static_binaries jq
 
@@ -13,12 +14,14 @@ _lambda_runtime_api() {
 
 _lambda_runtime_init() {
 	# Initialize user code
+	# shellcheck disable=SC1090
 	. "$SCRIPT_FILENAME" || {
 		local exit_code="$?"
-		local error
-		error='{"exitCode":'"$exit_code"'}'
+		local error_message="Initialization failed for '$SCRIPT_FILENAME' (exit code $exit_code)"
+		echo "$error_message" >&2
+		local error='{"errorMessage":"'"$error_message"'"}'
 		_lambda_runtime_api "init/error" -X POST -d "$error"
-		exit "$EXIT_CODE"
+		exit "$exit_code"
 	}
 
 	# Process events
@@ -45,18 +48,17 @@ _lambda_runtime_next() {
 	local body
 	body="$(mktemp)"
 
-	local exit_code=0
-	REQUEST="$event"
-
 	# Stdin of the `handler` function is the HTTP request body.
 	# Need to use a fifo here instead of bash <() because Lambda
 	# errors with "/dev/fd/63 not found" for some reason :/
 	local stdin
 	stdin="$(mktemp -u)"
 	mkfifo "$stdin"
-	_lambda_runtime_body "$event" > "$stdin" &
+	_lambda_runtime_body < "$event" > "$stdin" &
 
+	local exit_code=0
 	handler "$event" < "$stdin" > "$body" || exit_code="$?"
+
 	rm -f "$event" "$stdin"
 
 	if [ "$exit_code" -eq 0 ]; then
@@ -68,18 +70,21 @@ _lambda_runtime_next() {
 			| _lambda_runtime_api "invocation/$request_id/response" -X POST -d @- > /dev/null
 		rm -f "$body" "$_HEADERS"
 	else
-		echo "\`handler\` function return code: $exit_code"
-		_lambda_runtime_api "invocation/$request_id/error" -X POST -d @- > /dev/null <<< '{"exitCode":'"$exit_code"'}'
+		local error_message="Invocation failed for 'handler' function in '$SCRIPT_FILENAME' (exit code $exit_code)"
+		echo "$error_message" >&2
+		_lambda_runtime_api "invocation/$request_id/error" -X POST -d '{"errorMessage":"'"$error_message"'"}' > /dev/null
 	fi
 }
 
 _lambda_runtime_body() {
-	if [ "$(jq --raw-output '.body | type' < "$1")" = "string" ]; then
-		if [ "$(jq --raw-output '.encoding' < "$1")" = "base64" ]; then
-			jq --raw-output '.body' < "$1" | base64 -d
+	local event
+	event="$(cat)"
+	if [ "$(jq --raw-output '.body | type' <<< "$event")" = "string" ]; then
+		if [ "$(jq --raw-output '.encoding' <<< "$event")" = "base64" ]; then
+			jq --raw-output '.body' <<< "$event" | base64 --decode
 		else
 			# assume plain-text body
-			jq --raw-output '.body' < "$1"
+			jq --raw-output '.body' <<< "$event"
 		fi
 	fi
 }
@@ -97,7 +102,10 @@ http_response_header() {
 	local value="$2"
 	local tmp
 	tmp="$(mktemp)"
-	jq --arg name "$name" --arg value "$value" '.[$name] = $value' < "$_HEADERS" > "$tmp"
+	jq \
+		--arg name "$name" \
+		--arg value "$value" \
+		'.[$name] = $value' < "$_HEADERS" > "$tmp"
 	mv -f "$tmp" "$_HEADERS"
 }
 

packages/now-build-utils/.gitignore

@@ -0,0 +1,3 @@
+dist
+test/symlinks-out
+test/symlinks.zip

packages/now-build-utils/.npmignore

@@ -1,2 +1,3 @@
+/src
 /test
 tmp

packages/now-build-utils/file-blob.js

@@ -1,33 +1 @@
-const assert = require('assert');
-const intoStream = require('into-stream');
-
-class FileBlob {
-  constructor({ mode = 0o100644, data }) {
-    assert(typeof mode === 'number');
-    assert(typeof data === 'string' || Buffer.isBuffer(data));
-    this.type = 'FileBlob';
-    this.mode = mode;
-    this.data = data;
-  }
-
-  static async fromStream({ mode = 0o100644, stream }) {
-    assert(typeof mode === 'number');
-    assert(typeof stream.pipe === 'function'); // is-stream
-    const chunks = [];
-
-    await new Promise((resolve, reject) => {
-      stream.on('data', chunk => chunks.push(Buffer.from(chunk)));
-      stream.on('error', error => reject(error));
-      stream.on('end', () => resolve());
-    });
-
-    const data = Buffer.concat(chunks);
-    return new FileBlob({ mode, data });
-  }
-
-  toStream() {
-    return intoStream(this.data);
-  }
-}
-
-module.exports = FileBlob;
+module.exports = require('./dist/index').FileBlob;

packages/now-build-utils/file-fs-ref.js

@@ -1,100 +1 @@
-const assert = require('assert');
-const fs = require('fs-extra');
-const multiStream = require('multistream');
-const path = require('path');
-const Sema = require('async-sema');
-
-/** @typedef {{[filePath: string]: FileFsRef}} FsFiles */
-
-const semaToPreventEMFILE = new Sema(30);
-
-/**
- * @constructor
- * @argument {Object} options
- * @argument {number} [options.mode=0o100644]
- * @argument {string} options.fsPath
- */
-class FileFsRef {
-  constructor({ mode = 0o100644, fsPath }) {
-    assert(typeof mode === 'number');
-    assert(typeof fsPath === 'string');
-    /** @type {string} */
-    this.type = 'FileFsRef';
-    /** @type {number} */
-    this.mode = mode;
-    /** @type {string} */
-    this.fsPath = fsPath;
-  }
-
-  /**
-   * Creates a `FileFsRef` with the correct `mode` from the file system.
-   *
-   * @argument {Object} options
-   * @argument {string} options.fsPath
-   * @returns {Promise<FileFsRef>}
-   */
-  static async fromFsPath({ fsPath }) {
-    const { mode } = await fs.lstat(fsPath);
-    return new FileFsRef({ mode, fsPath });
-  }
-
-  /**
-   * @argument {Object} options
-   * @argument {number} [options.mode=0o100644]
-   * @argument {NodeJS.ReadableStream} options.stream
-   * @argument {string} options.fsPath
-   * @returns {Promise<FileFsRef>}
-   */
-  static async fromStream({ mode = 0o100644, stream, fsPath }) {
-    assert(typeof mode === 'number');
-    assert(typeof stream.pipe === 'function'); // is-stream
-    assert(typeof fsPath === 'string');
-    await fs.mkdirp(path.dirname(fsPath));
-
-    await new Promise((resolve, reject) => {
-      const dest = fs.createWriteStream(fsPath);
-      stream.pipe(dest);
-      stream.on('error', reject);
-      dest.on('finish', resolve);
-      dest.on('error', reject);
-    });
-
-    await fs.chmod(fsPath, mode.toString(8).slice(-3));
-    return new FileFsRef({ mode, fsPath });
-  }
-
-  /**
-   * @returns {Promise<NodeJS.ReadableStream>}
-   */
-  async toStreamAsync() {
-    await semaToPreventEMFILE.acquire();
-    const release = () => semaToPreventEMFILE.release();
-    const stream = fs.createReadStream(this.fsPath);
-    stream.on('close', release);
-    stream.on('error', release);
-    return stream;
-  }
-
-  /**
-   * @returns {NodeJS.ReadableStream}
-   */
-  toStream() {
-    let flag;
-
-    // eslint-disable-next-line consistent-return
-    return multiStream((cb) => {
-      if (flag) return cb(null, null);
-      flag = true;
-
-      this.toStreamAsync()
-        .then((stream) => {
-          cb(null, stream);
-        })
-        .catch((error) => {
-          cb(error, null);
-        });
-    });
-  }
-}
-
-module.exports = FileFsRef;
+module.exports = require('./dist/index').FileFsRef;

packages/now-build-utils/file-ref.js

@@ -1,96 +1 @@
-const assert = require('assert');
-const fetch = require('node-fetch');
-const multiStream = require('multistream');
-const retry = require('async-retry');
-const Sema = require('async-sema');
-
-/** @typedef {{[filePath: string]: FileRef}} Files */
-
-const semaToDownloadFromS3 = new Sema(10);
-
-class BailableError extends Error {
-  constructor(...args) {
-    super(...args);
-    /** @type {boolean} */
-    this.bail = false;
-  }
-}
-
-/**
- * @constructor
- * @argument {Object} options
- * @argument {number} [options.mode=0o100644]
- * @argument {string} options.digest
- */
-class FileRef {
-  constructor({ mode = 0o100644, digest }) {
-    assert(typeof mode === 'number');
-    assert(typeof digest === 'string');
-    /** @type {string} */
-    this.type = 'FileRef';
-    /** @type {number} */
-    this.mode = mode;
-    /** @type {string} */
-    this.digest = digest;
-  }
-
-  /**
-   * @returns {Promise<NodeJS.ReadableStream>}
-   */
-  async toStreamAsync() {
-    let url;
-    // sha:24be087eef9fac01d61b30a725c1a10d7b45a256
-    const digestParts = this.digest.split(':');
-    if (digestParts[0] === 'sha') {
-      // url = `https://s3.amazonaws.com/now-files/${digestParts[1]}`;
-      url = `https://dmmcy0pwk6bqi.cloudfront.net/${digestParts[1]}`;
-    }
-
-    assert(url);
-
-    await semaToDownloadFromS3.acquire();
-    // console.time(`downloading ${url}`);
-    try {
-      return await retry(
-        async () => {
-          const resp = await fetch(url);
-          if (!resp.ok) {
-            const error = new BailableError(
-              `download: ${resp.status} ${resp.statusText} for ${url}`,
-            );
-            if (resp.status === 403) error.bail = true;
-            throw error;
-          }
-          return resp.body;
-        },
-        { factor: 1, retries: 3 },
-      );
-    } finally {
-      // console.timeEnd(`downloading ${url}`);
-      semaToDownloadFromS3.release();
-    }
-  }
-
-  /**
-   * @returns {NodeJS.ReadableStream}
-   */
-  toStream() {
-    let flag;
-
-    // eslint-disable-next-line consistent-return
-    return multiStream((cb) => {
-      if (flag) return cb(null, null);
-      flag = true;
-
-      this.toStreamAsync()
-        .then((stream) => {
-          cb(null, stream);
-        })
-        .catch((error) => {
-          cb(error, null);
-        });
-    });
-  }
-}
-
-module.exports = FileRef;
+module.exports = require('./dist/index').FileRef;

packages/now-build-utils/fs/download.js

@@ -1,38 +1 @@
-const path = require('path');
-const FileFsRef = require('../file-fs-ref.js');
-
-/** @typedef {import('../file-ref')} FileRef */
-/** @typedef {import('../file-fs-ref')} FileFsRef */
-/** @typedef {{[filePath: string]: FileRef|FileFsRef}} Files */
-/** @typedef {{[filePath: string]: FileFsRef}|{}} DownloadedFiles */
-
-/**
- * @param {FileRef|FileFsRef} file
- * @param {string} fsPath
- * @returns {Promise<FileFsRef>}
- */
-async function downloadFile(file, fsPath) {
-  const { mode } = file;
-  const stream = file.toStream();
-  return FileFsRef.fromStream({ mode, stream, fsPath });
-}
-
-/**
- * Download files to disk
- * @argument {Files} files
- * @argument {string} basePath
- * @returns {Promise<DownloadedFiles>}
- */
-module.exports = async function download(files, basePath) {
-  const files2 = {};
-
-  await Promise.all(
-    Object.keys(files).map(async (name) => {
-      const file = files[name];
-      const fsPath = path.join(basePath, name);
-      files2[name] = await downloadFile(file, fsPath);
-    }),
-  );
-
-  return files2;
-};
+module.exports = require('../dist/fs/download').default;

packages/now-build-utils/fs/get-writable-directory.js

@@ -1,12 +1 @@
-const path = require('path');
-const fs = require('fs-extra');
-
-const prod = process.env.AWS_EXECUTION_ENV || process.env.X_GOOGLE_CODE_LOCATION;
-const TMP_PATH = prod ? '/tmp' : path.join(__dirname, 'tmp');
-
-module.exports = async function getWritableDirectory() {
-  const name = Math.floor(Math.random() * 0x7fffffff).toString(16);
-  const directory = path.join(TMP_PATH, name);
-  await fs.mkdirp(directory);
-  return directory;
-};
+module.exports = require('../dist/fs/get-writable-directory').default;

packages/now-build-utils/fs/glob.js

@@ -1,67 +1 @@
-const assert = require('assert');
-const path = require('path');
-const vanillaGlob = require('glob');
-const FileFsRef = require('../file-fs-ref.js');
-
-/** @typedef {import('fs').Stats} Stats */
-/** @typedef {import('glob').IOptions} GlobOptions */
-/** @typedef {import('../file-fs-ref').FsFiles|{}} GlobFiles */
-
-/**
- * @argument {string} pattern
- * @argument {GlobOptions|string} opts
- * @argument {string} [mountpoint]
- * @returns {Promise<GlobFiles>}
- */
-module.exports = function glob(pattern, opts = {}, mountpoint) {
-  return new Promise((resolve, reject) => {
-    /** @type {GlobOptions} */
-    let options;
-    if (typeof opts === 'string') {
-      options = { cwd: opts };
-    } else {
-      options = opts;
-    }
-
-    if (!options.cwd) {
-      throw new Error(
-        'Second argument (basePath) must be specified for names of resulting files',
-      );
-    }
-
-    if (!path.isAbsolute(options.cwd)) {
-      throw new Error(`basePath/cwd must be an absolute path (${options.cwd})`);
-    }
-
-    options.statCache = {};
-    options.stat = true;
-    options.dot = true;
-
-    // eslint-disable-next-line consistent-return
-    vanillaGlob(pattern, options, (error, files) => {
-      if (error) return reject(error);
-
-      resolve(
-        files.reduce((files2, relativePath) => {
-          const fsPath = path.join(options.cwd, relativePath);
-          /** @type {Stats|any} */
-          const stat = options.statCache[fsPath];
-          assert(
-            stat,
-            `statCache does not contain value for ${relativePath} (resolved to ${fsPath})`,
-          );
-          if (stat && stat.isFile()) {
-            let finalPath = relativePath;
-            if (mountpoint) finalPath = path.join(mountpoint, finalPath);
-            return {
-              ...files2,
-              [finalPath]: new FileFsRef({ mode: stat.mode, fsPath }),
-            };
-          }
-
-          return files2;
-        }, {}),
-      );
-    });
-  });
-};
+module.exports = require('../dist/fs/glob').default;

packages/now-build-utils/fs/rename.js

@@ -1,25 +1 @@
-/** @typedef { import('@now/build-utils/file-ref') } FileRef */
-/** @typedef { import('@now/build-utils/file-fs-ref') } FileFsRef */
-/** @typedef {{[filePath: string]: FileRef|FileFsRef}} Files */
-
-/**
- * @callback delegate
- * @argument {string} name
- * @returns {string}
- */
-
-/**
- * Rename files using delegate function
- * @argument {Files} files
- * @argument {delegate} delegate
- * @returns {Files}
- */
-module.exports = function rename(files, delegate) {
-  return Object.keys(files).reduce(
-    (newFiles, name) => ({
-      ...newFiles,
-      [delegate(name)]: files[name],
-    }),
-    {},
-  );
-};
+module.exports = require('../dist/fs/rename').default;

packages/now-build-utils/fs/run-user-scripts.js

@@ -1,96 +1 @@
-const assert = require('assert');
-const fs = require('fs-extra');
-const path = require('path');
-const { spawn } = require('child_process');
-
-function spawnAsync(command, args, cwd) {
-  return new Promise((resolve, reject) => {
-    const child = spawn(command, args, { stdio: 'inherit', cwd });
-    child.on('error', reject);
-    child.on('close', (code, signal) => (code !== 0
-      ? reject(new Error(`Exited with ${code || signal}`))
-      : resolve()));
-  });
-}
-
-async function runShellScript(fsPath) {
-  assert(path.isAbsolute(fsPath));
-  const destPath = path.dirname(fsPath);
-  await spawnAsync(`./${path.basename(fsPath)}`, [], destPath);
-  return true;
-}
-
-async function scanParentDirs(destPath, scriptName) {
-  assert(path.isAbsolute(destPath));
-
-  let hasScript = false;
-  let hasPackageLockJson = false;
-  let currentDestPath = destPath;
-
-  // eslint-disable-next-line no-constant-condition
-  while (true) {
-    const packageJsonPath = path.join(currentDestPath, 'package.json');
-    // eslint-disable-next-line no-await-in-loop
-    if (await fs.exists(packageJsonPath)) {
-      // eslint-disable-next-line no-await-in-loop
-      const packageJson = JSON.parse(await fs.readFile(packageJsonPath));
-      hasScript = Boolean(
-        packageJson.scripts && scriptName && packageJson.scripts[scriptName],
-      );
-      // eslint-disable-next-line no-await-in-loop
-      hasPackageLockJson = await fs.exists(
-        path.join(currentDestPath, 'package-lock.json'),
-      );
-      break;
-    }
-
-    const newDestPath = path.dirname(currentDestPath);
-    if (currentDestPath === newDestPath) break;
-    currentDestPath = newDestPath;
-  }
-
-  return { hasScript, hasPackageLockJson };
-}
-
-async function installDependencies(destPath, args = []) {
-  assert(path.isAbsolute(destPath));
-
-  let commandArgs = args;
-  console.log(`installing to ${destPath}`);
-  const { hasPackageLockJson } = await scanParentDirs(destPath);
-
-  if (hasPackageLockJson) {
-    commandArgs = args.filter(a => a !== '--prefer-offline');
-    await spawnAsync('npm', ['install'].concat(commandArgs), destPath);
-    await spawnAsync('npm', ['cache', 'clean', '--force'], destPath);
-  } else {
-    await spawnAsync('yarn', ['--cwd', destPath].concat(commandArgs), destPath);
-    await spawnAsync('yarn', ['cache', 'clean'], destPath);
-  }
-}
-
-async function runPackageJsonScript(destPath, scriptName) {
-  assert(path.isAbsolute(destPath));
-  const { hasScript, hasPackageLockJson } = await scanParentDirs(
-    destPath,
-    scriptName,
-  );
-  if (!hasScript) return false;
-
-  if (hasPackageLockJson) {
-    console.log(`running "npm run ${scriptName}"`);
-    await spawnAsync('npm', ['run', scriptName], destPath);
-  } else {
-    console.log(`running "yarn run ${scriptName}"`);
-    await spawnAsync('yarn', ['--cwd', destPath, 'run', scriptName], destPath);
-  }
-
-  return true;
-}
-
-module.exports = {
-  runShellScript,
-  installDependencies,
-  runNpmInstall: installDependencies,
-  runPackageJsonScript,
-};
+module.exports = require('../dist/fs/run-user-scripts');

packages/now-build-utils/fs/stream-to-buffer.js

@@ -1,4 +1 @@
-const fastStreamToBuffer = require('fast-stream-to-buffer');
-const { promisify } = require('util');
-
-module.exports = promisify(fastStreamToBuffer);
+module.exports = require('../dist/fs/stream-to-buffer').default;

packages/now-build-utils/lambda.js

@@ -1,60 +1 @@
-const assert = require('assert');
-const Sema = require('async-sema');
-const { ZipFile } = require('yazl');
-const streamToBuffer = require('./fs/stream-to-buffer.js');
-
-class Lambda {
-  constructor({
-    zipBuffer, handler, runtime, environment,
-  }) {
-    this.type = 'Lambda';
-    this.zipBuffer = zipBuffer;
-    this.handler = handler;
-    this.runtime = runtime;
-    this.environment = environment;
-  }
-}
-
-const sema = new Sema(10);
-const mtime = new Date(1540000000000);
-
-async function createLambda({
-  files, handler, runtime, environment = {},
-}) {
-  assert(typeof files === 'object', '"files" must be an object');
-  assert(typeof handler === 'string', '"handler" is not a string');
-  assert(typeof runtime === 'string', '"runtime" is not a string');
-  assert(typeof environment === 'object', '"environment" is not an object');
-
-  await sema.acquire();
-  try {
-    const zipFile = new ZipFile();
-    const zipBuffer = await new Promise((resolve, reject) => {
-      Object.keys(files)
-        .sort()
-        .forEach((name) => {
-          const file = files[name];
-          const stream = file.toStream();
-          stream.on('error', reject);
-          zipFile.addReadStream(stream, name, { mode: file.mode, mtime });
-        });
-
-      zipFile.end();
-      streamToBuffer(zipFile.outputStream).then(resolve).catch(reject);
-    });
-
-    return new Lambda({
-      zipBuffer,
-      handler,
-      runtime,
-      environment,
-    });
-  } finally {
-    sema.release();
-  }
-}
-
-module.exports = {
-  Lambda,
-  createLambda,
-};
+module.exports = require('./dist/index');

packages/now-build-utils/package.json

@@ -1,7 +1,9 @@
 {
   "name": "@now/build-utils",
-  "version": "0.4.35-canary.2",
+  "version": "0.5.0",
   "license": "MIT",
+  "main": "./dist/index.js",
+  "types": "./dist/index.d.js",
   "repository": {
     "type": "git",
     "url": "https://github.com/zeit/now-builders.git",
@@ -10,16 +12,28 @@
   "dependencies": {
     "async-retry": "1.2.3",
     "async-sema": "2.1.4",
-    "fast-stream-to-buffer": "1.0.0",
+    "end-of-stream": "1.4.1",
     "fs-extra": "7.0.0",
     "glob": "7.1.3",
-    "into-stream": "4.0.0",
+    "into-stream": "5.0.0",
     "memory-fs": "0.4.1",
     "multistream": "2.1.1",
     "node-fetch": "2.2.0",
     "yazl": "2.4.3"
   },
   "scripts": {
-    "test": "jest"
+    "build": "tsc",
+    "test": "tsc && jest",
+    "prepublish": "tsc"
+  },
+  "devDependencies": {
+    "@types/async-retry": "^1.2.1",
+    "@types/end-of-stream": "^1.4.0",
+    "@types/fs-extra": "^5.0.5",
+    "@types/glob": "^7.1.1",
+    "@types/node-fetch": "^2.1.6",
+    "@types/yazl": "^2.4.1",
+    "execa": "^1.0.0",
+    "typescript": "3.3.4000"
   }
 }

packages/now-build-utils/src/file-blob.ts

@@ -0,0 +1,46 @@
+import assert from 'assert';
+import intoStream from 'into-stream';
+import { File } from './types';
+
+interface FileBlobOptions {
+  mode?: number;
+  data: string | Buffer;
+}
+
+interface FromStreamOptions {
+  mode?: number;
+  stream: NodeJS.ReadableStream;
+}
+
+export default class FileBlob implements File {
+  public type: 'FileBlob';
+  public mode: number;
+  public data: string | Buffer;
+
+  constructor({ mode = 0o100644, data }: FileBlobOptions) {
+    assert(typeof mode === 'number');
+    assert(typeof data === 'string' || Buffer.isBuffer(data));
+    this.type = 'FileBlob';
+    this.mode = mode;
+    this.data = data;
+  }
+
+  static async fromStream({ mode = 0o100644, stream }: FromStreamOptions) {
+    assert(typeof mode === 'number');
+    assert(typeof stream.pipe === 'function'); // is-stream
+    const chunks: Buffer[] = [];
+
+    await new Promise<void>((resolve, reject) => {
+      stream.on('data', chunk => chunks.push(Buffer.from(chunk)));
+      stream.on('error', error => reject(error));
+      stream.on('end', () => resolve());
+    });
+
+    const data = Buffer.concat(chunks);
+    return new FileBlob({ mode, data });
+  }
+
+  toStream(): NodeJS.ReadableStream {
+    return intoStream(this.data);
+  }
+}

packages/now-build-utils/src/file-fs-ref.ts

@@ -0,0 +1,90 @@
+import assert from 'assert';
+import fs from 'fs-extra';
+import multiStream from 'multistream';
+import path from 'path';
+import Sema from 'async-sema';
+import { File } from './types';
+
+const semaToPreventEMFILE = new Sema(20);
+
+interface FileFsRefOptions {
+  mode?: number;
+  fsPath: string;
+}
+
+interface FromStreamOptions {
+  mode: number;
+  stream: NodeJS.ReadableStream;
+  fsPath: string;
+}
+
+class FileFsRef implements File {
+  public type: 'FileFsRef';
+  public mode: number;
+  public fsPath: string;
+
+  constructor({ mode = 0o100644, fsPath }: FileFsRefOptions) {
+    assert(typeof mode === 'number');
+    assert(typeof fsPath === 'string');
+    this.type = 'FileFsRef';
+    this.mode = mode;
+    this.fsPath = fsPath;
+  }
+
+  static async fromFsPath({ mode, fsPath }: FileFsRefOptions): Promise<FileFsRef> {
+    let m = mode;
+    if (!m) {
+      const stat = await fs.lstat(fsPath);
+      m = stat.mode;
+    }
+    return new FileFsRef({ mode: m, fsPath });
+  }
+
+  static async fromStream({ mode = 0o100644, stream, fsPath }: FromStreamOptions): Promise<FileFsRef> {
+    assert(typeof mode === 'number');
+    assert(typeof stream.pipe === 'function'); // is-stream
+    assert(typeof fsPath === 'string');
+    await fs.mkdirp(path.dirname(fsPath));
+
+    await new Promise<void>((resolve, reject) => {
+      const dest = fs.createWriteStream(fsPath, {
+        mode: mode & 0o777
+      });
+      stream.pipe(dest);
+      stream.on('error', reject);
+      dest.on('finish', resolve);
+      dest.on('error', reject);
+    });
+
+    return new FileFsRef({ mode, fsPath });
+  }
+
+  async toStreamAsync(): Promise<NodeJS.ReadableStream> {
+    await semaToPreventEMFILE.acquire();
+    const release = () => semaToPreventEMFILE.release();
+    const stream = fs.createReadStream(this.fsPath);
+    stream.on('close', release);
+    stream.on('error', release);
+    return stream;
+  }
+
+  toStream(): NodeJS.ReadableStream {
+    let flag = false;
+
+    // eslint-disable-next-line consistent-return
+    return multiStream((cb) => {
+      if (flag) return cb(null, null);
+      flag = true;
+
+      this.toStreamAsync()
+        .then((stream) => {
+          cb(null, stream);
+        })
+        .catch((error) => {
+          cb(error, null);
+        });
+    });
+  }
+}
+
+export = FileFsRef;

packages/now-build-utils/src/file-ref.ts

@@ -0,0 +1,93 @@
+import assert from 'assert';
+import fetch from 'node-fetch';
+import multiStream from 'multistream';
+import retry from 'async-retry';
+import Sema from 'async-sema';
+import { File } from './types';
+
+interface FileRefOptions {
+  mode?: number;
+  digest: string;
+  mutable?: boolean;
+}
+
+const semaToDownloadFromS3 = new Sema(5);
+
+class BailableError extends Error {
+  public bail: boolean;
+
+  constructor(...args: string[]) {
+    super(...args);
+    this.bail = false;
+  }
+}
+
+export default class FileRef implements File {
+  public type: 'FileRef';
+  public mode: number;
+  public digest: string;
+  public mutable: boolean;
+
+  constructor({ mode = 0o100644, digest, mutable = false }: FileRefOptions) {
+    assert(typeof mode === 'number');
+    assert(typeof digest === 'string');
+    assert(typeof mutable === 'boolean');
+    this.type = 'FileRef';
+    this.mode = mode;
+    this.digest = digest;
+    this.mutable = mutable;
+  }
+
+  async toStreamAsync(): Promise<NodeJS.ReadableStream> {
+    let url = '';
+    // sha:24be087eef9fac01d61b30a725c1a10d7b45a256
+    const digestParts = this.digest.split(':');
+    if (digestParts[0] === 'sha') {
+      url = this.mutable
+        ? `https://s3.amazonaws.com/now-files/${digestParts[1]}`
+        : `https://dmmcy0pwk6bqi.cloudfront.net/${digestParts[1]}`;
+    } else {
+      throw new Error('Expected digest to be sha');
+    }
+
+    await semaToDownloadFromS3.acquire();
+    // console.time(`downloading ${url}`);
+    try {
+      return await retry(
+        async () => {
+          const resp = await fetch(url);
+          if (!resp.ok) {
+            const error = new BailableError(
+              `download: ${resp.status} ${resp.statusText} for ${url}`,
+            );
+            if (resp.status === 403) error.bail = true;
+            throw error;
+          }
+          return resp.body;
+        },
+        { factor: 1, retries: 3 },
+      );
+    } finally {
+      // console.timeEnd(`downloading ${url}`);
+      semaToDownloadFromS3.release();
+    }
+  }
+
+  toStream(): NodeJS.ReadableStream {
+    let flag = false;
+
+    // eslint-disable-next-line consistent-return
+    return multiStream((cb) => {
+      if (flag) return cb(null, null);
+      flag = true;
+
+      this.toStreamAsync()
+        .then((stream) => {
+          cb(null, stream);
+        })
+        .catch((error) => {
+          cb(error, null);
+        });
+    });
+  }
+}

packages/now-build-utils/src/fs/download.ts

@@ -0,0 +1,62 @@
+import path from 'path';
+import FileFsRef from '../file-fs-ref';
+import { File, Files, Meta } from '../types';
+import { remove, mkdirp, readlink, symlink } from 'fs-extra';
+
+export interface DownloadedFiles {
+  [filePath: string]: FileFsRef
+}
+
+const S_IFMT = 61440;   /* 0170000 type of file */
+const S_IFLNK = 40960;  /* 0120000 symbolic link */
+
+export function isSymbolicLink(mode: number): boolean {
+  return (mode & S_IFMT) === S_IFLNK;
+}
+
+async function downloadFile(file: File, fsPath: string): Promise<FileFsRef> {
+  const { mode } = file;
+  if (mode && isSymbolicLink(mode) && file.type === 'FileFsRef') {
+    const [ target ] = await Promise.all([
+      readlink((file as FileFsRef).fsPath),
+      mkdirp(path.dirname(fsPath))
+    ]);
+    await symlink(target, fsPath);
+    return FileFsRef.fromFsPath({ mode, fsPath });
+  } else {
+    const stream = file.toStream();
+    return FileFsRef.fromStream({ mode, stream, fsPath });
+  }
+}
+
+async function removeFile(basePath: string, fileMatched: string) {
+  const file = path.join(basePath, fileMatched);
+  await remove(file);
+}
+
+export default async function download(files: Files, basePath: string, meta?: Meta): Promise<DownloadedFiles> {
+  const files2: DownloadedFiles = {};
+  const { filesChanged = null, filesRemoved = null } = meta || {};
+
+  await Promise.all(
+    Object.keys(files).map(async (name) => {
+      // If the file does not exist anymore, remove it.
+      if (Array.isArray(filesRemoved) && filesRemoved.includes(name)) {
+        await removeFile(basePath, name);
+        return;
+      }
+
+      // If a file didn't change, do not re-download it.
+      if (Array.isArray(filesChanged) && !filesChanged.includes(name)) {
+        return;
+      }
+
+      const file = files[name];
+      const fsPath = path.join(basePath, name);
+
+      files2[name] = await downloadFile(file, fsPath);
+    }),
+  );
+
+  return files2;
+}

packages/now-build-utils/src/fs/get-writable-directory.ts

@@ -0,0 +1,10 @@
+import { join } from 'path';
+import { tmpdir } from 'os';
+import { mkdirp } from 'fs-extra';
+
+export default async function getWritableDirectory() {
+  const name = Math.floor(Math.random() * 0x7fffffff).toString(16);
+  const directory = join(tmpdir(), name);
+  await mkdirp(directory);
+  return directory;
+}

packages/now-build-utils/src/fs/glob.ts

@@ -0,0 +1,66 @@
+import path from 'path';
+import assert from 'assert';
+import vanillaGlob_ from 'glob';
+import { promisify } from 'util';
+import { lstat, Stats } from 'fs-extra';
+import FileFsRef from '../file-fs-ref';
+
+type GlobOptions = vanillaGlob_.IOptions;
+
+interface FsFiles {
+  [filePath: string]: FileFsRef
+}
+
+const vanillaGlob = promisify(vanillaGlob_);
+
+export default async function glob(pattern: string, opts: GlobOptions | string, mountpoint?: string): Promise<FsFiles> {
+  let options: GlobOptions;
+  if (typeof opts === 'string') {
+    options = { cwd: opts };
+  } else {
+    options = opts;
+  }
+
+  if (!options.cwd) {
+    throw new Error(
+      'Second argument (basePath) must be specified for names of resulting files',
+    );
+  }
+
+  if (!path.isAbsolute(options.cwd)) {
+    throw new Error(`basePath/cwd must be an absolute path (${options.cwd})`);
+  }
+
+  const results: FsFiles = {};
+
+  options.symlinks = {};
+  options.statCache = {};
+  options.stat = true;
+  options.dot = true;
+
+  const files = await vanillaGlob(pattern, options);
+
+  for (const relativePath of files) {
+    const fsPath = path.join(options.cwd!, relativePath);
+    let stat: Stats = options.statCache![fsPath] as Stats;
+    assert(
+      stat,
+      `statCache does not contain value for ${relativePath} (resolved to ${fsPath})`,
+    );
+    if (stat.isFile()) {
+      const isSymlink = options.symlinks![fsPath];
+      if (isSymlink) {
+        stat = await lstat(fsPath);
+      }
+
+      let finalPath = relativePath;
+      if (mountpoint) {
+        finalPath = path.join(mountpoint, finalPath);
+      }
+
+      results[finalPath] = new FileFsRef({ mode: stat.mode, fsPath });
+    }
+  }
+
+  return results;
+}

packages/now-build-utils/src/fs/rename.ts

@@ -0,0 +1,12 @@
+import { Files } from '../types';
+type Delegate = (name: string) => string;
+
+export default function rename(files: Files, delegate: Delegate): Files {
+  return Object.keys(files).reduce(
+    (newFiles, name) => ({
+      ...newFiles,
+      [delegate(name)]: files[name],
+    }),
+    {},
+  );
+}

packages/now-build-utils/src/fs/run-user-scripts.ts

@@ -0,0 +1,138 @@
+import assert from 'assert';
+import fs from 'fs-extra';
+import path from 'path';
+import { spawn, SpawnOptions } from 'child_process';
+
+function spawnAsync(command: string, args: string[], cwd: string, opts: SpawnOptions = {}) {
+  return new Promise<void>((resolve, reject) => {
+    const stderrLogs: Buffer[] = []
+    opts = { stdio: 'inherit', cwd, ...opts };
+    const child = spawn(command, args, opts);
+
+    if (opts.stdio === 'pipe'){
+      child.stderr.on('data', data => stderrLogs.push(data));
+    }
+
+    child.on('error', reject);
+    child.on('close', (code, signal) => {
+      if (code === 0) {
+        return resolve()
+      }
+
+      const errorLogs = stderrLogs.map(line => line.toString()).join('');
+      if (opts.stdio !== 'inherit') {
+        reject(new Error(`Exited with ${code || signal}\n${errorLogs}`));
+      } else {
+        reject(new Error(`Exited with ${code || signal}`));
+      }
+    });
+  });
+}
+
+async function chmodPlusX(fsPath: string) {
+  const s = await fs.stat(fsPath);
+  const newMode = s.mode | 64 | 8 | 1; // eslint-disable-line no-bitwise
+  if (s.mode === newMode) return;
+  const base8 = newMode.toString(8).slice(-3);
+  await fs.chmod(fsPath, base8);
+}
+
+export async function runShellScript(fsPath: string) {
+  assert(path.isAbsolute(fsPath));
+  const destPath = path.dirname(fsPath);
+  await chmodPlusX(fsPath);
+  await spawnAsync(`./${path.basename(fsPath)}`, [], destPath);
+  return true;
+}
+
+async function scanParentDirs(destPath: string, scriptName?: string) {
+  assert(path.isAbsolute(destPath));
+
+  let hasScript = false;
+  let hasPackageLockJson = false;
+  let currentDestPath = destPath;
+
+  // eslint-disable-next-line no-constant-condition
+  while (true) {
+    const packageJsonPath = path.join(currentDestPath, 'package.json');
+    // eslint-disable-next-line no-await-in-loop
+    if (await fs.pathExists(packageJsonPath)) {
+      // eslint-disable-next-line no-await-in-loop
+      const packageJson = JSON.parse(await fs.readFile(packageJsonPath, 'utf8'));
+      hasScript = Boolean(
+        packageJson.scripts && scriptName && packageJson.scripts[scriptName],
+      );
+      // eslint-disable-next-line no-await-in-loop
+      hasPackageLockJson = await fs.pathExists(
+        path.join(currentDestPath, 'package-lock.json'),
+      );
+      break;
+    }
+
+    const newDestPath = path.dirname(currentDestPath);
+    if (currentDestPath === newDestPath) break;
+    currentDestPath = newDestPath;
+  }
+
+  return { hasScript, hasPackageLockJson };
+}
+
+export async function installDependencies(destPath: string, args: string[] = []) {
+  assert(path.isAbsolute(destPath));
+
+  let commandArgs = args;
+  console.log(`installing to ${destPath}`);
+  const { hasPackageLockJson } = await scanParentDirs(destPath);
+
+  const opts = {
+    env: {
+      ...process.env,
+      // This is a little hack to force `node-gyp` to build for the
+      // Node.js version that `@now/node` and `@now/node-server` use
+      npm_config_target: '8.10.0',
+    },
+    stdio: 'pipe'
+  };
+
+  if (hasPackageLockJson) {
+    commandArgs = args.filter(a => a !== '--prefer-offline');
+    await spawnAsync(
+      'npm',
+      ['install'].concat(commandArgs),
+      destPath,
+      opts as SpawnOptions
+    );
+  } else {
+    await spawnAsync(
+      'yarn',
+      ['--cwd', destPath].concat(commandArgs),
+      destPath,
+      opts as SpawnOptions,
+    );
+  }
+}
+
+export async function runPackageJsonScript(
+  destPath: string,
+  scriptName: string,
+  opts?: SpawnOptions
+) {
+  assert(path.isAbsolute(destPath));
+  const { hasScript, hasPackageLockJson } = await scanParentDirs(
+    destPath,
+    scriptName,
+  );
+  if (!hasScript) return false;
+
+  if (hasPackageLockJson) {
+    console.log(`running "npm run ${scriptName}"`);
+    await spawnAsync('npm', ['run', scriptName], destPath, opts);
+  } else {
+    console.log(`running "yarn run ${scriptName}"`);
+    await spawnAsync('yarn', ['--cwd', destPath, 'run', scriptName], destPath, opts);
+  }
+
+  return true;
+}
+
+export const runNpmInstall = installDependencies;

packages/now-build-utils/src/fs/stream-to-buffer.ts

@@ -0,0 +1,26 @@
+import eos from 'end-of-stream';
+
+export default function streamToBuffer(stream: NodeJS.ReadableStream): Promise<Buffer> {
+  return new Promise<Buffer>((resolve, reject) => {
+    const buffers: Buffer[] = [];
+
+    stream.on('data', buffers.push.bind(buffers))
+
+    eos(stream, (err) => {
+        if (err) {
+          reject(err);
+          return;
+        }
+        switch (buffers.length) {
+          case 0:
+            resolve(Buffer.allocUnsafe(0));
+            break;
+          case 1:
+            resolve(buffers[0]);
+            break;
+          default:
+            resolve(Buffer.concat(buffers));
+        }
+    });
+  });
+}

packages/now-build-utils/src/index.ts

@@ -0,0 +1,34 @@
+import FileBlob from './file-blob';
+import FileFsRef from './file-fs-ref';
+import FileRef from './file-ref';
+import { File, Files, AnalyzeOptions, BuildOptions, PrepareCacheOptions, ShouldServeOptions, Meta } from './types';
+import { Lambda, createLambda } from './lambda';
+import download from './fs/download';
+import getWriteableDirectory from './fs/get-writable-directory'
+import glob from './fs/glob';
+import rename from './fs/rename';
+import { installDependencies, runPackageJsonScript, runNpmInstall, runShellScript } from './fs/run-user-scripts';
+import streamToBuffer from './fs/stream-to-buffer';
+import shouldServe from './should-serve';
+
+export {
+    FileBlob,
+    FileFsRef,
+    FileRef,
+    Files,
+    File,
+    Meta,
+    Lambda,
+    createLambda,
+    download,
+    getWriteableDirectory,
+    glob,
+    rename,
+    installDependencies, runPackageJsonScript, runNpmInstall, runShellScript,
+    streamToBuffer,
+    AnalyzeOptions,
+    BuildOptions,
+    PrepareCacheOptions,
+    ShouldServeOptions,
+    shouldServe,
+};

packages/now-build-utils/src/lambda.ts

@@ -0,0 +1,104 @@
+import assert from 'assert';
+import Sema from 'async-sema';
+import { ZipFile } from 'yazl';
+import { readlink } from 'fs-extra';
+import { Files } from './types';
+import FileFsRef from './file-fs-ref';
+import { isSymbolicLink } from './fs/download';
+import streamToBuffer from './fs/stream-to-buffer';
+
+interface Environment {
+  [key: string]: string;
+}
+
+interface LambdaOptions {
+  zipBuffer: Buffer;
+  handler: string;
+  runtime: string;
+  environment: Environment;
+}
+
+interface CreateLambdaOptions {
+  files: Files;
+  handler: string;
+  runtime: string;
+  environment?: Environment;
+}
+
+export class Lambda {
+  public type: 'Lambda';
+  public zipBuffer: Buffer;
+  public handler: string;
+  public runtime: string;
+  public environment: Environment;
+
+  constructor({
+    zipBuffer, handler, runtime, environment,
+  }: LambdaOptions) {
+    this.type = 'Lambda';
+    this.zipBuffer = zipBuffer;
+    this.handler = handler;
+    this.runtime = runtime;
+    this.environment = environment;
+  }
+}
+
+const sema = new Sema(10);
+const mtime = new Date(1540000000000);
+
+export async function createLambda({
+  files, handler, runtime, environment = {},
+}: CreateLambdaOptions): Promise<Lambda> {
+  assert(typeof files === 'object', '"files" must be an object');
+  assert(typeof handler === 'string', '"handler" is not a string');
+  assert(typeof runtime === 'string', '"runtime" is not a string');
+  assert(typeof environment === 'object', '"environment" is not an object');
+
+  await sema.acquire();
+
+  try {
+    const zipBuffer = await createZip(files);
+    return new Lambda({
+      zipBuffer,
+      handler,
+      runtime,
+      environment,
+    });
+  } finally {
+    sema.release();
+  }
+}
+
+export async function createZip(files: Files): Promise<Buffer> {
+  const names = Object.keys(files).sort();
+
+  const symlinkTargets = new Map<string, string>();
+  for (const name of names) {
+    const file = files[name];
+    if (file.mode && isSymbolicLink(file.mode) && file.type === 'FileFsRef') {
+      const symlinkTarget = await readlink((file as FileFsRef).fsPath);
+      symlinkTargets.set(name, symlinkTarget);
+    }
+  }
+
+  const zipFile = new ZipFile();
+  const zipBuffer = await new Promise<Buffer>((resolve, reject) => {
+    for (const name of names) {
+      const file = files[name];
+      const opts = { mode: file.mode, mtime };
+      const symlinkTarget = symlinkTargets.get(name);
+      if (typeof symlinkTarget === 'string') {
+        zipFile.addBuffer(Buffer.from(symlinkTarget, 'utf8'), name, opts);
+      } else {
+        const stream = file.toStream() as import('stream').Readable;
+        stream.on('error', reject);
+        zipFile.addReadStream(stream, name, opts);
+      }
+    }
+
+    zipFile.end();
+    streamToBuffer(zipFile.outputStream).then(resolve).catch(reject);
+  });
+
+  return zipBuffer;
+}

packages/now-build-utils/src/should-serve.ts

@@ -0,0 +1,27 @@
+import { parse } from 'path';
+import { ShouldServeOptions } from './types';
+import FileFsRef from './file-fs-ref';
+
+export default function shouldServe({
+  entrypoint,
+  files,
+  requestPath
+}: ShouldServeOptions): boolean {
+  requestPath = requestPath.replace(/\/$/, ''); // sanitize trailing '/'
+  entrypoint = entrypoint.replace(/\\/, '/'); // windows compatibility
+
+  if (entrypoint === requestPath && hasProp(files, entrypoint)) {
+    return true;
+  }
+
+  const { dir, name } = parse(entrypoint);
+  if (name === 'index' && dir === requestPath && hasProp(files, entrypoint)) {
+    return true;
+  }
+
+  return false;
+}
+
+function hasProp(obj: { [path: string]: FileFsRef }, key: string): boolean {
+  return Object.hasOwnProperty.call(obj, key)
+}

packages/now-build-utils/src/types.ts

@@ -0,0 +1,154 @@
+import FileRef from './file-ref';
+import FileFsRef from './file-fs-ref';
+
+export interface File {
+  type: string;
+  mode: number;
+  toStream: () => NodeJS.ReadableStream;
+  fsPath?: string;
+}
+
+export interface Files {
+  [filePath: string]: File;
+}
+
+export interface Config {
+  [key: string]: string;
+}
+
+export interface Meta {
+  isDev?: boolean;
+  requestPath?: string;
+  filesChanged?: string[];
+  filesRemoved?: string[];
+}
+
+export interface AnalyzeOptions {
+  /**
+   * All source files of the project
+   */
+  files: {
+    [filePath: string]: FileRef;
+  };
+
+  /**
+   * Name of entrypoint file for this particular build job. Value
+   * `files[entrypoint]` is guaranteed to exist and be a valid File reference.
+   * `entrypoint` is always a discrete file and never a glob, since globs are
+   * expanded into separate builds at deployment time.
+   */
+  entrypoint: string;
+
+  /**
+   * A writable temporary directory where you are encouraged to perform your
+   * build process. This directory will be populated with the restored cache.
+   */
+  workPath: string;
+
+  /**
+   * An arbitrary object passed by the user in the build definition defined
+   * in `now.json`.
+   */
+  config: Config;
+}
+
+export interface BuildOptions {
+  /**
+   * All source files of the project
+   */
+  files: Files;
+
+  /**
+   * Name of entrypoint file for this particular build job. Value
+   * `files[entrypoint]` is guaranteed to exist and be a valid File reference.
+   * `entrypoint` is always a discrete file and never a glob, since globs are
+   * expanded into separate builds at deployment time.
+   */
+  entrypoint: string;
+
+  /**
+   * A writable temporary directory where you are encouraged to perform your
+   * build process. This directory will be populated with the restored cache.
+   */
+  workPath: string;
+
+  /**
+   * An arbitrary object passed by the user in the build definition defined
+   * in `now.json`.
+   */
+  config: Config;
+
+  /**
+   * Metadata related to the invoker of the builder, used by `now dev`.
+   * Builders may use the properties on this object to change behavior based
+   * on the build environment.
+   */
+  meta?: Meta;
+}
+
+export interface PrepareCacheOptions {
+  /**
+   * All source files of the project
+   */
+  files: Files;
+
+  /**
+   * Name of entrypoint file for this particular build job. Value
+   * `files[entrypoint]` is guaranteed to exist and be a valid File reference.
+   * `entrypoint` is always a discrete file and never a glob, since globs are
+   * expanded into separate builds at deployment time.
+   */
+  entrypoint: string;
+
+  /**
+   * A writable temporary directory where you are encouraged to perform your
+   * build process.
+   */
+  workPath: string;
+
+  /**
+   * A writable temporary directory where you can build a cache to use for
+   * the next run.
+   */
+  cachePath: string;
+
+  /**
+   * An arbitrary object passed by the user in the build definition defined
+   * in `now.json`.
+   */
+  config: Config;
+}
+
+export interface ShouldServeOptions {
+  /**
+   * A path string from a request.
+   */
+  requestPath: string;
+
+  /**
+   * Name of entrypoint file for this particular build job. Value
+   * `files[entrypoint]` is guaranteed to exist and be a valid File reference.
+   * `entrypoint` is always a discrete file and never a glob, since globs are
+   * expanded into separate builds at deployment time.
+   */
+  entrypoint: string;
+
+  /**
+   * All source files of the project
+   */
+  files: {
+    [path: string]: FileFsRef;
+  };
+
+  /**
+   * A writable temporary directory where you are encouraged to perform your
+   * build process. This directory will be populated with the restored cache.
+   */
+  workPath: string;
+
+  /**
+   * An arbitrary object passed by the user in the build definition defined
+   * in `now.json`.
+   */
+  config: Config;
+}

packages/now-build-utils/test/symlinks/a.txt

@@ -0,0 +1 @@
+contents

packages/now-build-utils/test/symlinks/link.txt

@@ -0,0 +1 @@
+./a.txt

packages/now-build-utils/test/test.js

@@ -1,6 +1,11 @@
 /* global beforeAll, expect, it, jest */
-const fs = require('fs');
 const path = require('path');
+const fs = require('fs-extra');
+// eslint-disable-next-line import/no-extraneous-dependencies
+const execa = require('execa');
+const assert = require('assert');
+const { glob, download } = require('../');
+const { createZip } = require('../dist/lambda');
 
 const {
   packAndDeploy,
@@ -17,6 +22,48 @@ beforeAll(async () => {
   console.log('buildUtilsUrl', buildUtilsUrl);
 });
 
+// unit tests
+
+it('should re-create symlinks properly', async () => {
+  const files = await glob('**', path.join(__dirname, 'symlinks'));
+  assert.equal(Object.keys(files).length, 2);
+
+  const outDir = path.join(__dirname, 'symlinks-out');
+  await fs.remove(outDir);
+
+  const files2 = await download(files, outDir);
+  assert.equal(Object.keys(files2).length, 2);
+
+  const [linkStat, aStat] = await Promise.all([
+    fs.lstat(path.join(outDir, 'link.txt')),
+    fs.lstat(path.join(outDir, 'a.txt')),
+  ]);
+  assert(linkStat.isSymbolicLink());
+  assert(aStat.isFile());
+});
+
+it('should create zip files with symlinks properly', async () => {
+  const files = await glob('**', path.join(__dirname, 'symlinks'));
+  assert.equal(Object.keys(files).length, 2);
+
+  const outFile = path.join(__dirname, 'symlinks.zip');
+  await fs.remove(outFile);
+
+  const outDir = path.join(__dirname, 'symlinks-out');
+  await fs.remove(outDir);
+  await fs.mkdirp(outDir);
+
+  await fs.writeFile(outFile, await createZip(files));
+  await execa('unzip', [outFile], { cwd: outDir });
+
+  const [linkStat, aStat] = await Promise.all([
+    fs.lstat(path.join(outDir, 'link.txt')),
+    fs.lstat(path.join(outDir, 'a.txt')),
+  ]);
+  assert(linkStat.isSymbolicLink());
+  assert(aStat.isFile());
+});
+
 // own fixtures
 
 const fixturesPath = path.resolve(__dirname, 'fixtures');

packages/now-build-utils/tsconfig.json

@@ -0,0 +1,24 @@
+{
+  "compilerOptions": {
+    "declaration": true,
+    "esModuleInterop": true,
+    "lib": ["esnext"],
+    "module": "commonjs",
+    "moduleResolution": "node",
+    "noEmitOnError": true,
+    "noFallthroughCasesInSwitch": true,
+    "noImplicitReturns": true,
+    "noUnusedLocals": true,
+    "noUnusedParameters": true,
+    "outDir": "./dist",
+    "types": ["node"],
+    "strict": true,
+    "target": "esnext"
+  },
+  "include": [
+    "src/**/*"
+  ],
+  "exclude": [
+    "node_modules"
+  ]
+}

packages/now-cgi/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@now/cgi",
-  "version": "0.0.16-canary.0",
+  "version": "0.1.0",
   "license": "MIT",
   "repository": {
     "type": "git",

packages/now-go/go-helpers.js

@@ -21,12 +21,12 @@ const getGoUrl = (version, platform, arch) => {
   return `https://dl.google.com/go/go${version}.${goPlatform}-${goArch}.${ext}`;
 };
 
-function getExportedFunctionName(filePath) {
+async function getExportedFunctionName(filePath) {
   debug('Detecting handler name for %o', filePath);
   const bin = join(__dirname, 'get-exported-function-name');
   const args = [filePath];
-  const name = execa.stdout(bin, args);
-  debug('Detected exported name %o', filePath);
+  const name = await execa.stdout(bin, args);
+  debug('Detected exported name %o', name);
   return name;
 }
 
@@ -68,6 +68,7 @@ async function createGo(
   platform = process.platform,
   arch = process.arch,
   opts = {},
+  goMod = false,
 ) {
   const env = {
     ...process.env,
@@ -76,6 +77,10 @@ async function createGo(
     ...opts.env,
   };
 
+  if (goMod) {
+    env.GO111MODULE = 'on';
+  }
+
   function go(...args) {
     debug('Exec %o', `go ${args.join(' ')}`);
     return execa('go', args, { stdio: 'inherit', ...opts, env });
@@ -90,7 +95,7 @@ async function createGo(
 
 async function downloadGo(
   dir = GO_DIR,
-  version = '1.11.5',
+  version = '1.12',
   platform = process.platform,
   arch = process.arch,
 ) {

packages/now-go/index.js

@@ -1,5 +1,7 @@
-const { join, dirname } = require('path');
-const { readFile, writeFile } = require('fs-extra');
+const { join, sep, dirname } = require('path');
+const {
+  readFile, writeFile, pathExists, move,
+} = require('fs-extra');
 
 const glob = require('@now/build-utils/fs/glob.js'); // eslint-disable-line import/no-extraneous-dependencies
 const download = require('@now/build-utils/fs/download.js'); // eslint-disable-line import/no-extraneous-dependencies
@@ -23,9 +25,9 @@ async function build({ files, entrypoint }) {
   const downloadedFiles = await download(files, srcPath);
 
   console.log(`Parsing AST for "${entrypoint}"`);
-  let handlerFunctionName;
+  let parseFunctionName;
   try {
-    handlerFunctionName = await getExportedFunctionName(
+    parseFunctionName = await getExportedFunctionName(
       downloadedFiles[entrypoint].fsPath,
     );
   } catch (err) {
@@ -33,7 +35,7 @@ async function build({ files, entrypoint }) {
     throw err;
   }
 
-  if (!handlerFunctionName) {
+  if (!parseFunctionName) {
     const err = new Error(
       `Could not find an exported function in "${entrypoint}"`,
     );
@@ -41,53 +43,156 @@ async function build({ files, entrypoint }) {
     throw err;
   }
 
+  const handlerFunctionName = parseFunctionName.split(',')[0];
+
   console.log(
     `Found exported function "${handlerFunctionName}" in "${entrypoint}"`,
   );
 
-  const origianlMainGoContents = await readFile(
-    join(__dirname, 'main.go'),
-    'utf8',
-  );
-  const mainGoContents = origianlMainGoContents.replace(
-    '__NOW_HANDLER_FUNC_NAME',
-    handlerFunctionName,
-  );
-  // in order to allow the user to have `main.go`, we need our `main.go` to be called something else
-  const mainGoFileName = 'main__now__go__.go';
-
   // we need `main.go` in the same dir as the entrypoint,
   // otherwise `go build` will refuse to build
   const entrypointDirname = dirname(downloadedFiles[entrypoint].fsPath);
 
-  // Go doesn't like to build files in different directories,
-  // so now we place `main.go` together with the user code
-  await writeFile(join(entrypointDirname, mainGoFileName), mainGoContents);
+  // check if package name other than main
+  const packageName = parseFunctionName.split(',')[1];
+  const isGoModExist = await pathExists(join(entrypointDirname, 'go.mod'));
+  if (packageName !== 'main') {
+    const go = await createGo(
+      goPath,
+      process.platform,
+      process.arch,
+      {
+        cwd: entrypointDirname,
+      },
+      true,
+    );
+    if (!isGoModExist) {
+      try {
+        const defaultGoModContent = `module ${packageName}`;
 
-  const go = await createGo(goPath, process.platform, process.arch, {
-    cwd: entrypointDirname,
-  });
+        await writeFile(join(entrypointDirname, 'go.mod'), defaultGoModContent);
+      } catch (err) {
+        console.log(`failed to create default go.mod for ${packageName}`);
+        throw err;
+      }
+    }
 
-  // `go get` will look at `*.go` (note we set `cwd`), parse the `import`s
-  // and download any packages that aren't part of the stdlib
-  try {
-    await go.get();
-  } catch (err) {
-    console.log('failed to `go get`');
-    throw err;
-  }
+    const mainModGoFileName = 'main__mod__.go';
+    const modMainGoContents = await readFile(
+      join(__dirname, mainModGoFileName),
+      'utf8',
+    );
 
-  console.log('Running `go build`...');
-  const destPath = join(outDir, 'handler');
-  try {
-    const src = [
-      join(entrypointDirname, mainGoFileName),
-      downloadedFiles[entrypoint].fsPath,
-    ];
-    await go.build({ src, dest: destPath });
-  } catch (err) {
-    console.log('failed to `go build`');
-    throw err;
+    let goPackageName = `${packageName}/${packageName}`;
+    const goFuncName = `${packageName}.${handlerFunctionName}`;
+
+    if (isGoModExist) {
+      const goModContents = await readFile(
+        join(entrypointDirname, 'go.mod'),
+        'utf8',
+      );
+      goPackageName = `${
+        goModContents.split('\n')[0].split(' ')[1]
+      }/${packageName}`;
+    }
+
+    const mainModGoContents = modMainGoContents
+      .replace('__NOW_HANDLER_PACKAGE_NAME', goPackageName)
+      .replace('__NOW_HANDLER_FUNC_NAME', goFuncName);
+
+    // write main__mod__.go
+    await writeFile(
+      join(entrypointDirname, mainModGoFileName),
+      mainModGoContents,
+    );
+
+    // move user go file to folder
+    try {
+      // default path
+      let finalDestination = join(entrypointDirname, packageName, entrypoint);
+      const entrypointArr = entrypoint.split(sep);
+
+      // if `entrypoint` include folder, only use filename
+      if (entrypointArr.length > 1) {
+        finalDestination = join(
+          entrypointDirname,
+          packageName,
+          entrypointArr.pop(),
+        );
+      }
+
+      await move(downloadedFiles[entrypoint].fsPath, finalDestination);
+    } catch (err) {
+      console.log('failed to move entry to package folder');
+      throw err;
+    }
+
+    console.log('tidy go.mod file');
+    try {
+      // ensure go.mod up-to-date
+      await go('mod', 'tidy');
+    } catch (err) {
+      console.log('failed to `go mod tidy`');
+      throw err;
+    }
+
+    console.log('Running `go build`...');
+    const destPath = join(outDir, 'handler');
+    try {
+      const src = [join(entrypointDirname, mainModGoFileName)];
+      await go.build({ src, dest: destPath });
+    } catch (err) {
+      console.log('failed to `go build`');
+      throw err;
+    }
+  } else {
+    const go = await createGo(
+      goPath,
+      process.platform,
+      process.arch,
+      {
+        cwd: entrypointDirname,
+      },
+      false,
+    );
+    const origianlMainGoContents = await readFile(
+      join(__dirname, 'main.go'),
+      'utf8',
+    );
+    const mainGoContents = origianlMainGoContents.replace(
+      '__NOW_HANDLER_FUNC_NAME',
+      handlerFunctionName,
+    );
+
+    // in order to allow the user to have `main.go`,
+    // we need our `main.go` to be called something else
+    const mainGoFileName = 'main__now__go__.go';
+
+    // Go doesn't like to build files in different directories,
+    // so now we place `main.go` together with the user code
+    await writeFile(join(entrypointDirname, mainGoFileName), mainGoContents);
+
+    // `go get` will look at `*.go` (note we set `cwd`), parse the `import`s
+    // and download any packages that aren't part of the stdlib
+    try {
+      await go.get();
+    } catch (err) {
+      console.log('failed to `go get`');
+      throw err;
+    }
+
+    console.log('Running `go build`...');
+    const destPath = join(outDir, 'handler');
+    try {
+      const src = [
+        join(entrypointDirname, mainGoFileName),
+        downloadedFiles[entrypoint].fsPath,
+      ];
+      await go.build({ src, dest: destPath });
+    } catch (err) {
+      console.log('failed to `go build`');
+      throw err;
+    }
   }
 
   const lambda = await createLambda({

packages/now-go/main__mod__.go

@@ -0,0 +1,12 @@
+package main
+
+import (
+  "net/http"
+  "__NOW_HANDLER_PACKAGE_NAME"
+
+  now "github.com/zeit/now-builders/utils/go/bridge"
+)
+
+func main() {
+  now.Start(http.HandlerFunc(__NOW_HANDLER_FUNC_NAME))
+}

packages/now-go/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@now/go",
-  "version": "0.2.13-canary.1",
+  "version": "0.4.0",
   "license": "MIT",
   "repository": {
     "type": "git",
@@ -13,6 +13,7 @@
   "files": [
     "*.js",
     "main.go",
+    "main__mod__.go",
     "util"
   ],
   "dependencies": {

packages/now-go/test/fixtures/01-cowsay/index.go

@@ -0,0 +1,13 @@
+package cowsay
+
+import (
+	"fmt"
+	"net/http"
+
+	say "github.com/dhruvbird/go-cowsay"
+)
+
+// Handler function
+func Handler(w http.ResponseWriter, r *http.Request) {
+	fmt.Fprintf(w, say.Format("cow:RANDOMNESS_PLACEHOLDER"))
+}

packages/now-go/test/fixtures/01-cowsay/now.json

@@ -0,0 +1,11 @@
+{
+  "version": 2,
+  "builds": [
+    { "src": "index.go", "use": "@now/go" },
+    { "src": "subdirectory/index.go", "use": "@now/go" }
+  ],
+  "probes": [
+    { "path": "/", "mustContain": "cow:RANDOMNESS_PLACEHOLDER" },
+    { "path": "/subdirectory", "mustContain": "subcow:RANDOMNESS_PLACEHOLDER" }
+  ]
+}

packages/now-go/test/fixtures/01-cowsay/subdirectory/index.go

@@ -0,0 +1,13 @@
+package subcow
+
+import (
+	"fmt"
+	"net/http"
+
+	say "github.com/dhruvbird/go-cowsay"
+)
+
+// Handler function
+func Handler(w http.ResponseWriter, r *http.Request) {
+	fmt.Fprintf(w, say.Format("subcow:RANDOMNESS_PLACEHOLDER"))
+}

packages/now-go/test/test.js

@@ -0,0 +1,33 @@
+/* global beforeAll, expect, it, jest */
+const fs = require('fs');
+const path = require('path');
+
+const {
+  packAndDeploy,
+  testDeployment,
+} = require('../../../test/lib/deployment/test-deployment.js');
+
+jest.setTimeout(4 * 60 * 1000);
+const buildUtilsUrl = '@canary';
+let builderUrl;
+
+beforeAll(async () => {
+  const builderPath = path.resolve(__dirname, '..');
+  builderUrl = await packAndDeploy(builderPath);
+  console.log('builderUrl', builderUrl);
+});
+
+const fixturesPath = path.resolve(__dirname, 'fixtures');
+
+// eslint-disable-next-line no-restricted-syntax
+for (const fixture of fs.readdirSync(fixturesPath)) {
+  // eslint-disable-next-line no-loop-func
+  it(`should build ${fixture}`, async () => {
+    await expect(
+      testDeployment(
+        { builderUrl, buildUtilsUrl },
+        path.join(fixturesPath, fixture),
+      ),
+    ).resolves.toBeDefined();
+  });
+}

packages/now-go/util/get-exported-function-name.go

@@ -34,7 +34,7 @@ func main() {
 		if fn.Name.IsExported() == true {
 			// we found the first exported function
 			// we're done!
-			fmt.Print(fn.Name.Name)
+			fmt.Print(fn.Name.Name, ",", parsed.Name.Name)
 			os.Exit(0)
 		}
 	}

packages/now-html-minifier/index.js

@@ -11,7 +11,6 @@ const defaultOptions = {
   removeRedundantAttributes: true,
   useShortDoctype: true,
   collapseWhitespace: true,
-  collapseInlineTagWhitespace: true,
   collapseBooleanAttributes: true,
   caseSensitive: true,
 };

packages/now-html-minifier/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@now/html-minifier",
-  "version": "1.0.8-canary.0",
+  "version": "1.1.0",
   "license": "MIT",
   "repository": {
     "type": "git",

packages/now-lambda/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@now/lambda",
-  "version": "0.4.10-canary.1",
+  "version": "0.5.0",
   "license": "MIT",
   "repository": {
     "type": "git",

packages/now-md/index.js

@@ -34,8 +34,6 @@ exports.build = async ({ files, entrypoint, config }) => {
     stream: stream.pipe(unifiedStream(processor)),
   });
 
-  console.log(result.data.toString());
-
   const replacedEntrypoint = entrypoint.replace(/\.[^.]+$/, '.html');
 
   return { [replacedEntrypoint]: result };

packages/now-md/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@now/md",
-  "version": "0.4.10-canary.1",
+  "version": "0.5.0",
   "license": "MIT",
   "repository": {
     "type": "git",

packages/now-mdx-deck/index.js

@@ -43,17 +43,8 @@ exports.build = async ({ files, entrypoint, workPath }) => {
   return glob('**', outDir, mountpoint);
 };
 
-exports.prepareCache = async ({ cachePath }) => {
-  console.log('writing package.json...');
-  const packageJson = { dependencies: { 'mdx-deck': '1.7.15' } };
-  const packageJsonPath = path.join(cachePath, 'package.json');
-  await writeFile(packageJsonPath, JSON.stringify(packageJson));
-  console.log('running npm install...');
-  await runNpmInstall(path.dirname(packageJsonPath), ['--prod']);
-
-  return {
-    ...(await glob('node_modules/**', cachePath)),
-    ...(await glob('package-lock.json', cachePath)),
-    ...(await glob('yarn.lock', cachePath)),
-  };
-};
+exports.prepareCache = async ({ workPath }) => ({
+  ...(await glob('node_modules/**', workPath)),
+  ...(await glob('package-lock.json', workPath)),
+  ...(await glob('yarn.lock', workPath)),
+});

packages/now-mdx-deck/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@now/mdx-deck",
-  "version": "0.4.19-canary.1",
+  "version": "0.5.0",
   "license": "MIT",
   "repository": {
     "type": "git",

packages/now-next/.gitignore

@@ -0,0 +1,2 @@
+/dist
+/src/now__bridge.d.ts

packages/now-next/getBridgeTypes.sh

@@ -0,0 +1,11 @@
+#!/bin/bash
+set -euo pipefail
+
+bridge_entrypoint="$(node -p 'require.resolve("@now/node-bridge")')"
+bridge_defs="$(dirname "$bridge_entrypoint")/bridge.d.ts"
+
+if [ ! -e "$bridge_defs" ]; then
+  yarn install --cwd "$bridge_entrypoint"
+fi
+
+cp -v "$bridge_defs" src/now__bridge.d.ts

packages/now-next/index.js

@@ -1,328 +0,0 @@
-const { createLambda } = require('@now/build-utils/lambda.js'); // eslint-disable-line import/no-extraneous-dependencies
-const download = require('@now/build-utils/fs/download.js'); // eslint-disable-line import/no-extraneous-dependencies
-const FileFsRef = require('@now/build-utils/file-fs-ref.js'); // eslint-disable-line import/no-extraneous-dependencies
-const FileBlob = require('@now/build-utils/file-blob'); // eslint-disable-line import/no-extraneous-dependencies
-const path = require('path');
-const { readFile, writeFile, unlink } = require('fs.promised');
-const {
-  runNpmInstall,
-  runPackageJsonScript,
-} = require('@now/build-utils/fs/run-user-scripts.js'); // eslint-disable-line import/no-extraneous-dependencies
-const glob = require('@now/build-utils/fs/glob.js'); // eslint-disable-line import/no-extraneous-dependencies
-const semver = require('semver');
-const nextLegacyVersions = require('./legacy-versions');
-const {
-  excludeFiles,
-  validateEntrypoint,
-  includeOnlyEntryDirectory,
-  normalizePackageJson,
-  onlyStaticDirectory,
-} = require('./utils');
-
-/** @typedef { import('@now/build-utils/file-ref').Files } Files */
-/** @typedef { import('@now/build-utils/fs/download').DownloadedFiles } DownloadedFiles */
-
-/**
- * @typedef {Object} BuildParamsType
- * @property {Files} files - Files object
- * @property {string} entrypoint - Entrypoint specified for the builder
- * @property {string} workPath - Working directory for this build
- */
-
-/**
- * Read package.json from files
- * @param {string} entryPath
- */
-async function readPackageJson(entryPath) {
-  const packagePath = path.join(entryPath, 'package.json');
-
-  try {
-    return JSON.parse(await readFile(packagePath, 'utf8'));
-  } catch (err) {
-    console.log('package.json not found in entry');
-    return {};
-  }
-}
-
-/**
- * Write package.json
- * @param {string} workPath
- * @param {Object} packageJson
- */
-async function writePackageJson(workPath, packageJson) {
-  await writeFile(
-    path.join(workPath, 'package.json'),
-    JSON.stringify(packageJson, null, 2),
-  );
-}
-
-/**
- * Write .npmrc with npm auth token
- * @param {string} workPath
- * @param {string} token
- */
-async function writeNpmRc(workPath, token) {
-  await writeFile(
-    path.join(workPath, '.npmrc'),
-    `//registry.npmjs.org/:_authToken=${token}`,
-  );
-}
-
-exports.config = {
-  maxLambdaSize: '5mb',
-};
-
-/**
- * @param {BuildParamsType} buildParams
- * @returns {Promise<Files>}
- */
-exports.build = async ({ files, workPath, entrypoint }) => {
-  validateEntrypoint(entrypoint);
-
-  console.log('downloading user files...');
-  const entryDirectory = path.dirname(entrypoint);
-  await download(files, workPath);
-  const entryPath = path.join(workPath, entryDirectory);
-
-  const pkg = await readPackageJson(entryPath);
-
-  let nextVersion;
-  if (pkg.dependencies && pkg.dependencies.next) {
-    nextVersion = pkg.dependencies.next;
-  } else if (pkg.devDependencies && pkg.devDependencies.next) {
-    nextVersion = pkg.devDependencies.next;
-  }
-
-  if (!nextVersion) {
-    throw new Error(
-      'No Next.js version could be detected in "package.json". Make sure `"next"` is installed in "dependencies" or "devDependencies"',
-    );
-  }
-
-  const isLegacy = (() => {
-    // If version is using the dist-tag instead of a version range
-    if (nextVersion === 'canary' || nextVersion === 'latest') {
-      return false;
-    }
-
-    // If the version is an exact match with the legacy versions
-    if (nextLegacyVersions.indexOf(nextVersion) !== -1) {
-      return true;
-    }
-
-    const maxSatisfying = semver.maxSatisfying(nextLegacyVersions, nextVersion);
-    // When the version can't be matched with legacy versions, so it must be a newer version
-    if (maxSatisfying === null) {
-      return false;
-    }
-
-    return true;
-  })();
-
-  console.log(`MODE: ${isLegacy ? 'legacy' : 'serverless'}`);
-
-  if (isLegacy) {
-    try {
-      await unlink(path.join(entryPath, 'yarn.lock'));
-    } catch (err) {
-      console.log('no yarn.lock removed');
-    }
-
-    try {
-      await unlink(path.join(entryPath, 'package-lock.json'));
-    } catch (err) {
-      console.log('no package-lock.json removed');
-    }
-
-    console.warn(
-      "WARNING: your application is being deployed in @now/next's legacy mode. http://err.sh/zeit/now-builders/now-next-legacy-mode",
-    );
-
-    console.log('normalizing package.json');
-    const packageJson = normalizePackageJson(pkg);
-    console.log('normalized package.json result: ', packageJson);
-    await writePackageJson(entryPath, packageJson);
-  } else if (!pkg.scripts || !pkg.scripts['now-build']) {
-    console.warn(
-      'WARNING: "now-build" script not found. Adding \'"now-build": "next build"\' to "package.json" automatically',
-    );
-    pkg.scripts = {
-      'now-build': 'next build',
-      ...(pkg.scripts || {}),
-    };
-    console.log('normalized package.json result: ', pkg);
-    await writePackageJson(entryPath, pkg);
-  }
-
-  if (process.env.NPM_AUTH_TOKEN) {
-    console.log('found NPM_AUTH_TOKEN in environment, creating .npmrc');
-    await writeNpmRc(entryPath, process.env.NPM_AUTH_TOKEN);
-  }
-
-  console.log('installing dependencies...');
-  await runNpmInstall(entryPath, ['--prefer-offline']);
-  console.log('running user script...');
-  await runPackageJsonScript(entryPath, 'now-build');
-
-  if (isLegacy) {
-    console.log('running npm install --production...');
-    await runNpmInstall(entryPath, ['--prefer-offline', '--production']);
-  }
-
-  if (process.env.NPM_AUTH_TOKEN) {
-    await unlink(path.join(entryPath, '.npmrc'));
-  }
-
-  const lambdas = {};
-
-  if (isLegacy) {
-    const filesAfterBuild = await glob('**', entryPath);
-
-    console.log('preparing lambda files...');
-    let buildId;
-    try {
-      buildId = await readFile(
-        path.join(entryPath, '.next', 'BUILD_ID'),
-        'utf8',
-      );
-    } catch (err) {
-      console.error(
-        'BUILD_ID not found in ".next". The "package.json" "build" script did not run "next build"',
-      );
-      throw new Error('Missing BUILD_ID');
-    }
-    const dotNextRootFiles = await glob('.next/*', entryPath);
-    const dotNextServerRootFiles = await glob('.next/server/*', entryPath);
-    const nodeModules = excludeFiles(
-      await glob('node_modules/**', entryPath),
-      file => file.startsWith('node_modules/.cache'),
-    );
-    const launcherFiles = {
-      'now__bridge.js': new FileFsRef({ fsPath: require('@now/node-bridge') }),
-    };
-    const nextFiles = {
-      ...nodeModules,
-      ...dotNextRootFiles,
-      ...dotNextServerRootFiles,
-      ...launcherFiles,
-    };
-    if (filesAfterBuild['next.config.js']) {
-      nextFiles['next.config.js'] = filesAfterBuild['next.config.js'];
-    }
-    const pages = await glob(
-      '**/*.js',
-      path.join(entryPath, '.next', 'server', 'static', buildId, 'pages'),
-    );
-    const launcherPath = path.join(__dirname, 'legacy-launcher.js');
-    const launcherData = await readFile(launcherPath, 'utf8');
-
-    await Promise.all(
-      Object.keys(pages).map(async (page) => {
-        // These default pages don't have to be handled as they'd always 404
-        if (['_app.js', '_error.js', '_document.js'].includes(page)) {
-          return;
-        }
-
-        const pathname = page.replace(/\.js$/, '');
-        const launcher = launcherData.replace(
-          'PATHNAME_PLACEHOLDER',
-          `/${pathname.replace(/(^|\/)index$/, '')}`,
-        );
-
-        const pageFiles = {
-          [`.next/server/static/${buildId}/pages/_document.js`]: filesAfterBuild[
-            `.next/server/static/${buildId}/pages/_document.js`
-          ],
-          [`.next/server/static/${buildId}/pages/_app.js`]: filesAfterBuild[
-            `.next/server/static/${buildId}/pages/_app.js`
-          ],
-          [`.next/server/static/${buildId}/pages/_error.js`]: filesAfterBuild[
-            `.next/server/static/${buildId}/pages/_error.js`
-          ],
-          [`.next/server/static/${buildId}/pages/${page}`]: filesAfterBuild[
-            `.next/server/static/${buildId}/pages/${page}`
-          ],
-        };
-
-        console.log(`Creating lambda for page: "${page}"...`);
-        lambdas[path.join(entryDirectory, pathname)] = await createLambda({
-          files: {
-            ...nextFiles,
-            ...pageFiles,
-            'now__launcher.js': new FileBlob({ data: launcher }),
-          },
-          handler: 'now__launcher.launcher',
-          runtime: 'nodejs8.10',
-        });
-        console.log(`Created lambda for page: "${page}"`);
-      }),
-    );
-  } else {
-    console.log('preparing lambda files...');
-    const launcherFiles = {
-      'now__bridge.js': new FileFsRef({ fsPath: require('@now/node-bridge') }),
-      'now__launcher.js': new FileFsRef({
-        fsPath: path.join(__dirname, 'launcher.js'),
-      }),
-    };
-    const pages = await glob(
-      '**/*.js',
-      path.join(entryPath, '.next', 'serverless', 'pages'),
-    );
-
-    const pageKeys = Object.keys(pages);
-
-    if (pageKeys.length === 0) {
-      throw new Error(
-        'No serverless pages were built. https://err.sh/zeit/now-builders/now-next-no-serverless-pages-built',
-      );
-    }
-
-    await Promise.all(
-      pageKeys.map(async (page) => {
-        // These default pages don't have to be handled as they'd always 404
-        if (['_app.js', '_error.js', '_document.js'].includes(page)) {
-          return;
-        }
-
-        const pathname = page.replace(/\.js$/, '');
-
-        console.log(`Creating lambda for page: "${page}"...`);
-        lambdas[path.join(entryDirectory, pathname)] = await createLambda({
-          files: {
-            ...launcherFiles,
-            'page.js': pages[page],
-          },
-          handler: 'now__launcher.launcher',
-          runtime: 'nodejs8.10',
-        });
-        console.log(`Created lambda for page: "${page}"`);
-      }),
-    );
-  }
-
-  const nextStaticFiles = await glob(
-    '**',
-    path.join(entryPath, '.next', 'static'),
-  );
-  const staticFiles = Object.keys(nextStaticFiles).reduce(
-    (mappedFiles, file) => ({
-      ...mappedFiles,
-      [path.join(entryDirectory, `_next/static/${file}`)]: nextStaticFiles[file],
-    }),
-    {},
-  );
-
-  const nextStaticDirectory = onlyStaticDirectory(
-    includeOnlyEntryDirectory(files, entryDirectory),
-  );
-  const staticDirectoryFiles = Object.keys(nextStaticDirectory).reduce(
-    (mappedFiles, file) => ({
-      ...mappedFiles,
-      [path.join(entryDirectory, file)]: nextStaticDirectory[file],
-    }),
-    {},
-  );
-
-  return { ...lambdas, ...staticFiles, ...staticDirectoryFiles };
-};

packages/now-next/launcher.js

@@ -1,13 +0,0 @@
-process.env.NODE_ENV = 'production';
-
-const { Server } = require('http');
-const { Bridge } = require('./now__bridge.js');
-const page = require('./page.js');
-
-const bridge = new Bridge();
-bridge.port = 3000;
-
-const server = new Server(page.render);
-server.listen(bridge.port);
-
-exports.launcher = bridge.launcher;

packages/now-next/legacy-launcher.js

@@ -1,19 +0,0 @@
-const { Server } = require('http');
-const next = require('next-server');
-const url = require('url');
-const { Bridge } = require('./now__bridge.js');
-
-const bridge = new Bridge();
-bridge.port = 3000;
-
-process.env.NODE_ENV = 'production';
-
-const app = next({});
-
-const server = new Server((req, res) => {
-  const parsedUrl = url.parse(req.url, true);
-  app.render(req, res, 'PATHNAME_PLACEHOLDER', parsedUrl.query, parsedUrl);
-});
-server.listen(bridge.port);
-
-exports.launcher = bridge.launcher;

packages/now-next/package.json

@@ -1,16 +1,33 @@
 {
   "name": "@now/next",
-  "version": "0.0.85-canary.5",
+  "version": "0.2.0",
   "license": "MIT",
+  "main": "./dist/index",
+  "scripts": {
+    "build": "./getBridgeTypes.sh && tsc",
+    "test": "npm run build && jest",
+    "prepublish": "yarn run build"
+  },
   "repository": {
     "type": "git",
     "url": "https://github.com/zeit/now-builders.git",
     "directory": "packages/now-next"
   },
   "dependencies": {
-    "@now/node-bridge": "0.1.4",
-    "execa": "^1.0.0",
-    "fs.promised": "^3.0.0",
+    "@now/node-bridge": "^1.1.0",
+    "fs-extra": "^7.0.0",
+    "get-port": "^5.0.0",
+    "resolve-from": "^5.0.0",
     "semver": "^5.6.0"
+  },
+  "files": [
+    "dist"
+  ],
+  "devDependencies": {
+    "@types/next-server": "^8.0.0",
+    "@types/resolve-from": "^5.0.1",
+    "@types/semver": "^6.0.0",
+    "jest": "^24.7.1",
+    "typescript": "^3.4.3"
   }
 }

packages/now-next/src/dev-server.ts

@@ -0,0 +1,41 @@
+import resolveFrom from 'resolve-from';
+import { parse } from 'url';
+import getPort from 'get-port';
+import { createServer } from 'http';
+
+export interface ProcessEnv {
+  [key: string]: string;
+}
+
+async function main(env: ProcessEnv, cwd: string) {
+  const next = require(resolveFrom(cwd, 'next'));
+  const app = next({ dev: true, dir: cwd });
+  const handler = app.getRequestHandler();
+
+  const openPort = await getPort({
+    port: [ 5000, 4000 ]
+  });
+
+  const url = `http://localhost:${openPort}`;
+
+  // Prepare for incoming requests
+  await app.prepare();
+
+  createServer((req, res) => {
+    const parsedUrl = parse(req.url || '', true);
+    handler(req, res, parsedUrl);
+  }).listen(openPort, (error: NodeJS.ErrnoException) => {
+    if (error) {
+      console.error(error);
+      process.exit(1);
+
+      return;
+    }
+
+    if (process.send) {
+      process.send(url);
+    }
+  });
+}
+
+main(process.env as ProcessEnv, process.cwd());

packages/now-next/src/index.ts

@@ -0,0 +1,478 @@
+import { ChildProcess, fork, SpawnOptions } from 'child_process';
+import {
+  pathExists,
+  readFile,
+  unlink as unlinkFile,
+  writeFile,
+} from 'fs-extra';
+import os from 'os';
+import path from 'path';
+import semver from 'semver';
+
+import {
+  BuildOptions,
+  createLambda,
+  download,
+  FileBlob,
+  FileFsRef,
+  Files,
+  glob,
+  Lambda,
+  PrepareCacheOptions,
+  runNpmInstall,
+  runPackageJsonScript,
+} from '@now/build-utils';
+
+import nextLegacyVersions from './legacy-versions';
+import {
+  excludeFiles,
+  getNextConfig,
+  getPathsInside,
+  getRoutes,
+  includeOnlyEntryDirectory,
+  normalizePackageJson,
+  onlyStaticDirectory,
+  stringMap,
+  validateEntrypoint,
+} from './utils';
+
+interface BuildParamsMeta {
+  isDev: boolean | undefined;
+}
+
+interface BuildParamsType extends BuildOptions {
+  files: Files;
+  entrypoint: string;
+  workPath: string;
+  meta: BuildParamsMeta;
+}
+
+export const version = 2;
+
+/**
+ * Read package.json from files
+ */
+async function readPackageJson(entryPath: string) {
+  const packagePath = path.join(entryPath, 'package.json');
+
+  try {
+    return JSON.parse(await readFile(packagePath, 'utf8'));
+  } catch (err) {
+    console.log('package.json not found in entry');
+    return {};
+  }
+}
+
+/**
+ * Write package.json
+ */
+async function writePackageJson(workPath: string, packageJson: Object) {
+  await writeFile(
+    path.join(workPath, 'package.json'),
+    JSON.stringify(packageJson, null, 2)
+  );
+}
+
+/**
+ * Write .npmrc with npm auth token
+ */
+async function writeNpmRc(workPath: string, token: string) {
+  await writeFile(
+    path.join(workPath, '.npmrc'),
+    `//registry.npmjs.org/:_authToken=${token}`
+  );
+}
+
+function getNextVersion(packageJson: {
+  dependencies?: { [key: string]: string };
+  devDependencies?: { [key: string]: string };
+}) {
+  let nextVersion;
+  if (packageJson.dependencies && packageJson.dependencies.next) {
+    nextVersion = packageJson.dependencies.next;
+  } else if (packageJson.devDependencies && packageJson.devDependencies.next) {
+    nextVersion = packageJson.devDependencies.next;
+  }
+  return nextVersion;
+}
+
+function isLegacyNext(nextVersion: string) {
+  // If version is using the dist-tag instead of a version range
+  if (nextVersion === 'canary' || nextVersion === 'latest') {
+    return false;
+  }
+
+  // If the version is an exact match with the legacy versions
+  if (nextLegacyVersions.indexOf(nextVersion) !== -1) {
+    return true;
+  }
+
+  const maxSatisfying = semver.maxSatisfying(nextLegacyVersions, nextVersion);
+  // When the version can't be matched with legacy versions, so it must be a newer version
+  if (maxSatisfying === null) {
+    return false;
+  }
+
+  return true;
+}
+
+const name = '[@now/next]';
+const urls: stringMap = {};
+
+function startDevServer(entryPath: string) {
+  const forked = fork(path.join(__dirname, 'dev-server.js'), [], {
+    cwd: entryPath,
+    execArgv: [],
+    env: {
+      NOW_REGION: 'dev1',
+    },
+  });
+
+  const getUrl = () =>
+    new Promise<string>((resolve, reject) => {
+      forked.on('message', resolve);
+      forked.on('error', reject);
+    });
+
+  return { forked, getUrl };
+}
+
+export const config = {
+  maxLambdaSize: '5mb',
+};
+
+export const build = async ({
+  files,
+  workPath,
+  entrypoint,
+  meta = {} as BuildParamsMeta,
+}: BuildParamsType): Promise<{
+  routes?: any[];
+  output: Files;
+  watch?: string[];
+  childProcesses: ChildProcess[];
+}> => {
+  validateEntrypoint(entrypoint);
+
+  const routes: any[] = [];
+  const entryDirectory = path.dirname(entrypoint);
+  const entryPath = path.join(workPath, entryDirectory);
+  const dotNext = path.join(entryPath, '.next');
+
+  console.log(`${name} Downloading user files...`);
+  await download(files, workPath, meta);
+
+  const pkg = await readPackageJson(entryPath);
+  const nextVersion = getNextVersion(pkg);
+
+  if (!nextVersion) {
+    throw new Error(
+      'No Next.js version could be detected in "package.json". Make sure `"next"` is installed in "dependencies" or "devDependencies"'
+    );
+  }
+
+  process.env.__NEXT_BUILDER_EXPERIMENTAL_TARGET = 'serverless';
+
+  if (meta.isDev) {
+    // eslint-disable-next-line no-underscore-dangle
+    process.env.__NEXT_BUILDER_EXPERIMENTAL_DEBUG = 'true';
+    let childProcess: ChildProcess | undefined;
+
+    // If this is the initial build, we want to start the server
+    if (!urls[entrypoint]) {
+      console.log(`${name} Installing dependencies...`);
+      await runNpmInstall(entryPath, ['--prefer-offline']);
+      const { forked, getUrl } = startDevServer(entryPath);
+      urls[entrypoint] = await getUrl();
+      childProcess = forked;
+      console.log(
+        `${name} Development server for ${entrypoint} running at ${
+          urls[entrypoint]
+        }`
+      );
+    }
+
+    const pathsInside = getPathsInside(entryDirectory, files);
+
+    return {
+      output: {},
+      routes: getRoutes(entryDirectory, pathsInside, files, urls[entrypoint]),
+      watch: pathsInside,
+      childProcesses: childProcess ? [childProcess] : [],
+    };
+  }
+
+  if (await pathExists(dotNext)) {
+    console.warn(
+      'WARNING: You should not upload the `.next` directory. See https://zeit.co/docs/v2/deployments/official-builders/next-js-now-next/ for more details.'
+    );
+  }
+
+  const isLegacy = isLegacyNext(nextVersion);
+
+  console.log(`MODE: ${isLegacy ? 'legacy' : 'serverless'}`);
+
+  if (isLegacy) {
+    try {
+      await unlinkFile(path.join(entryPath, 'yarn.lock'));
+    } catch (err) {
+      console.log('no yarn.lock removed');
+    }
+
+    try {
+      await unlinkFile(path.join(entryPath, 'package-lock.json'));
+    } catch (err) {
+      console.log('no package-lock.json removed');
+    }
+
+    console.warn(
+      "WARNING: your application is being deployed in @now/next's legacy mode. http://err.sh/zeit/now-builders/now-next-legacy-mode"
+    );
+
+    console.log('normalizing package.json');
+    const packageJson = normalizePackageJson(pkg);
+    console.log('normalized package.json result: ', packageJson);
+    await writePackageJson(entryPath, packageJson);
+  } else if (!pkg.scripts || !pkg.scripts['now-build']) {
+    console.warn(
+      'WARNING: "now-build" script not found. Adding \'"now-build": "next build"\' to "package.json" automatically'
+    );
+    pkg.scripts = {
+      'now-build': 'next build',
+      ...(pkg.scripts || {}),
+    };
+    console.log('normalized package.json result: ', pkg);
+    await writePackageJson(entryPath, pkg);
+  }
+
+  if (process.env.NPM_AUTH_TOKEN) {
+    console.log('found NPM_AUTH_TOKEN in environment, creating .npmrc');
+    await writeNpmRc(entryPath, process.env.NPM_AUTH_TOKEN);
+  }
+
+  console.log('installing dependencies...');
+  await runNpmInstall(entryPath, ['--prefer-offline']);
+
+  console.log('running user script...');
+  const memoryToConsume = Math.floor(os.totalmem() / 1024 ** 2) - 128;
+  await runPackageJsonScript(entryPath, 'now-build', {
+    env: {
+      ...process.env,
+      NODE_OPTIONS: `--max_old_space_size=${memoryToConsume}`,
+    },
+  } as SpawnOptions);
+
+  if (isLegacy) {
+    console.log('running npm install --production...');
+    await runNpmInstall(entryPath, ['--prefer-offline', '--production']);
+  }
+
+  if (process.env.NPM_AUTH_TOKEN) {
+    await unlinkFile(path.join(entryPath, '.npmrc'));
+  }
+
+  const lambdas: { [key: string]: Lambda } = {};
+
+  if (isLegacy) {
+    const filesAfterBuild = await glob('**', entryPath);
+
+    console.log('preparing lambda files...');
+    let buildId: string;
+    try {
+      buildId = await readFile(
+        path.join(entryPath, '.next', 'BUILD_ID'),
+        'utf8'
+      );
+    } catch (err) {
+      console.error(
+        'BUILD_ID not found in ".next". The "package.json" "build" script did not run "next build"'
+      );
+      throw new Error('Missing BUILD_ID');
+    }
+    const dotNextRootFiles = await glob('.next/*', entryPath);
+    const dotNextServerRootFiles = await glob('.next/server/*', entryPath);
+    const nodeModules = excludeFiles(
+      await glob('node_modules/**', entryPath),
+      file => file.startsWith('node_modules/.cache')
+    );
+    const launcherFiles = {
+      'now__bridge.js': new FileFsRef({ fsPath: require('@now/node-bridge') }),
+    };
+    const nextFiles: { [key: string]: FileFsRef } = {
+      ...nodeModules,
+      ...dotNextRootFiles,
+      ...dotNextServerRootFiles,
+      ...launcherFiles,
+    };
+    if (filesAfterBuild['next.config.js']) {
+      nextFiles['next.config.js'] = filesAfterBuild['next.config.js'];
+    }
+    const pages = await glob(
+      '**/*.js',
+      path.join(entryPath, '.next', 'server', 'static', buildId, 'pages')
+    );
+    const launcherPath = path.join(__dirname, 'legacy-launcher.js');
+    const launcherData = await readFile(launcherPath, 'utf8');
+
+    await Promise.all(
+      Object.keys(pages).map(async page => {
+        // These default pages don't have to be handled as they'd always 404
+        if (['_app.js', '_error.js', '_document.js'].includes(page)) {
+          return;
+        }
+
+        const pathname = page.replace(/\.js$/, '');
+        const launcher = launcherData.replace(
+          'PATHNAME_PLACEHOLDER',
+          `/${pathname.replace(/(^|\/)index$/, '')}`
+        );
+
+        const pageFiles = {
+          [`.next/server/static/${buildId}/pages/_document.js`]: filesAfterBuild[
+            `.next/server/static/${buildId}/pages/_document.js`
+          ],
+          [`.next/server/static/${buildId}/pages/_app.js`]: filesAfterBuild[
+            `.next/server/static/${buildId}/pages/_app.js`
+          ],
+          [`.next/server/static/${buildId}/pages/_error.js`]: filesAfterBuild[
+            `.next/server/static/${buildId}/pages/_error.js`
+          ],
+          [`.next/server/static/${buildId}/pages/${page}`]: filesAfterBuild[
+            `.next/server/static/${buildId}/pages/${page}`
+          ],
+        };
+
+        console.log(`Creating lambda for page: "${page}"...`);
+        lambdas[path.join(entryDirectory, pathname)] = await createLambda({
+          files: {
+            ...nextFiles,
+            ...pageFiles,
+            'now__launcher.js': new FileBlob({ data: launcher }),
+          },
+          handler: 'now__launcher.launcher',
+          runtime: 'nodejs8.10',
+        });
+        console.log(`Created lambda for page: "${page}"`);
+      })
+    );
+  } else {
+    console.log('preparing lambda files...');
+    const launcherFiles = {
+      'now__bridge.js': new FileFsRef({ fsPath: require('@now/node-bridge') }),
+      'now__launcher.js': new FileFsRef({
+        fsPath: path.join(__dirname, 'launcher.js'),
+      }),
+    };
+    const pages = await glob(
+      '**/*.js',
+      path.join(entryPath, '.next', 'serverless', 'pages')
+    );
+
+    const pageKeys = Object.keys(pages);
+
+    if (pageKeys.length === 0) {
+      const nextConfig = await getNextConfig(workPath, entryPath);
+
+      if (nextConfig != null) {
+        console.info('Found next.config.js:');
+        console.info(nextConfig);
+        console.info();
+      }
+
+      throw new Error(
+        'No serverless pages were built. https://err.sh/zeit/now-builders/now-next-no-serverless-pages-built'
+      );
+    }
+
+    // An optional assets folder that is placed alongside every page entrypoint
+    const assets = await glob(
+      'assets/**',
+      path.join(entryPath, '.next', 'serverless')
+    );
+
+    const assetKeys = Object.keys(assets);
+    if (assetKeys.length > 0) {
+      console.log('detected assets to be bundled with lambda:');
+      assetKeys.forEach(assetFile => console.log(`\t${assetFile}`));
+    }
+
+    await Promise.all(
+      pageKeys.map(async page => {
+        // These default pages don't have to be handled as they'd always 404
+        if (['_app.js', '_error.js', '_document.js'].includes(page)) {
+          return;
+        }
+
+        const pathname = page.replace(/\.js$/, '');
+
+        console.log(`Creating lambda for page: "${page}"...`);
+        lambdas[path.join(entryDirectory, pathname)] = await createLambda({
+          files: {
+            ...launcherFiles,
+            ...assets,
+            'page.js': pages[page],
+          },
+          handler: 'now__launcher.launcher',
+          runtime: 'nodejs8.10',
+        });
+        console.log(`Created lambda for page: "${page}"`);
+      })
+    );
+  }
+
+  const nextStaticFiles = await glob(
+    '**',
+    path.join(entryPath, '.next', 'static')
+  );
+  const staticFiles = Object.keys(nextStaticFiles).reduce(
+    (mappedFiles, file) => ({
+      ...mappedFiles,
+      [path.join(entryDirectory, `_next/static/${file}`)]: nextStaticFiles[
+        file
+      ],
+    }),
+    {}
+  );
+
+  const staticDirectoryFiles = onlyStaticDirectory(
+    includeOnlyEntryDirectory(files, entryDirectory),
+    entryDirectory
+  );
+
+  return {
+    output: { ...lambdas, ...staticFiles, ...staticDirectoryFiles },
+    routes: [],
+    watch: [],
+    childProcesses: [],
+  };
+};
+
+export const prepareCache = async ({
+  workPath,
+  entrypoint,
+}: PrepareCacheOptions) => {
+  console.log('preparing cache ...');
+  const entryDirectory = path.dirname(entrypoint);
+  const entryPath = path.join(workPath, entryDirectory);
+
+  const pkg = await readPackageJson(entryPath);
+  const nextVersion = getNextVersion(pkg);
+  if (!nextVersion) throw new Error('Could not parse Next.js version');
+  const isLegacy = isLegacyNext(nextVersion);
+
+  if (isLegacy) {
+    // skip caching legacy mode (swapping deps between all and production can get bug-prone)
+    return {};
+  }
+
+  console.log('producing cache file manifest ...');
+  const cacheEntrypoint = path.relative(workPath, entryPath);
+  const cache = {
+    ...(await glob(path.join(cacheEntrypoint, 'node_modules/**'), workPath)),
+    ...(await glob(path.join(cacheEntrypoint, '.next/cache/**'), workPath)),
+    ...(await glob(path.join(cacheEntrypoint, 'package-lock.json'), workPath)),
+    ...(await glob(path.join(cacheEntrypoint, 'yarn.lock'), workPath)),
+  };
+  console.log('cache file manifest produced');
+  return cache;
+};

packages/now-next/src/launcher.ts

@@ -0,0 +1,13 @@
+if (!process.env.NODE_ENV) {
+  process.env.NODE_ENV = process.env.NOW_REGION === 'dev1' ? 'development' : 'production';
+}
+
+const { Server } = require('http');
+const { Bridge } = require('./now__bridge');
+const page = require('./page');
+
+const server = new Server(page.render);
+const bridge = new Bridge(server);
+bridge.listen();
+
+exports.launcher = bridge.launcher;

packages/now-next/src/legacy-launcher.ts

@@ -0,0 +1,20 @@
+import { Server } from 'http';
+import next from 'next-server';
+import url from 'url';
+import { Bridge } from './now__bridge';
+
+if (!process.env.NODE_ENV) {
+  process.env.NODE_ENV = process.env.NOW_REGION === 'dev1' ? 'development' : 'production';
+}
+
+const app = next({});
+
+const server = new Server((req, res) => {
+  const parsedUrl = url.parse(req.url || '', true);
+  app.render(req, res, 'PATHNAME_PLACEHOLDER', parsedUrl.query, parsedUrl);
+});
+
+const bridge = new Bridge(server);
+bridge.listen();
+
+exports.launcher = bridge.launcher;

packages/now-next/src/legacy-versions.ts

@@ -1,4 +1,4 @@
-module.exports = [
+export default [
   '0.1.0',
   '0.1.1',
   '0.2.0',

packages/now-next/src/utils.ts

@@ -0,0 +1,222 @@
+import fs from 'fs-extra';
+import path from 'path';
+import { Files } from '@now/build-utils';
+
+type stringMap = {[key: string]: string};
+
+/**
+ * Validate if the entrypoint is allowed to be used
+ */
+function validateEntrypoint(entrypoint: string) {
+  if (
+    !/package\.json$/.exec(entrypoint)
+    && !/next\.config\.js$/.exec(entrypoint)
+  ) {
+    throw new Error(
+      'Specified "src" for "@now/next" has to be "package.json" or "next.config.js"',
+    );
+  }
+}
+
+/**
+ * Exclude certain files from the files object
+ */
+function excludeFiles(files: Files, matcher: (filePath: string) => boolean): Files {
+  return Object.keys(files).reduce((newFiles, filePath) => {
+    if (matcher(filePath)) {
+      return newFiles;
+    }
+    return {
+      ...newFiles,
+      [filePath]: files[filePath],
+    };
+  }, {});
+}
+
+/**
+ * Creates a new Files object holding only the entrypoint files
+ */
+function includeOnlyEntryDirectory(files: Files, entryDirectory: string): Files {
+  if (entryDirectory === '.') {
+    return files;
+  }
+
+  function matcher(filePath: string) {
+    return !filePath.startsWith(entryDirectory);
+  }
+
+  return excludeFiles(files, matcher);
+}
+
+/**
+ * Exclude package manager lockfiles from files
+ */
+function excludeLockFiles(files: Files): Files {
+  const newFiles = files;
+  if (newFiles['package-lock.json']) {
+    delete newFiles['package-lock.json'];
+  }
+  if (newFiles['yarn.lock']) {
+    delete newFiles['yarn.lock'];
+  }
+  return files;
+}
+
+/**
+ * Include the static directory from files
+ */
+function onlyStaticDirectory(files: Files, entryDir: string): Files {
+  function matcher(filePath: string) {
+    return !filePath.startsWith(path.join(entryDir, 'static'));
+  }
+
+  return excludeFiles(files, matcher);
+}
+
+/**
+ * Enforce specific package.json configuration for smallest possible lambda
+ */
+function normalizePackageJson(defaultPackageJson: {dependencies?: stringMap, devDependencies?: stringMap, scripts?: stringMap} = {}) {
+  const dependencies: stringMap = {};
+  const devDependencies: stringMap = {
+    ...defaultPackageJson.dependencies,
+    ...defaultPackageJson.devDependencies,
+  };
+
+  if (devDependencies.react) {
+    dependencies.react = devDependencies.react;
+    delete devDependencies.react;
+  }
+
+  if (devDependencies['react-dom']) {
+    dependencies['react-dom'] = devDependencies['react-dom'];
+    delete devDependencies['react-dom'];
+  }
+
+  return {
+    ...defaultPackageJson,
+    dependencies: {
+      // react and react-dom can be overwritten
+      react: 'latest',
+      'react-dom': 'latest',
+      ...dependencies, // override react if user provided it
+      // next-server is forced to canary
+      'next-server': 'v7.0.2-canary.49',
+    },
+    devDependencies: {
+      ...devDependencies,
+      // next is forced to canary
+      next: 'v7.0.2-canary.49',
+      // next-server is a dependency here
+      'next-server': undefined,
+    },
+    scripts: {
+      ...defaultPackageJson.scripts,
+      'now-build': 'NODE_OPTIONS=--max_old_space_size=3000 next build --lambdas',
+    },
+  };
+}
+
+async function getNextConfig(workPath: string, entryPath: string) {
+  const entryConfig = path.join(entryPath, './next.config.js');
+  if (await fs.pathExists(entryConfig)) {
+    return fs.readFile(entryConfig, 'utf8');
+  }
+
+  const workConfig = path.join(workPath, './next.config.js');
+  if (await fs.pathExists(workConfig)) {
+    return fs.readFile(workConfig, 'utf8');
+  }
+
+  return null;
+}
+
+function pathIsInside(firstPath: string, secondPath: string) {
+  return !path.relative(firstPath, secondPath).startsWith('..');
+}
+
+function getPathsInside(entryDirectory: string, files: Files) {
+  const watch: string[] = [];
+
+  for (const file of Object.keys(files)) {
+    // If the file is outside of the entrypoint directory, we do
+    // not want to monitor it for changes.
+    if (!pathIsInside(entryDirectory, file)) {
+      continue;
+    }
+
+    watch.push(file);
+  }
+
+  return watch;
+}
+
+function getRoutes(entryDirectory: string, pathsInside: string[], files: Files, url: string): any[] {
+  const filesInside: Files = {};
+  const prefix = entryDirectory === `.` ? `/` : `/${entryDirectory}/`;
+
+  for (const file of Object.keys(files)) {
+    if (!pathsInside.includes(file)) {
+      continue;
+    }
+
+    filesInside[file] = files[file];
+  }
+
+  const routes: any[] = [
+    {
+      src: `${prefix}_next/(.*)`,
+      dest: `${url}/_next/$1`
+    },
+    {
+      src: `${prefix}static/(.*)`,
+      dest: `${url}/static/$1`
+    }
+  ];
+
+  for (const file of Object.keys(filesInside)) {
+    const relativePath = path.relative(entryDirectory, file);
+    const isPage = pathIsInside('pages', relativePath);
+
+    if (!isPage) {
+      continue;
+    }
+
+    const relativeToPages = path.relative('pages', relativePath);
+    const extension = path.extname(relativeToPages);
+    const pageName = relativeToPages.replace(extension, '');
+
+    if (pageName.startsWith('_')) {
+      continue;
+    }
+
+    routes.push({
+      src: `${prefix}${pageName}`,
+      dest: `${url}/${pageName}`
+    });
+
+    if (pageName.endsWith('index')) {
+      const resolvedIndex = pageName.replace('/index', '').replace('index', '');
+
+      routes.push({
+        src: `${prefix}${resolvedIndex}`,
+        dest: `${url}/${resolvedIndex}`
+      });
+    }
+  }
+
+  return routes;
+}
+
+export {
+  excludeFiles,
+  validateEntrypoint,
+  includeOnlyEntryDirectory,
+  excludeLockFiles,
+  normalizePackageJson,
+  onlyStaticDirectory,
+  getNextConfig,
+  getPathsInside,
+  getRoutes,
+  stringMap,
+};

packages/now-next/test/integration/index.test.js

@@ -1,17 +1,17 @@
 /* global it, expect */
 const path = require('path');
-const runBuildLambda = require('../../lib/run-build-lambda');
+const runBuildLambda = require('../../../../test/lib/run-build-lambda');
 
 const FOUR_MINUTES = 240000;
 
 it(
   'Should build the standard example',
   async () => {
-    const { buildResult } = await runBuildLambda(
-      path.join(__dirname, 'standard'),
-    );
-    expect(buildResult.index).toBeDefined();
-    const filePaths = Object.keys(buildResult);
+    const {
+      buildResult: { output },
+    } = await runBuildLambda(path.join(__dirname, 'standard'));
+    expect(output.index).toBeDefined();
+    const filePaths = Object.keys(output);
     const hasUnderScoreAppStaticFile = filePaths.some(filePath => filePath.match(/static.*\/pages\/_app\.js$/));
     const hasUnderScoreErrorStaticFile = filePaths.some(filePath => filePath.match(/static.*\/pages\/_error\.js$/));
     expect(hasUnderScoreAppStaticFile).toBeTruthy();
@@ -23,11 +23,12 @@ it(
 it(
   'Should build the monorepo example',
   async () => {
-    const { buildResult } = await runBuildLambda(
-      path.join(__dirname, 'monorepo'),
-    );
-    expect(buildResult['www/index']).toBeDefined();
-    const filePaths = Object.keys(buildResult);
+    const {
+      buildResult: { output },
+    } = await runBuildLambda(path.join(__dirname, 'monorepo'));
+    expect(output['www/index']).toBeDefined();
+    expect(output['www/static/test.txt']).toBeDefined();
+    const filePaths = Object.keys(output);
     const hasUnderScoreAppStaticFile = filePaths.some(filePath => filePath.match(/static.*\/pages\/_app\.js$/));
     const hasUnderScoreErrorStaticFile = filePaths.some(filePath => filePath.match(/static.*\/pages\/_error\.js$/));
     expect(hasUnderScoreAppStaticFile).toBeTruthy();
@@ -39,11 +40,11 @@ it(
 it(
   'Should build the legacy standard example',
   async () => {
-    const { buildResult } = await runBuildLambda(
-      path.join(__dirname, 'legacy-standard'),
-    );
-    expect(buildResult.index).toBeDefined();
-    const filePaths = Object.keys(buildResult);
+    const {
+      buildResult: { output },
+    } = await runBuildLambda(path.join(__dirname, 'legacy-standard'));
+    expect(output.index).toBeDefined();
+    const filePaths = Object.keys(output);
     const hasUnderScoreAppStaticFile = filePaths.some(filePath => filePath.match(/static.*\/pages\/_app\.js$/));
     const hasUnderScoreErrorStaticFile = filePaths.some(filePath => filePath.match(/static.*\/pages\/_error\.js$/));
     expect(hasUnderScoreAppStaticFile).toBeTruthy();
@@ -55,10 +56,10 @@ it(
 it(
   'Should build the legacy custom dependency test',
   async () => {
-    const { buildResult } = await runBuildLambda(
-      path.join(__dirname, 'legacy-custom-dependency'),
-    );
-    expect(buildResult.index).toBeDefined();
+    const {
+      buildResult: { output },
+    } = await runBuildLambda(path.join(__dirname, 'legacy-custom-dependency'));
+    expect(output.index).toBeDefined();
   },
   FOUR_MINUTES,
 );
@@ -75,12 +76,23 @@ it('Should throw when package.json or next.config.js is not the "src"', async ()
 });
 
 it(
-  'Should build the static-files test',
+  'Should build the static-files test on legacy',
   async () => {
-    const { buildResult } = await runBuildLambda(
-      path.join(__dirname, 'legacy-static-files'),
-    );
-    expect(buildResult['static/test.txt']).toBeDefined();
+    const {
+      buildResult: { output },
+    } = await runBuildLambda(path.join(__dirname, 'legacy-static-files'));
+    expect(output['static/test.txt']).toBeDefined();
+  },
+  FOUR_MINUTES,
+);
+
+it(
+  'Should build the static-files test',
+  async () => {
+    const {
+      buildResult: { output },
+    } = await runBuildLambda(path.join(__dirname, 'static-files'));
+    expect(output['static/test.txt']).toBeDefined();
   },
   FOUR_MINUTES,
 );

packages/now-next/test/integration/monorepo/www/static/test.txt

@@ -0,0 +1 @@
+hello world

packages/now-next/test/integration/static-files/next.config.js

@@ -0,0 +1,3 @@
+module.exports = {
+  target: 'serverless',
+};

packages/now-next/test/integration/static-files/now.json

@@ -0,0 +1,6 @@
+{
+  "version": 2,
+  "builds": [
+    {"src": "next.config.js", "use": "@now/next"}
+  ]
+}